Author

Topic: [ANN][DASH] Dash (dash.org) | First Self-Funding Self-Governing Crypto Currency - page 3338. (Read 9723768 times)

legendary
Activity: 1708
Merit: 1049
darkcoin finally getting real code review.  

Tens of bugs and vulnerabilities have been found in prior reviews. It will take some more time (and more eyes) to make it bulletproof.

Personally I think the whole Masternode payment system should be replaced by another cleaner system that works at the protocol level. No enforcement or centralization would be necessary, while eliminating forking risk.

Perhaps the spreadcoin dev might want to have a go at such a system.



Cleaner?? protocol level? What centralisation?  Whats clean about thousands of clients going on and off every second while trying to maintain rounds of anonymity? That would juts cause mayhem. What is unclean about blind nodes with 100% uptime? And what about PoService?

 I dont get it.

I don't remember when you got on board, but prior to the semi-voluntary scheme of payments with enforcement threat, there was a direction of mandatory payments (100%) with no enforcement needed whatsoever. Unfortunately it caused forks in the production environment so then we got to a situation where some people were calling for no hard forks, others were in favor to get the job done - even if it includes a few more problematic forks as a byproduct etc etc. Then we got the spork and the rest is history.
legendary
Activity: 1092
Merit: 1000
darkcoin finally getting real code review.  

Tens of bugs and vulnerabilities have been found in prior reviews. It will take some more time (and more eyes) to make it bulletproof.

Personally I think the whole Masternode payment system should be replaced by another cleaner system that works at the protocol level. No enforcement or centralization would be necessary, while eliminating forking risk.

Perhaps the spreadcoin dev might want to have a go at such a system.



Cleaner?? protocol level? What centralisation?  Whats clean about thousands of clients going on and off every second while trying to maintain rounds of anonymity? That would juts cause mayhem. What is unclean about blind nodes with 100% uptime? And what about PoService?

 I dont get it.

 
legendary
Activity: 1708
Merit: 1049
darkcoin finally getting real code review.  

Tens of bugs and vulnerabilities have been found in prior reviews. It will take some more time (and more eyes) to make it bulletproof.

Personally I think the whole Masternode payment system should be replaced by another cleaner system that works at the protocol level. No enforcement or centralization would be necessary, while eliminating forking risk.

Perhaps the spreadcoin dev might want to have a go at such a system.

hero member
Activity: 658
Merit: 500
The Buck Stops Here.
darkcoin finally getting real code review.  

What's with all these "Spread" accounts now? Even Mr. Spread sounds belligerent. Not a good way to make a first impression gentlemen.
newbie
Activity: 42
Merit: 0
darkcoin finally getting real code review.  
full member
Activity: 210
Merit: 100
Anyone knows why average spacing between DarkCoin blocks is approximately 157 seconds instead of 150 seconds? I remember that when creating SpreadCoin several months ago I noted that there is a small bug in DarkCoin difficulty retarget which causes block generation to be a bit slower than it should be. But it seems that I lost this knowledge. When I'm now looking at difficulty retarget it looks correct to me, although a bit obfuscated.

This has been known for some time and isn't worth fixing. I'll explain why:

https://github.com/darkcoin/darkcoin/blob/master/src/main.cpp#L1607
https://github.com/darkcoin/darkcoin/blob/master/src/main.cpp#L1453

One of them is computing 24 blocks and one is computing 23. So:

1/24.0 == 0.0416
2.5*1.0416 == 2.604 (minutes)

Statistically it's doing exactly what it should!
Here is the DarkCoin retarget formula freed from any obfuscation and without clamping:

where Ti is the target of i-th block and ti is the timestamp of i-th block.
Initially I thought that this is because previous block is counted twice but it is divided by 25, not 24, so it's ok. But look at actual timespan computation: ti-1 - ti-24 but 24 - 1 = 23, so it is actually timespan of 23 blocks. 23 blocks per hour instead of 24. This is 156.522 seconds or 2.6087 minutes of spacing between blocks.
By the way, I don't see here any "multiple exponential moving averages" as white paper states, where are they?
legendary
Activity: 1722
Merit: 1002
Decentralize Everything
Anyone knows why average spacing between DarkCoin blocks is approximately 157 seconds instead of 150 seconds? I remember that when creating SpreadCoin several months ago I noted that there is a small bug in DarkCoin difficulty retarget which causes block generation to be a bit slower than it should be. But it seems that I lost this knowledge. When I'm now looking at difficulty retarget it looks correct to me, although a bit obfuscated.

This has been known for some time and isn't worth fixing. I'll explain why:

https://github.com/darkcoin/darkcoin/blob/master/src/main.cpp#L1607
https://github.com/darkcoin/darkcoin/blob/master/src/main.cpp#L1453

One of them is computing 24 blocks and one is computing 23. So:

1/24.0 == 0.0416
2.5*1.0416 == 2.604 (minutes)

Statistically it's doing exactly what it should!



I'm loving the fact that you're spotting stuff like this Mr Spread.  This is what makes open source so worthwhile  Smiley
legendary
Activity: 1176
Merit: 1036
Dash Developer
Anyone knows why average spacing between DarkCoin blocks is approximately 157 seconds instead of 150 seconds? I remember that when creating SpreadCoin several months ago I noted that there is a small bug in DarkCoin difficulty retarget which causes block generation to be a bit slower than it should be. But it seems that I lost this knowledge. When I'm now looking at difficulty retarget it looks correct to me, although a bit obfuscated.

This has been known for some time and isn't worth fixing. I'll explain why:

https://github.com/darkcoin/darkcoin/blob/master/src/main.cpp#L1607
https://github.com/darkcoin/darkcoin/blob/master/src/main.cpp#L1453

One of them is computing 24 blocks and one is computing 23. So:

1/24.0 == 0.0416
2.5*1.0416 == 2.604 (minutes)

Statistically it's doing exactly what it should!

full member
Activity: 210
Merit: 100
Anyone knows why average spacing between DarkCoin blocks is approximately 157 seconds instead of 150 seconds? I remember that when creating SpreadCoin several months ago I noted that there is a small bug in DarkCoin difficulty retarget which causes block generation to be a bit slower than it should be. But it seems that I lost this knowledge. When I'm now looking at difficulty retarget it looks correct to me, although a bit obfuscated.
legendary
Activity: 1318
Merit: 1040
Change log for this version? I can't seem to find any info over at darkcointalk.

Am I the only one who gets nervous when a download link is only provided on BCT? I always feel better when I see the update info on both BCT and DCT so that I know ED's BCT account wasn't hacked and linking to a virus. Anyways the link points to the right repository so I updated my MN's to .24. OK enough acronyms for now.

Latest version is also published in darkcoin.io/downloads and you can verify signatures with the info over there.

thanks, will check that source link as well next time. What about the change log for this version?
Not sure, the one in github doesn'¡t seem to be updated, but I guess there is something somewhere else:
https://github.com/darkcoinproject/darkcoin-binaries/blob/master/CHANGELOG.md

You can always look at the commits to see what changed version to version.
yep, https://github.com/darkcoin/darkcoin/compare/v0.10.17.23...v0.10.17.24

To summarize:
- fix dseep DoS
- fix anonymizeonly walletpassphrase parameter for console https://darkcointalk.org/threads/liquidity-provider-unlock-for-mixing.3227/
- improve support for start-many (thanks freynder!), more info on how it should work now https://github.com/darkcoin/darkcoin/pull/62
- fix wallet locking after sending coins https://darkcointalk.org/threads/wallet-unlock-bug.3206/
- fixed possible masternode payment exploit
legendary
Activity: 1442
Merit: 1018
Change log for this version? I can't seem to find any info over at darkcointalk.

Am I the only one who gets nervous when a download link is only provided on BCT? I always feel better when I see the update info on both BCT and DCT so that I know ED's BCT account wasn't hacked and linking to a virus. Anyways the link points to the right repository so I updated my MN's to .24. OK enough acronyms for now.

Latest version is also published in darkcoin.io/downloads and you can verify signatures with the info over there.

thanks, will check that source link as well next time. What about the change log for this version?
Not sure, the one in github doesn'¡t seem to be updated, but I guess there is something somewhere else:
https://github.com/darkcoinproject/darkcoin-binaries/blob/master/CHANGELOG.md

You can always look at the commits to see what changed version to version.
hero member
Activity: 560
Merit: 500
Change log for this version? I can't seem to find any info over at darkcointalk.

Am I the only one who gets nervous when a download link is only provided on BCT? I always feel better when I see the update info on both BCT and DCT so that I know ED's BCT account wasn't hacked and linking to a virus. Anyways the link points to the right repository so I updated my MN's to .24. OK enough acronyms for now.

Latest version is also published in darkcoin.io/downloads and you can verify signatures with the info over there.

thanks, will check that source link as well next time. What about the change log for this version?
Not sure, the one in github doesn'¡t seem to be updated, but I guess there is something somewhere else:
https://github.com/darkcoinproject/darkcoin-binaries/blob/master/CHANGELOG.md
sr. member
Activity: 378
Merit: 250
sr. member
Activity: 378
Merit: 250
Who are dumping drk? some problem?
legendary
Activity: 1372
Merit: 1005
DASH is the future of crypto payments!
Change log for this version? I can't seem to find any info over at darkcointalk.

Am I the only one who gets nervous when a download link is only provided on BCT? I always feel better when I see the update info on both BCT and DCT so that I know ED's BCT account wasn't hacked and linking to a virus. Anyways the link points to the right repository so I updated my MN's to .24. OK enough acronyms for now.
Check official page and PGP
https://www.darkcoin.io/downloads/
EDIT: Fernando I see you were a bit faster Wink
sr. member
Activity: 350
Merit: 250
Change log for this version? I can't seem to find any info over at darkcointalk.

Am I the only one who gets nervous when a download link is only provided on BCT? I always feel better when I see the update info on both BCT and DCT so that I know ED's BCT account wasn't hacked and linking to a virus. Anyways the link points to the right repository so I updated my MN's to .24. OK enough acronyms for now.

Latest version is also published in darkcoin.io/downloads and you can verify signatures with the info over there.

thanks, will check that source link as well next time. What about the change log for this version?
hero member
Activity: 560
Merit: 500
Change log for this version? I can't seem to find any info over at darkcointalk.

Am I the only one who gets nervous when a download link is only provided on BCT? I always feel better when I see the update info on both BCT and DCT so that I know ED's BCT account wasn't hacked and linking to a virus. Anyways the link points to the right repository so I updated my MN's to .24. OK enough acronyms for now.

Latest version is also published in darkcoin.io/downloads and you can verify signatures with the info over there.
member
Activity: 115
Merit: 10
Is there any reward for discovering bugs and vulnerabilities? I have found several other bugs.

Glade to see there is some code review from outside and FOUND (some) bug(s). It makes the Darkcoin project more healthy and strong.
Many thanks to Mr. Spread if you could share your discovering~  Grin

EDIT: I'm pretty sure you could get some reward if you post the bugs on Darkcointalk or here . This is one of the greatest community in Crypto world~ Maybe the BEST~ Smiley


As usual, the quick response and action. Great job, Evan and the Dev-team.
Looking forward to crash other bug(s) before we start the InstantX testing.  Wink

And finally, we get some volatility~
sr. member
Activity: 350
Merit: 250
Change log for this version? I can't seem to find any info over at darkcointalk.

Am I the only one who gets nervous when a download link is only provided on BCT? I always feel better when I see the update info on both BCT and DCT so that I know ED's BCT account wasn't hacked and linking to a virus. Anyways the link points to the right repository so I updated my MN's to .24. OK enough acronyms for now.
legendary
Activity: 3066
Merit: 1188
Wink
at least you kept your humor.

LoL. I was considering that but before I knew it I was at the back of the queue for "losing my humour" so decided to laugh instead Smiley
Jump to: