Pages:
Author

Topic: bitcoin "unlimited" seeks review - page 11. (Read 16106 times)

sr. member
Activity: 404
Merit: 362
in bitcoin we trust
January 02, 2016, 02:41:01 PM
#10
From what I understand, BU moves the block size limit from consensus rules to a node policy rule. Instead of having the limit hard coded in, the user chooses their own block size limit. Also if a BU node detects a blockchain that has a higher block size (up to a certain user configurable threshold), after that chain is a number of blocks deep (user configurable), then it will switch to use that blockchain and set its block size limit higher.

So what happens if I left my node at 1MB +10% user threshold and a 1.2MB block comes - does my node reject it?

How will the network not split into a myriad little shards which diverge following accidental and/or intentional double-spends without manual human coordination?

Adam
staff
Activity: 3458
Merit: 6793
Just writing some code
January 02, 2016, 02:37:06 PM
#9
From what I understand, BU moves the block size limit from consensus rules to a node policy rule. Instead of having the limit hard coded in, the user chooses their own block size limit. Also if a BU node detects a blockchain that has a higher block size (up to a certain user configurable threshold), after that chain is a number of blocks deep (user configurable), then it will switch to use that blockchain and set its block size limit higher.
sr. member
Activity: 404
Merit: 362
in bitcoin we trust
January 02, 2016, 02:27:16 PM
#8
If you can stay on topic as I suggested: "To make progress on review it would be helpful to separate technical from political opinions." I dont see a problem. People have been discussing bitcoin NG ideas on here for years.

Are you able to explain what BU is and how you think it works?  I gave some reviewer questions in the OP.

Adam
sr. member
Activity: 404
Merit: 362
in bitcoin we trust
January 02, 2016, 02:18:17 PM
#7
More review of both core and BU is recommended and encouraged.

Agree I was kind of hoping Aquentys would be able to explain what it is and how they think it works.  It saves time reviewing when people take the time to explain their assumptions.

Adam


Here are some links from kanzure on IRC (Aquentys started a discussion but wanted to continue on a forum for persistence):

Quote
here is where peter rizun admitted that his assumptions in his "fee market" paper were totally broken: http://pastebin.com/jFgkk8M3
20:05 this pastebin paste was made by the same person too
20:06 here is some basic argumentation about big blocks and how increasing resource requirements kick off low-resource participants https://www.reddit.com/r/Bitcoin/comments/3yvkep/devs_are_strongly_against_increasing_the/cyhv7ev
here is why it doesn't matter if transaction fees can pay for big block orphan risk: https://www.reddit.com/r/Bitcoin/comments/3yod27/greg_maxwell_was_wrong_transaction_fees_can_pay/cyfluso
20:07 here is why peter rizun's unhealthy fee market doesn't actually control block size https://np.reddit.com/r/btc/comments/3xkok3/reduce_orphaning_risk_and_improve/cy60r4y
20:08 here is why it is uninteresting to have a bunch of high-bandwidth miners having consensus just among themselves https://www.reddit.com/r/Bitcoin/comments/3ycizh/decentralizing_development_can_we_make_bitcoins/cycex9t
20:09 here is a roadmap for bitcoin core scalability increases that bitcoin core developers have been working on http://lists.linuxfoundation.org/pipermail/bitcoin-dev/2015-December/011865.html
20:09 in particular for frequently asked questions see https://bitcoin.org/en/bitcoin-core/capacity-increases-faq

Adam
sr. member
Activity: 404
Merit: 362
in bitcoin we trust
January 02, 2016, 02:13:58 PM
#6
More review of both core and BU is recommended and encouraged.

Agree I was kind of hoping Aquentys would be able to explain what it is and how they think it works.  It saves time reviewing when people take the time to explain their assumptions.

Adam
legendary
Activity: 994
Merit: 1035
January 02, 2016, 02:07:44 PM
#5
i hope this thread will not waste too much dev-time for nothing in the end. PR is necessary but time is limited too.

We shouldn't assume the Core developers or anyone else is immune from review and I believe there is always something to learn my looking over other implementations. I think it is both extremely healthy for there to be multiple implementations in our ecosystem with different project maintainers and for them to both collaborate and review each others work. We should support Core, BU , libbitcoin , and others with testing.


To add to the discussion Gavin represents a qualified outside developer that conducted a very brief review of the code and this was his response-

https://bitco.in/forum/threads/i-really-want-to-like-bitcoin-unlimited.684/

Quote from: Gavin
I love the idea of Bitcoin Unlimited, but after doing a quick code review I just can't recommend that people run it -- there are too many "bad code smells."

Examples:

https://github.com/gandrewstone/BitcoinUnlimited/commit/9b05e2e9f7eb4d8e847c57ae06d8bd34b1f03552

... which is a commit with title 'wip' (work in progress). Un-descriptive commit titles/messages are bad... as is committing a work in progress before it is finished.

Or commits which comment out code, which is, in general, bad practice (if code isn't needed it should be removed-- your version control system keeps old code if you change your mind and decide later if you need it).

The most critical commit:
https://github.com/gandrewstone/BitcoinUnlimited/commit/b126b10a1675c52acd0d7df857afe8057cfb6fb3

... doesn't seem to have any unit or regression tests. I would expect the commit message to at least say something about how the code was tested.

Andrew, do you have experience leading an open source software project? Ideally Bitcoin Unlimited would be lead by somebody who has a track record in projects that produce very high quality, reliable code (on time and under budget Smiley ) (and no, I'm not volunteering....)

More review of both core and BU is recommended and encouraged.
legendary
Activity: 1148
Merit: 1014
In Satoshi I Trust
January 02, 2016, 01:38:48 PM
#4
The proposers of bitcoin unlimited said they would like to get some review which seems reasonable, if others would like to help.

The proposal seems at first skim to be a copy of a few existing technologies from Bitcoin's roadmap and were first proposed by Greg Maxwell and others*: weak-blocks & network-compression/IBLT to reduce orphan risk, and flexcap (or a variant of it perhaps).

Perhaps they could start by explaining what it is & how it works.  This might include unimplemented ideas, and a summary of what the code currently for download on the manifesto page does.


...


i feel a little bit sarcasm  Tongue ?

i hope this thread will not waste too much dev-time for nothing in the end. PR is necessary but time is limited too.
sr. member
Activity: 404
Merit: 362
in bitcoin we trust
January 02, 2016, 01:30:32 PM
#3
If you want info about Bitcoin Unlimited you should check out their forum (https://bitco.in/forum/forums/bitcoin-unlimited.15/). Most of their discussions is there, including technical and not.

The idea was to have some technical focussed constructive discourse and this is a more neutral forum and also where more Bitcoin experts hang out.

Adam
staff
Activity: 3458
Merit: 6793
Just writing some code
January 02, 2016, 01:25:55 PM
#2
If you want info about Bitcoin Unlimited you should check out their forum (https://bitco.in/forum/forums/bitcoin-unlimited.15/). Most of their discussions is there, including technical and not.
sr. member
Activity: 404
Merit: 362
in bitcoin we trust
January 02, 2016, 12:58:17 PM
#1
The proposers of bitcoin unlimited said they would like to get some review which seems reasonable, if others would like to help.

The proposal seems at first skim to be a copy of a few existing technologies from Bitcoin's roadmap and were first proposed by Greg Maxwell and others*: weak-blocks & network-compression/IBLT to reduce orphan risk, and flexcap (or a variant of it perhaps).

Perhaps they could start by explaining what it is & how it works.  This might include unimplemented ideas, and a summary of what the code currently for download on the manifesto page does.

To review it will be clearer if you state your assumptions, and claimed benefits, and why you think those benefits hold.  (Bear in mind if input assumptions are theoretical and known to not hold in practice, while that can be fine for theoretical results, it will be difficult to use the resulting conclusions in a real system).  Particularly claimed compatibilities with Bitcoin and how the dynamic block-size game-theory is expected to work and remain secure with SPV mining, selfish-mining, block-withholding and fair (progress-free) mining could also use explaining.

I suggest the sensible thing is if there is something new or insightful, that Bitcoin consider adopting the technology and the BU proponents get behind that.

Maintaining a new coin is a rather complex undertaking and screwing up, as something like 40% of projects that have tried it have done, is very expensive of other peoples money.

To make progress on review it would be helpful to separate technical from political opinions.

Adam

* some citations seem to be notably missing, I trust this is unintentional.
Pages:
Jump to: