[coinb.in] Open Source, Multi Signature, HD Wallet, SegWit/Bech32 and more! - page 16.

WiW

sr. member

Activity: 277

Merit: 250

"The public is stupid, hence the public will pay"

Quote from: chriswilmer on March 23, 2014, 06:30:11 PM

Quote from: WiW on March 23, 2014, 06:05:15 PM

My 3 of 5 is being rejected... The "verify script" shows all in order. Blockchain.info pushtx:

Quote

Script not of right size, expecting 2 but got 5

I couldn't use Blockchain.info's pushtx for this. *shrugs*

I just used the one on OPs website.

Coinb.in is also failing... I also just tried a 3 of 4...

Edit: I was running the multisig locally, maybe that's why it failed (doesn't explain why blockchain.info failed...) - it worked on the site. Let's see if it gets into the blockchain.

chriswilmer

legendary

Activity: 1008

Merit: 1000

Quote from: WiW on March 23, 2014, 06:05:15 PM

My 3 of 5 is being rejected... The "verify script" shows all in order. Blockchain.info pushtx:

Quote

Script not of right size, expecting 2 but got 5

I couldn't use Blockchain.info's pushtx for this. *shrugs*

I just used the one on OPs website.

WiW

sr. member

Activity: 277

Merit: 250

"The public is stupid, hence the public will pay"

My 3 of 5 is being rejected... The "verify script" shows all in order. Blockchain.info pushtx:

Quote

Script not of right size, expecting 2 but got 5

chriswilmer

legendary

Activity: 1008

Merit: 1000

Quote from: WiW on March 23, 2014, 12:37:58 PM

Trying to figure out how the signature process works (so far only getting rejections). Do I broadcast signed(txn,key1)+signed(txn,key2) or do I broadcast signed(signed(txn,key1),key2)?

Was about to offer a bounty for someone to do this... Thanks!

The second one.

WiW

sr. member

Activity: 277

Merit: 250

"The public is stupid, hence the public will pay"

Trying to figure out how the signature process works (so far only getting rejections). Do I broadcast signed(txn,key1)+signed(txn,key2) or do I broadcast signed(signed(txn,key1),key2)?

Was about to offer a bounty for someone to do this... Thanks!

chriswilmer

legendary

Activity: 1008

Merit: 1000

Do 3 of 4 transactions work? Somebody told me that miners won't mine them...

EDIT: Nevermind, just did a 3 of 4 transaction that was mined successfully. Great!

americandesi

hero member

Activity: 518

Merit: 500

BTC < > INR & USD

Very nice implementation. Watching it.
I have a a couple of quick questions if someone can clarify.

1) What are the requirements / pre-requisite softwares or client that is required to be running on the server to implement it.

2) On coinb.in/multisig i see that there is a 1% Agent fee option. How does that work? Is it like as soon as the multi-address is funded, the 1% fee is sent to OutCast3k's (or any agent's) bitcoin address.?

Thanks,

chriswilmer

legendary

Activity: 1008

Merit: 1000

Quote from: OutCast3k on March 11, 2014, 08:52:18 AM

Quote from: chriswilmer on March 08, 2014, 01:57:20 PM

Quote from: chriswilmer on March 08, 2014, 01:26:29 PM

I have a feature request...

... I'd like to be able to use this script on an offline computer... but right now it checks the balance of the multisig address and won't let me generate a transaction if it think that address has a zero balance. If I'm not online, I'm not sure if it would let me generate a transaction or not... any tips or workarounds?

I'll probably just edit the source code locally for what I want... but, for what it's worth, I think other people may want to run this on an offline computer too.

Just made my first successful multisignature transaction with this. Pretty sweet.

I will have a think about this feature and consider adding it to the next update.

I'll make sure to donate if you do Wink

OutCast3k

hero member

Activity: 714

Merit: 601

Quote from: chriswilmer on March 08, 2014, 01:57:20 PM

Quote from: chriswilmer on March 08, 2014, 01:26:29 PM

I have a feature request...

... I'd like to be able to use this script on an offline computer... but right now it checks the balance of the multisig address and won't let me generate a transaction if it think that address has a zero balance. If I'm not online, I'm not sure if it would let me generate a transaction or not... any tips or workarounds?

I'll probably just edit the source code locally for what I want... but, for what it's worth, I think other people may want to run this on an offline computer too.

Just made my first successful multisignature transaction with this. Pretty sweet.

I will have a think about this feature and consider adding it to the next update.

OutCast3k

hero member

Activity: 714

Merit: 601

Quote from: fireduck on March 10, 2014, 12:38:54 PM

Thanks for doing this important work for Bitcoin. I think tools like this are really important to keeping things accessible and useful.

https://blockchain.info/tx/edd6cac670dd5ac99016dff17025faa8a953b6df59ed37ac9ffbbaeb7c2c1939

Feature request: Signed release notes

I don't think it is necessary to do what is being done with bitaddress.org (single source file with checksum built into filename) but a signed release would be cool.

A simple version log simple like:

--- Version 0.1 2014.03.10 ----
: sha1sum index.html js/* css/*
217379fdde1e208fcebef231e4e45af87db108cc index.html
add6e1cd5358e701748df05d27b1ea12242ea2bd js/bitcoinjs-min.js
66c84a3b3549a33997247e1f8032f172453682d3 js/bootstrap.js
15a81fe4074f920898e98b1b42cf11bda26da0a8 js/bootstrap.min.js
ae49e56999d82802727455f0ba83b63acd90a22b js/jquery-1.9.1.min.js
64ccd2fa29f517043101a651845a3e73e29fd2db css/bootstrap.css
ff1c6a04dd80cba8521a850cae728abb41ea9ef3 css/bootstrap.min.css
95d87b7b04ee6dd10a855127ea1bcfa75afdeada css/bootstrap-theme.css
3b38955d745c3fa36017f3cb7d72ceb18c587e66 css/bootstrap-theme.min.css
8297b8f4d686ec6c65981077514975e06ce41812 css/style.css

In this version, angry wombats should no longer plague users. Also, badger mode is enabled by default as it is very popular.

Thanks, I'm glad you like the project, and thanks for the tip, very grateful.

I will happily include a checksum log with any future updates, good suggestion!

fireduck

sr. member

Activity: 392

Merit: 251

Thanks for doing this important work for Bitcoin. I think tools like this are really important to keeping things accessible and useful.

https://blockchain.info/tx/edd6cac670dd5ac99016dff17025faa8a953b6df59ed37ac9ffbbaeb7c2c1939

Feature request: Signed release notes

I don't think it is necessary to do what is being done with bitaddress.org (single source file with checksum built into filename) but a signed release would be cool.

A simple version log simple like:

--- Version 0.1 2014.03.10 ----
: sha1sum index.html js/* css/*
217379fdde1e208fcebef231e4e45af87db108cc index.html
add6e1cd5358e701748df05d27b1ea12242ea2bd js/bitcoinjs-min.js
66c84a3b3549a33997247e1f8032f172453682d3 js/bootstrap.js
15a81fe4074f920898e98b1b42cf11bda26da0a8 js/bootstrap.min.js
ae49e56999d82802727455f0ba83b63acd90a22b js/jquery-1.9.1.min.js
64ccd2fa29f517043101a651845a3e73e29fd2db css/bootstrap.css
ff1c6a04dd80cba8521a850cae728abb41ea9ef3 css/bootstrap.min.css
95d87b7b04ee6dd10a855127ea1bcfa75afdeada css/bootstrap-theme.css
3b38955d745c3fa36017f3cb7d72ceb18c587e66 css/bootstrap-theme.min.css
8297b8f4d686ec6c65981077514975e06ce41812 css/style.css

In this version, angry wombats should no longer plague users. Also, badger mode is enabled by default as it is very popular.

chriswilmer

legendary

Activity: 1008

Merit: 1000

Quote from: chriswilmer on March 08, 2014, 01:26:29 PM

I have a feature request...

... I'd like to be able to use this script on an offline computer... but right now it checks the balance of the multisig address and won't let me generate a transaction if it think that address has a zero balance. If I'm not online, I'm not sure if it would let me generate a transaction or not... any tips or workarounds?

I'll probably just edit the source code locally for what I want... but, for what it's worth, I think other people may want to run this on an offline computer too.

Just made my first successful multisignature transaction with this. Pretty sweet.

chriswilmer

legendary

Activity: 1008

Merit: 1000

I have a feature request...

... I'd like to be able to use this script on an offline computer... but right now it checks the balance of the multisig address and won't let me generate a transaction if it think that address has a zero balance. If I'm not online, I'm not sure if it would let me generate a transaction or not... any tips or workarounds?

chriswilmer

legendary

Activity: 1008

Merit: 1000

Just discovered this... AWESOME!!!

waxwing

sr. member

Activity: 469

Merit: 253

Quote from: Peter Todd on March 07, 2014, 01:16:42 PM

Nope - ask yourself if a P2SH output matches that code. Also ask yourself what the code path is that evaluates scriptSigs for standardness.

Cool I managed to do 3 of 4 via an electrum server.

Many thanks for the edumacation Cheesy

Not quite yet capable of figuring it out from the source; but will try to follow your hints at some point...

Peter Todd

legendary

Activity: 1120

Merit: 1152

Quote from: waxwing on March 07, 2014, 12:05:45 PM

Quote from: Peter Todd on March 07, 2014, 11:23:01 AM

Quote from: waxwing on March 07, 2014, 11:05:44 AM

I agree. But no one except Eligius is accepting more than 3 right?

Actually no! P2SH doesn't have an explicit limitations beyond the 520byte P2SH redeemScript limit, and more importantly the 500-byte scriptSig limit for IsStandard() transactions, so n and m just need to fit within that. Try it!

Thanks for the tip. Will do

Edit: actually before I go through all that ... doesn't this mean it won't work?:

Code:

bool IsStandard(const CScript& scriptPubKey, txnouttype& whichType)
{
    vector vSolutions;
    if (!Solver(scriptPubKey, whichType, vSolutions))
        return false;

    if (whichType == TX_MULTISIG)
    {
        unsigned char m = vSolutions.front()[0];
        unsigned char n = vSolutions.back()[0];
        // Support up to x-of-3 multisig txns as standard
        if (n < 1 || n > 3)
            return false;
        if (m < 1 || m > n)
            return false;
    }

    return whichType != TX_NONSTANDARD;
}

?

Nope - ask yourself if a P2SH output matches that code. Also ask yourself what the code path is that evaluates scriptSigs for standardness.

waxwing

sr. member

Activity: 469

Merit: 253

Quote from: Peter Todd on March 07, 2014, 11:23:01 AM

Quote from: waxwing on March 07, 2014, 11:05:44 AM

I agree. But no one except Eligius is accepting more than 3 right?

Actually no! P2SH doesn't have an explicit limitations beyond the 520byte P2SH redeemScript limit, and more importantly the 500-byte scriptSig limit for IsStandard() transactions, so n and m just need to fit within that. Try it!

Thanks for the tip. Will do

Edit: actually before I go through all that ... doesn't this mean it won't work?:

Code:

bool IsStandard(const CScript& scriptPubKey, txnouttype& whichType)
{
    vector vSolutions;
    if (!Solver(scriptPubKey, whichType, vSolutions))
        return false;

    if (whichType == TX_MULTISIG)
    {
        unsigned char m = vSolutions.front()[0];
        unsigned char n = vSolutions.back()[0];
        // Support up to x-of-3 multisig txns as standard
        if (n < 1 || n > 3)
            return false;
        if (m < 1 || m > n)
            return false;
    }

    return whichType != TX_NONSTANDARD;
}

?

Peter Todd

legendary

Activity: 1120

Merit: 1152

Quote from: waxwing on March 07, 2014, 11:05:44 AM

I agree. But no one except Eligius is accepting more than 3 right?

Actually no! P2SH doesn't have an explicit limitations beyond the 520byte P2SH redeemScript limit, and more importantly the 500-byte scriptSig limit for IsStandard() transactions, so n and m just need to fit within that. Try it!

waxwing

sr. member

Activity: 469

Merit: 253

Quote from: Peter Todd on March 07, 2014, 10:07:30 AM

Quote from: waxwing on March 07, 2014, 09:46:09 AM

Thanks. I realised after I wrote that that Shamir shares *secrets* not signatures so that's no good (I guess the clue was in the title

). Could something be hacked together with CoinSwap?

I don't think so.

The threshold sig stuff sounds pretty far along; for now 15/20 isn't such a bad limitation IMO.

I agree. But no one except Eligius is accepting more than 3 right?

Peter Todd

legendary

Activity: 1120

Merit: 1152

Quote from: waxwing on March 07, 2014, 09:46:09 AM

Thanks. I realised after I wrote that that Shamir shares *secrets* not signatures so that's no good (I guess the clue was in the title

). Could something be hacked together with CoinSwap?

I don't think so.

The threshold sig stuff sounds pretty far along; for now 15/20 isn't such a bad limitation IMO.

Topic: [coinb.in] Open Source, Multi Signature, HD Wallet, SegWit/Bech32 and more! - page 16. (Read 74837 times)