Alright I try to explain it again.
Mooncoin_Foundation gave the
3 Addresses:
- 3 Adresses are blocked via consensus
2QovBjnVke4fgn9UXdz9osheNLxQCk3d8R (the 1st one with 62B)
2DMfpxPiMtpVDVyrxQAAmfBbZnDH4XCMfK (Dec, 2014 thefts)
2JA3Cqf9on8YuxngxdXStCFKanAGnaQU5A (Dec, 2014 thefts)
I relayed these
3 Addresses to Peter.
Peter used the
same technique to block these coins as
already done in 0.13.9 Who did implement these protection in first place? ->
Barry ( 0.13.9 codebase )How does this protection work?
Barry did implement it that way that it blocks
all UTXOs that were sent to these addresses, so all TX'es that had a destination to those 3 addresses are blocked.
So what got changed in 0.18.1?
Same as in
0.13.9 - All Tx'es towards these addresses got blocked, but now on the
consensus level instead of the
mempool level. These
completely ensures that the coins can't be spent. ( On 0.13.9 you could mine your own blocks and include these transactions )
So to sum it up. - This
exact protection was in place
since the 0.13.9 release as said
( @Michi your 23f1ade1a9 is in the list on 0.13.9 of blocked transactions )Here are the 2 links again to the Github of 0.13.9 and 0.18.1
Protection in 0.13.9
https://github.com/MooncoinCommunity/wallet/blob/0.13.9.1-segwit/src/main.cpp#L1160Protection in 0.18.1
https://github.com/MooncoinCommunity/wallet/blob/0.18/src/validation.cpp#L573Now to the "insecure wallet problem"
Mebagger is partly right on that one, 0.18.1 should add the
historical validation I
completely agree with that. But it couldnt have been done on the initial release, otherwise it would have rejected 0.13.9 instantly which shouldnt be done that way.
0.17 has the historical validation in place which works and was a good job of the 0.17 team, it just should have done ( in my opinion ) after the 0.18.1 set height to set validation in place. But as said, should be added to 0.18.1 whatever that version will be called then, lets call it 0.18.5.
So what would need to be done right now is porting the 0.17 historical validation to 0.18.1 and make 0.18.5.
About the "forbidden tx" protection, thats up to the community how you guys want to handle that. 0.18.1 - As its part of the consensus right now, if you guys decide to lift that protection, pools and exchanges would need to update on the 0.18.5 release, but again thats up to you.
I've talked to Peter and the best would be to modify the "forbidden tx" protection that it only blocks specific UTXOs ( But that would be a new system, not the one that got introduced in 0.13.9 which blocks all UTXOs )
So that issue should have been brought up way earlier, but seems like nobody looked into it until now, as that "issue" persisted for over 2 years ( since 0.13.9 ) release.
Happy to help/assist on the 0.18.5 or to clarify any other questions that come up.
Kind regard,
ChekaZ