Moving forward with Armory - page 8.

coins101

legendary

Activity: 1456

Merit: 1000

Quote from: goatpig on February 04, 2016, 12:58:47 PM

Quote from: coins101 on February 04, 2016, 04:07:47 AM

Happy to take a look at the IP issue and give you some informal feedback / personal view.

Thanks for the help =). This is my current situation:

I'm mostly concerned about how to properly deal with license headers and wording on the repo, to make it clear the new code is MIT and mine and the old code is GPL3 and ATI's.

This is the original license: https://github.com/etotheipi/BitcoinArmory/blob/master/LICENSE

This is the modified one on my fork: https://github.com/goatpig/BitcoinArmory/blob/dev/LICENSE

Is this acceptable?

Also, this is what the license header looks like on the original code: https://github.com/etotheipi/BitcoinArmory/blob/master/cppForSwig/BlockUtils.cpp#L1

I have modified some of that code already by did not modify the license text on any of the original code files.

This is the header on all new code files: https://github.com/goatpig/BitcoinArmory/blob/dev/cppForSwig/BlockDataMap.cpp#L1

Those files are 90~95% new code, I've copied some of the original utility code into the new class.

Did I mess up anything?
....

First, I'm not a lawyer. But, unfortunately, I have spent many years in dark rooms with lawyers talking about IP on software.

I think what you have done looks ok. I've read through the Armory GNU licence and basically you need to add this to the source code that was created by Armory:

Code:


    Copyright (C)   

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU Affero General Public License as
    published by the Free Software Foundation, either version 3 of the
    License, or (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU Affero General Public License for more details.

    You should have received a copy of the GNU Affero General Public License
    along with this program.  If not, see .

http://www.gnu.org/licenses/agpl-3.0.en.html

So, you'll have a mixture of code licences that you might want people to compile according to where the code starts:

* Armory code should start with the Armory licence terms

Code:

Copyright (C) 2011-2015, Armory Technologies, Inc.                        //
//  Distributed under the GNU Affero General Public License (AGPL v3)         //
//  See LICENSE or http://www.gnu.org/licenses/agpl.html 

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU Affero General Public License as
    published by the Free Software Foundation, either version 3 of the
    License, or (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU Affero General Public License for more details.

    You should have received a copy of the GNU Affero General Public License
    along with this program.  If not, see .

* Your new code can then start with:

Code:

//   Copyright (C) 2016,           //
//  Distributed under the MIT License                           //
//  See LICENCE or https://opensource.org/licenses/MIT //

I take it there is no other code you'll be using that has come form Armory, that has not been released on the GNU licence?

By using the Armory code now, you should be ok if someone decides to buy the company or its assets and then changes the licence.

I'll keep reading around to see if the above thoughts need modification.

Acejam

full member

Activity: 124

Merit: 251

This is unfortunate - Armory is one of the best wallets out there in my experience.

Not sure if this helps, but if anyone is looking for inspiration: https://github.com/acejam/BitcoinArmory/tree/ffreeze

goatpig

legendary

Activity: 3766

Merit: 1364

Armory Developer

Quote from: coins101 on February 04, 2016, 04:07:47 AM

Happy to take a look at the IP issue and give you some informal feedback / personal view.

Thanks for the help =). This is my current situation:

I'm mostly concerned about how to properly deal with license headers and wording on the repo, to make it clear the new code is MIT and mine and the old code is GPL3 and ATI's.

This is the original license: https://github.com/etotheipi/BitcoinArmory/blob/master/LICENSE

This is the modified one on my fork: https://github.com/goatpig/BitcoinArmory/blob/dev/LICENSE

Is this acceptable?

Also, this is what the license header looks like on the original code: https://github.com/etotheipi/BitcoinArmory/blob/master/cppForSwig/BlockUtils.cpp#L1

I have modified some of that code already by did not modify the license text on any of the original code files.

This is the header on all new code files: https://github.com/goatpig/BitcoinArmory/blob/dev/cppForSwig/BlockDataMap.cpp#L1

Those files are 90~95% new code, I've copied some of the original utility code into the new class.

Did I mess up anything?

Quote from: STRML on February 04, 2016, 10:33:13 AM

We at BitMEX would be happy to help with resources and hosting. Please email us at support at bitmex dot com if you would like any help. We have plenty of extra capacity.

As for releases and documentation I heartily recommend doing releases on GitHub itself, and creating a gh-pages branch of the repository (or another repo) for docs/public website. That way we all benefit from open development of the docs site. I find in practice that if the repo is discoverable (e.g. there should be links to the GitHub page all over it), the community will submit PRs regularly. This makes keeping documentation helpful and up to date far easier.

Very sorry to hear how 0.94 went. As a team we're happy to help any way we can. Thank you for taking the lead on getting the work started to create a libre 0.94.

That's a kind offer and I appreciate it. While this is an important matter, I'd like to get back to it once I actually have code ready for a release. I will have an easier time doing things properly once I have a new version ready.

I am open to suggestions on this matter, although I think the GitHub release is a seller.

The gh-pages approach sounds really good too. I'll try to figure something out, I'm looking forward to the community submitting PRs.

STRML

newbie

Activity: 17

Merit: 0

Quote from: goatpig on February 04, 2016, 12:51:52 AM

Quote from: achow101 on February 03, 2016, 11:23:05 PM

Just a thought:

Couldn't you just host the releases on Github using the release function? Just tag the releases and then upload the corresponding binaries for that release and tell people to download the binaries from there.

Also, github pages could be utilized to set up a website for the open source project. A project site could be set up using github pages and it would all be hosted by github for free. In announcements text file could be kept there and armory could pull the announcement from there.

If we go with that option, I could help as I have experience with setting up all of that stuff for github, although when it comes to web design and development you will need to get other people to help. Thankfully the github pages thing actually makes making a website there really easy.

That's a good suggestion. I like keeping the releases on github directly, makes my life easier (and everybody else's I suppose?). For the website I have to think about it. Apparently I could get access to armory.org through a friend and ex-Armory employee. It's a valid option to consider.

We at BitMEX would be happy to help with resources and hosting. Please email us at support at bitmex dot com if you would like any help. We have plenty of extra capacity.

As for releases and documentation I heartily recommend doing releases on GitHub itself, and creating a gh-pages branch of the repository (or another repo) for docs/public website. That way we all benefit from open development of the docs site. I find in practice that if the repo is discoverable (e.g. there should be links to the GitHub page all over it), the community will submit PRs regularly. This makes keeping documentation helpful and up to date far easier.

Very sorry to hear how 0.94 went. As a team we're happy to help any way we can. Thank you for taking the lead on getting the work started to create a libre 0.94.

coins101

legendary

Activity: 1456

Merit: 1000

Happy to take a look at the IP issue and give you some informal feedback / personal view.

btcsql

sr. member

Activity: 292

Merit: 250

Thank you for your continued work on this, goatpig. I'd be happy to pledge some support in the future when the time arises.

goatpig

legendary

Activity: 3766

Merit: 1364

Armory Developer

Quote from: achow101 on February 03, 2016, 11:23:05 PM

Just a thought:

Couldn't you just host the releases on Github using the release function? Just tag the releases and then upload the corresponding binaries for that release and tell people to download the binaries from there.

Also, github pages could be utilized to set up a website for the open source project. A project site could be set up using github pages and it would all be hosted by github for free. In announcements text file could be kept there and armory could pull the announcement from there.

If we go with that option, I could help as I have experience with setting up all of that stuff for github, although when it comes to web design and development you will need to get other people to help. Thankfully the github pages thing actually makes making a website there really easy.

That's a good suggestion. I like keeping the releases on github directly, makes my life easier (and everybody else's I suppose?). For the website I have to think about it. Apparently I could get access to armory.org through a friend and ex-Armory employee. It's a valid option to consider.

sandal

newbie

Activity: 20

Merit: 0

Looking forward to the next iteration! Thanks for continuing to support!!

tss

hero member

Activity: 742

Merit: 500

thank you for making an effort to maintain armory in open source.. it is a great product. so sad that the company was not able to monetize the project to cover expenses. i wish you luck in all the updates coming forward and would def send a few satoshi for donation to continue development.

achow101

staff

Activity: 3458

Merit: 6793

Just writing some code

Just a thought:

Couldn't you just host the releases on Github using the release function? Just tag the releases and then upload the corresponding binaries for that release and tell people to download the binaries from there.

Also, github pages could be utilized to set up a website for the open source project. A project site could be set up using github pages and it would all be hosted by github for free. In announcements text file could be kept there and armory could pull the announcement from there.

If we go with that option, I could help as I have experience with setting up all of that stuff for github, although when it comes to web design and development you will need to get other people to help. Thankfully the github pages thing actually makes making a website there really easy.

Blazed

legendary

Activity: 2128

Merit: 1119

Quote from: solitude on February 03, 2016, 09:05:28 PM

Quote from: achow101 on February 03, 2016, 09:00:14 PM

Quote from: solitude on February 03, 2016, 08:56:05 PM

Does this mean Armory is on life support and will meet its demise within a year or so?

No, goatpig will continue development and the project will remain open source so people can still contribute and keep armory alive.

Quote from: solitude on February 03, 2016, 08:56:05 PM

What does this mean for people with a fair number of bitcoins held in Armory? Should we look for a new client for our bitcoins?

Nothing will happen. Your Bitcoin will be safe, you just won't get updated wallets if Armory does stop being developed. When new features come out, it would be a good idea to get a new client of course.

So let's say I go to prison for ten years, and Armory had stopped being developed one year into my prison sentence.

Would I be able to get out of prison nine years after Armory had stopped being developed, find my paper wallet, and get access to my bitcoins?

I am sure finding a version would be easy even if it can not send coins. Once you imported the wallets just dump the keys and import into something else. I have a feeling that Armory will continue on for a while. I hope when he asks for dev funds people help out.

achow101

staff

Activity: 3458

Merit: 6793

Just writing some code

Quote from: solitude on February 03, 2016, 09:05:28 PM

Quote from: achow101 on February 03, 2016, 09:00:14 PM

Quote from: solitude on February 03, 2016, 08:56:05 PM

Does this mean Armory is on life support and will meet its demise within a year or so?

No, goatpig will continue development and the project will remain open source so people can still contribute and keep armory alive.

Quote from: solitude on February 03, 2016, 08:56:05 PM

What does this mean for people with a fair number of bitcoins held in Armory? Should we look for a new client for our bitcoins?

Nothing will happen. Your Bitcoin will be safe, you just won't get updated wallets if Armory does stop being developed. When new features come out, it would be a good idea to get a new client of course.

So let's say I go to prison for ten years, and Armory had stopped being developed one year into my prison sentence.

Would I be able to get out of prison nine years after Armory had stopped being developed, find my paper wallet, and get access to my bitcoins?

If you could find a working install of armory, yes. Hopefully there will be further development to make it compatible with other wallets and current standards, in which case, you would not need to have armory at all and the paper wallet would still be compatible with other wallets.

solitude

hero member

Activity: 674

Merit: 500

Quote from: achow101 on February 03, 2016, 09:00:14 PM

Quote from: solitude on February 03, 2016, 08:56:05 PM

Does this mean Armory is on life support and will meet its demise within a year or so?

No, goatpig will continue development and the project will remain open source so people can still contribute and keep armory alive.

Quote from: solitude on February 03, 2016, 08:56:05 PM

What does this mean for people with a fair number of bitcoins held in Armory? Should we look for a new client for our bitcoins?

Nothing will happen. Your Bitcoin will be safe, you just won't get updated wallets if Armory does stop being developed. When new features come out, it would be a good idea to get a new client of course.

So let's say I go to prison for ten years, and Armory had stopped being developed one year into my prison sentence.

Would I be able to get out of prison nine years after Armory had stopped being developed, find my paper wallet, and get access to my bitcoins?

achow101

staff

Activity: 3458

Merit: 6793

Just writing some code

Quote from: solitude on February 03, 2016, 08:56:05 PM

Does this mean Armory is on life support and will meet its demise within a year or so?

No, goatpig will continue development and the project will remain open source so people can still contribute and keep armory alive.

Quote from: solitude on February 03, 2016, 08:56:05 PM

What does this mean for people with a fair number of bitcoins held in Armory? Should we look for a new client for our bitcoins?

Nothing will happen. Your Bitcoin will be safe, you just won't get updated wallets if Armory does stop being developed. When new features come out, it would be a good idea to get a new client of course.

solitude

hero member

Activity: 674

Merit: 500

Does this mean Armory is on life support and will meet its demise within a year or so?

What does this mean for people with a fair number of bitcoins held in Armory? Should we look for a new client for our bitcoins?

droark

sr. member

Activity: 525

Merit: 282

Quote from: goatpig on February 03, 2016, 08:19:47 PM

Quote from: Ente on February 03, 2016, 08:10:44 PM

One detail question: as I understand it, there was a 0.94 branch on github, which was removed again. Isn't all the code which was published automatically under GPL as well? What's the difference between .93 and .94?

I am not versed in IP law so I can't give you a reason why. The only thing I have been told and that I know is that anything but 0.93.3 as it stands in Alan's public repo is off limit. This whole endeavor has made me a bit paranoid with IP tainting. I would rather be safe than sorry, and I won't try to go for more than what is perceived as a perfectly safe state to start from.

One thing I'd like to know - and I doubt Farhod knows, for understandable reasons - is if this includes failed pull requests. As I mentioned over on Reddit, there's some Autotools/Gitian code that would be great to add. It was aimed at 0.94 but never officially made it into the repo. Does that mean it's safe? I'd like to think so, as starting from scratch would suck. IANAL, unfortunately.

goatpig

legendary

Activity: 3766

Merit: 1364

Armory Developer

Quote from: Ente on February 03, 2016, 08:10:44 PM

One detail question: as I understand it, there was a 0.94 branch on github, which was removed again. Isn't all the code which was published automatically under GPL as well? What's the difference between .93 and .94?

I am not versed in IP law so I can't give you a reason why. The only thing I have been told and that I know is that anything but 0.93.3 as it stands in Alan's public repo is off limit. This whole endeavor has made me a bit paranoid with IP tainting. I would rather be safe than sorry, and I won't try to go for more than what is perceived as a perfectly safe state to start from.

Quote

Try to delegate things, ask us, the community, for what we might help you with.

On that front, if anyone has advice on how to properly deal with code licensing (I'm adding MIT code a GPL3 codebase), particularly in how to do it without making a mess, I'm all ears.

Ente

legendary

Activity: 2126

Merit: 1001

This isn't the news I hoped for, but at least the situation is clear now.
Alan, you are an inspiration, even for non-developing folks. One of the few good guys I trust. Thank you for all you did, and please stick around Bitcoin for your next endeavour! :-)
Goatpig, I am super happy to have you here, the lone hippie of the bunch. Please don't rush things, but have enough pleasant non-computer time as well. Try to delegate things, ask us, the community, for what we might help you with.

I like the idea of a crowdfunded interactive featurewishlist. Nothing wrong with starting that earlier than later, it's been some time that you actually received financial compensation, eh?

One detail question: as I understand it, there was a 0.94 branch on github, which was removed again. Isn't all the code which was published automatically under GPL as well? What's the difference between .93 and .94?

Oh well, Rough times, but Armory simply is without alternatives. Let's do this!

Ente

PRab

member

Activity: 98

Merit: 10

I'm sorry to hear that Alan will no longer be working on Armory. Goatpig, I'm glad that you will be continuing the work. Armory has been my go-to wallet for many years. I appreciate all the hard work that you both put in.

Blazed

legendary

Activity: 2128

Merit: 1119

I have used only Armory for years now and will defenetly contribute once you ask for some funds. Thanks for all of the hard work and making by far the most secure/best software wallet around.

Topic: Moving forward with Armory - page 8. (Read 18563 times)