worth looking into to see if we are at risk Infernoman? https://bitcointalksearch.org/topic/m.13168415
Looking At their most recent commits it looks like they didnt have any drift time setup for the accepted transactions in the mempool. so they were susceptible to a time warp mempool exhaustion attack. Tracking this down a bit through our own code. We do already have checks in place for futuredrift. In novacoins commit they start doing a check for the future drift inside of CheckTransaction. Ours is a bit further down, although not much.
Where their check happens in CheckTransaction
https://github.com/novacoin-project/novacoin/blob/47bb141bf2d589db630ac1a917189b05b75b80d0/src/main.cpp#L626
and adds a check for IsFutureDrift()
https://github.com/novacoin-project/novacoin/blob/47bb141bf2d589db630ac1a917189b05b75b80d0/src/main.cpp#L514-L517
Ours gets checked in IsStandardTx instead of CheckTransaction.
https://github.com/Infernoman/Transfercoin/blob/master/src/main.cpp#L679
and already has a check for IsFutureDrift
https://github.com/Infernoman/Transfercoin/blob/master/src/main.cpp#L319-L323
Even though the placement difers slightly the transaction will get denied before accepted into the memorypool. And keep us safe from the exhaustion attack. Novacoin unfortunately didn't have the check in place.
Thank you for bringing this up ozboy2014 It's definitely great to see the community getting active and bringing in ideas and fixes from other coins too ! If you guys notice something on blackcoin, dash, novacoin, or others that are similar. Let me know and I'll definitely look into it ASAP.
Thanks Infernoman. Great to know that we are already on top of this. Cheers.
