Topic: 300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread) - page 17. (Read 129207 times)

Similar to last time, nearly everybody tries to get out of the evaluation phase, saying they trust me to be fair. Unfortunately, this is not an option, unless you want to withdraw from the contest. It's an important part of the process, painful though it is.

I've received complete evaluations from a few of you, but I'm still waiting on quite a few. I'm not letting anybody opt out of the evaluation phase - sorry!

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Grazcoin's address for 300 BTC bounty part 1 is:
1BgGDZTvD2P6wU9emZtkAY3v13qrX8FiHY
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAEBAgAGBQJS4jI4AAoJELKaUoFCopv54rQH/AgMt5sWntWQtGr+AKthdrOf
0mSwqiDW6Zb/F3suhJx7oQDr3nXfA2uk+c0K9Gx/MAEX8DNa/Z/JqQOEdrYHC41+
xaiB7bEsaf83nTn2JQHBv+ycuhl+ePqSkrr6oFBKv+Vt+yUFh0awBgqWafOZ0jqA
3mJMG+4qXArVP260Q8gtcMm3RN4t8wy++vSZhxw1qAssyyti60ub042CaaR/nHfx
EPCB1r35aChOw5wlFcUWsdTXFVvTySxueFxDORFn0gAOkbO/sy+nqHlkB/bZ7Acu
U56YIPe4tJ1q31YqATJj19yhegjlOVCmo9A9qFdJekag9MnP9qkkSgKH3GzNid4=
=jcu/
-----END PGP SIGNATURE-----

New features on https://masterchain.info

• Offline signing
  
  • Visit https://masterchain.info/offlinesign.html
  • Save Page As ... to an offline location
  • Copy & paste the required fields from an online computer to the offline one
  • Sign offline
  • Copy & paste to online blockchain.info/pushtx
• Orderbook
  
  • https://masterchain.info/index.html?currency=TMSC&filter=sell
• Last deals
  
  • https://masterchain.info/index.html?currency=TMSC&filter=accept
• Human readable errors
  
  • e.g. Not enough bitcoin funds on address

Nice idea Roman.

I've done a few hours work over the last few days but didn't submit it as I don't feel I deserve anything from this round compared to what other people have done. I hope to qualify for the next round though!

Thank you Roman for opening a testing thread https://bitcointalksearch.org/topic/official-masterchaininfo-testing-thread-428798 for https://masterchain.info

For easier testing, the following features were added:

• https://masterchain.info/index.html?currency=TMSC&filter=sell (linked from orderbook)
• https://masterchain.info/index.html?currency=TMSC&filter=accept (for testers use)

And as for your request, errors of Prepare (both for send and accept pages) are shown next to prepare button.
This way you could easily report them.
The general ERROR message will still appear if something really funny happened, and then I'll check my logs ...

Thanks for the reports guys. It looks like we have reports from the following people (in order received):

For the dev pot:

Zathras https://bitcointalksearch.org/topic/m.4657707
Bitoy https://bitcointalksearch.org/topic/m.4659090
Grazcoin https://bitcointalksearch.org/topic/m.4663395
Grimentz https://bitcointalksearch.org/topic/m.4664542
cmlacy https://bitcointalksearch.org/topic/m.4667601
Tachikoma https://bitcointalksearch.org/topic/m.4668290
Marvschneider https://bitcointalksearch.org/topic/m.4668412
azmenthe https://bitcointalksearch.org/topic/m.4670303
fthoughts https://bitcointalksearch.org/topic/m.4678460


For the testing pot:

Zathras https://bitcointalksearch.org/topic/m.4657707
Bitoy https://bitcointalksearch.org/topic/m.4659090
Grazcoin https://bitcointalksearch.org/topic/m.4663395
Grimentz https://bitcointalksearch.org/topic/m.4664542
Jakecnn https://bitcointalksearch.org/topic/m.4664847
Tachikoma https://bitcointalksearch.org/topic/m.4668290
Marvschneider https://bitcointalksearch.org/topic/m.4668412
Bebopzzz https://bitcointalksearch.org/topic/m.4668580
azmenthe https://bitcointalksearch.org/topic/m.4670303
Atriz https://bitcointalksearch.org/topic/m.4674956
Mastream https://bitcointalksearch.org/topic/m.4678403

(fthoughts you don't qualify for this payout, but I hope you will participate big time in the second half and win some BTC). Sorry fthoughts. I thought you were just some random newb trying to look like you were involved. Curtis just informed me that you are an integral part of the team joining us from engine.co - my apologies!

If your name is listed in either pot above, I need a payment address for you in BTC, AND an address to pay you dev MSC (PLEASE don't destroy your MSC by using a web wallet like Coinbase or MtGox) AND I need your opinion on how the money should be split up in both pots (note that I do not weight all opinions equally, but every opinion matters). Please leave yourself out of the distribution, as if you were not participating. Only think in terms of percentages, and the contributions of each person relative to the rest. Please send your opinion via PM or email (don't post it here!)

Once I have received Addresses and opinions from at least the biggest contributors (but hopefully all of you), I can plug them in to a big spreadsheet, announce the final distribution, and start payouts. I apologize if I am slow on any of this, as I need to finish strong here at Cozi so I am very busy right now.

Thanks everyone.

In mymastercoins when a sell offer is cancelled it will be removed from the sell offer listing.  I'll probably add a view previous sell offer so that it  can be verify as cancelled.

Good point. Based on white paper it should be a valid sell order for 364.84328263 tmsc. I'll update mymastercoins.

To the admins of mastercoin-explorer.com, masterchest.info, masterchain.info and mymastercoins.com:

Please take a look at transaction:

https://blockchain.info/tx/e1633c9e0515cb027a6f2736bec02f0de8753e6b7c3303597ac01582de2d7041

It was rendered as invalid due to insufficient balance. To quote the spec:


How do you plan to handle such things in the future?

Balance of 15og4WXZPwkMnnsb3dj6HqgTUfcRLx4J9b: 364.84328263 TMSC, tried to send: 9999.0 TMSC to 1xC6gPa4QTM18cPKKPutcEkfmZvabY38j.

I think Curtis and Patrick have said it better but we're working on a limited/zero trust web wallet for Mastercoin users. Right now we have client-side encryption, storage, and signing soon to come, and aside from that I think Grazcoin and Grimentz have done great work on their implementation and have been really helpful in getting us up to speed (we're using their fork). The UI will be developed in parallel of Marv Schnieder and Yuval's feedback as well to maximize the user experience of using Mastercoin.

It is still in progress but as this is a bounty on reported progress I think it might be good just to inform others of where we stand.

alright, after purchasing some TMSC on the DEx yesterday, I tried creating then canceling (by posting a new offer with amount 0) a sell offer with the address 1B4dzdSTt8p1qfMba4MTPUvABDXDYTHT2S



The result is as follows:
On masterchain the amount of TMSC shown is correct. I see only the first offer, not the cancellation. I'm aware that they don't show up as canceled yet, but shouldn't I see both offers, or do you filter the ones with amount 0?

on mymastercoin I see only the (correct) TMSC balance

masterchest shows a TMSC balance of 0, although it shows the incoming transaction from yesterday's DEx buy. No sell offers are shown

mastercoin-explorer shows both the correct balance, as well as both sell offers


sell offer tx:
https://blockchain.info/tx/a116be62025ad134f6e071605a577d3e5fb2c8d8e7a86068a520383b1c00b3e3

sell offer cancel tx:
https://blockchain.info/tx/d063437a4735b3fdb1f6d44af745257b193ce1acffe32b80457d502c5bc65635

edit:
@dacoinminster I just started participating a bit, been lurking mostly, so what you see here is all I did, lol

Summary of Work (TESTING)

- Tested MyMastercoins thin client wallet MMW with Bitoy
- Went back and forth with Bitoy and assisted in debugging with the install of the wallet on windows (have multiple PM's with him if needed and posts throughout the thread)
- Tested with the MMW wallet:
Send TMSC, (simple send) Sell TMSC Distributed Exchange, Buy TMSC Distributed Exchange
- Testing on grazcoin's HybridWebWallet.
- Debugging with other dev's to find errors with the HybridWebWallet.
- All testing was used with my address:1LjT88X7Zu8BdbqJw8vfRa83NJuzYL9kqm


Congrats to all who have contributed to the project, this little bonus is well deserved (especially for the devs!)

I'd prefer that everyone err on the side of reporting as much information as possible. However, I will be relying pretty heavily on your mutual evaluation of each other, so as long as you are confident that the other devs know what you contributed, under-reporting will (hopefully) not hurt you

I think I mentioned last bounty that this is the stage where feelings get hurt very easily. Please try to keep that in mind, and recognize that EVERYONE will probably feel a bit cheated by the final numbers, since we all tend to over-inflate the value of our own contributions since that is what we know best.

I think I've seen reports from the owners of the four major existing implementations now. I'm sure there are a few more of you who qualify for some of this money. Please get your reports in today.

Thanks!

Faiz brought me on to help out with this web wallet (https://github.com/LDEngine/msc-webwallet/).

I contributed to early API design which was unfortunately abandoned.
I helped Faiz with the client side encryption/decryption of private keys using HTML5 local storage
I have been testing various new features and assisting with debugging/improvement
I have started a fork to move the web wallet to django for maintainability as opposed to python's basic HTTP server


Additionally to grok grazcoin's mastercoin-tools (https://github.com/grazcoin/mastercoin-tools) I forked it and have started to write unit tests.

If I am the cause for your steam - there was no intention to annoy you. If I did, than I am sorry. I just took literally J.R. words saying to collect the tasks from the forums.
I am sure the main developers do not need this summary anyway, as we all know what the others were working on.
Such a detailed summary is good for people who do not follow the forums to see the list of the subjects that were on the table during that period.

If someone wants to go over on all your posts, he can visit https://bitcointalksearch.org/user/tachikoma-13172 or the github.
We all know that you work very well and this does not decrease your chances for a high bounty.

Wish I did more testing but this is my what I did:

1)Had trouble with installing Bitoys mymastercoin wallet and briefed him on it

https://bitcointalksearch.org/topic/m.3804247

https://bitcointalksearch.org/topic/m.3807783

2)Tested out grazcoins masterchain.info and reported a UI problem I was encountering (pubkey or seller addres info)

https://bitcointalksearch.org/topic/m.4564730

3) Made a buy offer on DEX:

https://blockchain.info/tx/d91909f852786a2f82ef556118df65e37bc7432b5cc1ded3e9b730dafd409ab5

Testing:

• I published https://github.com/marv-engine/QA/blob/master/MastercoinDistributedExchangeTestPlan.md which describes the strategic approach for Dist-Ex testing (rigorous, comprehensive, repeatable, defensible). I'm looking for feedback.
• I'm working on test requirements for each transaction type - the next level of detail, then test procs can be written for each candidate application.
• I'm working with Dom (& Nikos soon) on promoting MSC testing. I'm already in touch with a few people who want to test. Need to hear from devs when they have something ready for testing.

MSC Spec:

• I submitted pull requests to improve & clarify updating/canceling a Sell Offer (tx=20). Wrestling this to closure.
• I've identified other transaction definitions that need to be clarified

Dev:

• I'm working with Curtis, Faiz, Yuval on UI/UX for the web wallet

Other:

• Suggested using smart properties for raffles, etc to Taariq & Dom. This could be used to generate interest in MSC from the user community at large - buy tickets with MSC, get MSC and/or MSC-derived tokens.

Hey guys,

First off; let me start by saying I'm a little annoyed with the fact that some people are writing down every post or comment on Github they ever did since the start of the bounty. The question was to summarise your work so it can easily be digested by the other participants. I am not going to open every link or read every comment you wrote somewhere on the forums and I highly doubt the value of these contributions. It almost seems like some of you want to inflate the amount of actual work done. I understand that me publicly saying this might decrease my own chances but I think it's only fair I speak my mind.

Also please note that none of the Simple Send consensus work was part of this Bounty, if I mention it it's purely informational.

I will outline everything I've done in very broad lines, there won't be any links to communication I had via pm/skype/hangouts or anything else.

Mastercoin Explorer

---

Screenshot

Main features Can parse, save and display Mastercoin DEx messages. Has a dedicated page to display distributed exchange data. Has a graph for latest selling prices based on DEx data. Can create Selling Offers by creating raw transactions that you can sign using your own Bitcoin wallet software. Not related to the bounty Top 50 wealthy addresses are shown There are now three types of charts: Weekly/Month/Yearly transaction graphs. Testing Mastercoin-explorer comes with a full rSpec based test suites that automatically tests various different outcomes for parsing Mastercoin transactions. Where Source on Github Installer script on Github

Mastercoin Wallet

---

Screenshot

Main features Can now display DEx order book. Supports all creation and broadcasting of all DEx related messages. Not related to the bounty There is an automatic installer script that can now install the client with one command on Debian/Ubuntu and Fedora/Redhat. Where Source on Github Live on mastercoin-explorer.com

Mastercoin Ruby

---

Mastercoin-ruby is the encode/decode lookup layer that can lookup transactions. Support for decoding/encoding of DEx messages is now supported in this library. This library also comes with accompanying rSpec suite.


Other

---

Mastercoin protocol updates

• Wrote a specification clarification for reserving funds for DEx messages.
• Wrote a few general clarifications for Selling/Purchase offers.
• Updated the spec to reflect we ignore Mastercoin transactions for purchases.
• Updated verification API to add support for DEx consensus

Not related to the bounty

• Updated the spec to clarify P&D
• Updated the spec to unlock features on block level
• Updated the spec with more information about the vesting of Dev MSC
• Organised a consensus hackathon
• Started working on the reference implementation in Go

Faiz and I have been working with extending the existing webwallet that grazcoin and Grimentz have posted on masterchain.info.  We've taken a crack at making a simple installer, and filled out installation instructions for the wallet, masterchain.info-style server, and obelisk server: https://github.com/LDEngine/msc-webwallet

The bulk of the Distributed Exchange specific stuff will come later - but I wanted to keep the project on people's radar.