- FIX - issue #42 estimated date is now based on 120s blocktime , this should provide a more accurate "Estimated Date" value.
I have one question to this change. Do you habe also done some changes to speed up the blocktime? We never reached nearly 120 seconds since coin is started because of MIDAS. So when the estimate date is now bases on 120 seconds, the shown date will not be the real date when deposit ends. I think this is not very transparent for the users.
When we take a look an 2018:
- 01.01.2018 9:01 block 33000
- 22.02.2018 8:58 block 63134
So we have 30134 blocks in 52 days. The real blocktime is therefore
149 seconds. In my opinion the old value of 154 seconds for the calculated estimate date was honestly. The new value of 120 seconds suggests a date which will never be come true, if you did not any changes to sped up the blocktime.
We did not change the speed of blocktime, you can see for yourself
https://github.com/ROIcoin/ROIcoin/blob/master/src/chainparams.cpp consensus.nPowTargetSpacing = 120; // 2 minutes
TheTDD correctly pointed out that we were using old hodlcoin value of 154s for the calculation of an "Estimated maturation date" see here
https://github.com/ROIcoin/ROIcoin/issues/42The goal is still to achieve 120s, i know currently the average is 140s , this depends on multiple factors one of which is the large variability in global hash rate, someone out there is constantly adding then removing large hash rates.
To summarize the actual algorithm and consensus PowTargetSpacing time was not modified !
