Thank you for the thorough review! I'll take a look at addressing the issues when I get the chance. (Might be a day or so.)
Update: I've made some quick fixes for the two issues identified as blockers. I've added test cases for both, and they're both pushed to the repo:
https://github.com/PeterBorah/ethereum-powerballThat might be enough to fulfill the conditions of the bounty. However, as a matter of professional pride, I want to spend a little more time working on the quality of the code. The sorts of bugs found reveal what the weak spots are, and I have some ideas for making it more robust.* So, I'm going to try to work on that over the next couple evenings.
* For the programmers in the audience: I've basically got an implicit state machine with some pretty complex effects. I want to model it more directly so that it's easier to reason about and harder to end up in weird partial states. I'm also not dealing with storing data in a very principled way, so I want to think about encapsulating some of that.
Can you reply to this post with your XCP/BTC address.
Then I will send the link to the people who pledged to support your coding of this smart contract.
Me - 50 XCP
Matt Y - 20 XCP
Ivana - 10 XCP
Niceplum -
10 XCP 5 XCP (edit sorry i made a mistake too many numbers )Tyhmakulho - 10 XCP
Ian - 10 XCP
Dante - not sure, expressed interest
Tusk - 2 XCP
Jonathan O - 3 XCP
Grand total:
115 XCP 110 XCP (EDIT) or about $600 equivalent at today's rates.
I am going to ask them all to send it directly to you as I don't want to be the middleman. Anyone sending please post here to confirm (if you have a bitcointalk account, some people may not).
Also, as I didn't explicit a reward for the code review, if you would not mind perhaps sharing a % of it to the person who did the code review. https://gist.github.com/jorisbontje/353f69515a16cef7de7b I will ask him to put his XCP/BTC address in the git repo.
I have not had time yet to get this running on the testnet to try it out but will spend some time this week to learn how to do that (haven't run counterpartyd since Feb so that will be interesting...), and then am also asking some people around who know people in the gaming space to see if we could perhaps demo this capability for them and get them interested in using XCP and Ethereum for their business.
Thanks!