Author

Topic: OFFICIAL CGMINER mining software thread for linux/win/osx/mips/arm/r-pi 4.11.0 - page 522. (Read 5805546 times)

-ck
legendary
Activity: 4088
Merit: 1631
Ruu \o/
That shut someone up.
Alas I don't believe that for a second  Undecided
legendary
Activity: 1795
Merit: 1208
This is not OK.
legendary
Activity: 4592
Merit: 1851
Linux since 1997 RedHat 4
The crash in libcurl was tracked down with the help of Kano. Interestingly this bug was always there but because previous versions queued so much extra, the number of "curls" in existence never dropped low enough to hit the bug.
Of course, despite being credited to Kano, this was debugged by me, and actually originally fixed in BFGMiner 2.6.3:
Code:
commit 1946c806922a66935856c32b6ca12d10db033b07
Author: Luke Dashjr
Date:   Sun Aug 5 22:50:24 2012 +0000

    Bugfix: Check list_empty in pop_curl_entry after condition wait
    
    pthread_cond_signal wakes AT LEAST one thread, so it's possible the freed up curl has already been taken
lulz - it was the one you copied:
https://github.com/ckolivas/cgminer/commit/c7bcad653b79ee54429aec4964f4aa80e49db1d1
to here:
https://github.com/luke-jr/bfgminer/commit/c7bcad653b79ee54429aec4964f4aa80e49db1d1
(see the same commit numbers ...)
Is this the first time you expressed your absolute ignorance of how git works in public?
...
Hmm, when was the last one ... oh yeah I remember ... about 2 weeks ago ...
"I'm not a git export" ... Cheesy
https://bitcointalksearch.org/topic/m.1055547
That was sarcasm, since you very well knew you were stealing credit for this fix. Or are you going to claim it's just coincidence that you found it and fixed it a few days after BFGMiner, and did so in practically the same way? Just like you "found and fixed" the JSON string encode error that you just submitted a fix to CGMiner for under your own name only hours after I wrote a nearly identical fix for BFGMiner and mentioned it on the forum?
Seriously, get a life and get out of this thread.
Go pretend you are god in your own thread, you are not welcome here and you have alrady been warned by a mod about posting this sort of shit here over and over again.

If anyone is interested ... how I helped find the curl bug:
(and debunk the douche's FUD)

I was helping someone with a double MiniRig and they had it exiting without any reason - so we switched versions and that solved it
(wasn't sure why it was exiting)

Earlier that night I created my 2.6.3a download and had been running that
That night cgminer crashed ONLY on my Icarus rig (at exactly 2012-08-05 14:51:31 UTC - or 6-Aug 00:51:31 my time)
I run 3 instances of cgminer: a) 1x6950 b) 1xBFL c) 2xIcarus
Why did it crash?
I had no idea, it just seg faulted after almost 5.5 hours running 2.6.3a (and I didn't have ulimit set so no core dump)
The other two were still OK

I then turned on ulimit and restarted it so as to get a core dump if it happened again
Got a seg fault again about 10 hours later, went into gdb and a total WTF - it had cashed in curl_easy_setopt()
but since I hadn't compiled it with -g I couldn't tell the code line
My timezone is UTC+10
Code:
11:22 <@kanoi> woot!
11:22 <@kanoi> yes! got a crash and a core dump on my ica
11:23 <@conman> oho
...
11:30 <@kanoi> #1  0x00000034ffa29b71 in curl_easy_setopt () from /lib64/libcurl.so.4
11:30 <@kanoi> #2  0x0000000000413285 in json_rpc_call ()
11:30 <@kanoi> nfi which
11:31 <@kanoi> OK -g always now
...
11:38 <@kanoi> OK running -g this time - give it another 12-24 hours :)

This next one I called 2.6.3c Smiley

Code:
11:59 <@kanoi> WOOT -g core dump :)
12:01 <@kanoi> it's actually curl_easy_reset(curl);
12:01 <@kanoi> (err_out:)
12:05 <@kanoi> conman http://pastebin.com/YRLBNaJh - I'll add debug code myself but realised I've eaten nothign yet today - so after that :)

much later:

23:22 <@kanoi> #2  0x00000000004111d6 in json_rpc_call (curl=0x4,
23:22 <@kanoi> that says it
23:22 <@kanoi> now to find out why
(the WOOT was coz it happened so soon afterwards)

I changed all the curl DEBUG to ERR so they would always show and added a 5s sleep before the crash line to ensure the logs would clear before it crashed

That night I also setup 3 LTC CPU miners to see if that would help track down the bug running 6 cgminers instead of only 3
... no point CPU mining BTC so I setup LTC so that it could possibly actually find something Smiley

I didn't spot the obvious straight away (until much later)
#1  0x0000000000418b13 in json_rpc_call (curl=0x0,
i.e. curl was NULL in that pastebin one and 0x4 (even worse Tongue) in later crashes

Next morning after spending some time looking at the code, but about to be busy with work, I posted a pull request that I hadn't tested and had no idea if it was correct and was there just for ckolivas (conman) to see (he wasn't around IRC at the time) and consider if that might be the issue
https://github.com/ckolivas/cgminer/pull/289

Code:
10:08 < conman> boo
10:08 <@kanoi> untested - been busy
10:09 <@kanoi> but I think that's it
10:09 < conman> hey kanoi any progress on crash dump?
10:09 <@kanoi> pull request
10:09 <@kanoi> all comments then were to you :)
10:09 <@kanoi> (working at the moment - but someone is on the phone so I had a sec :)
10:12 <@kanoi> bbl
10:16 < conman> uh
10:18 < conman> that's wrong =(
10:33 <@kanoi> ok delete it then - it was a guess

Anyway, with help from all the info and crash dumps I had found, and one later commit that didn't fix it and had to be rolled back, ckolivas found the bug and fixed it with a small change:
https://github.com/ckolivas/cgminer/commit/c7bcad653b79ee54429aec4964f4aa80e49db1d1

The original cause of only my Icarus crashing was that Icarus gets work faster than any other device due to the fact that it requires work as soon as it finds a share, it doesn't complete the nonce range.

I had NFI originally why it happened and traced it to curl directly via core dumps - nothing to do with Jesus Troll at all.

----------------------

Now for the JSON change Smiley

I saw his post in his Abortion Miner thread that said he was going to have a fix in his next release, and realised of course that would be an issue for things like the pool passwords and the api description, so I went a wrote and tested a change and put up a pull request.
About 6 hours later, Jesus Troll posts a stupid comment on my pull request:
https://github.com/ckolivas/cgminer/pull/292

Code:
If you are going to copy my bugfixes, I request that you properly attribute in the git log;
in most cases, you can even create pullrequests directly:
https://github.com/luke-jr/cgminer/pull/new/bugfix_cfgwrite_json

If you want to write the fixes before I get to them,
feel free to go over the issue list: https://github.com/luke-jr/bfgminer/issues

Reading that comment, I then went and looked as his code and made the comment I made there in my pull request.

My code is actually very different so as to ensure it's easy to pass ALL strings through the escape function, and thus in my case, since I am escaping every string, I didn't miss the one that also obviously matters: pool password

That config save function is not in any way time critical, so I wrote a function that was simple to use and used it on all strings.

But making it a simple code change as I did (rather than a mess of 2 extra lines of code each time that I later saw Jesus Troll did) means that I've applied it to all strings no matter what, and anyone who adds new strings in there in the future, can do it just as easily
i.e. that was the reasoning behind my reply in the pull request
Code:
... and looking at your pull - yes I can see you messed it up :P
420
hero member
Activity: 756
Merit: 500
I'm convinced that setting CGMINER.exe priority to Realtime DOES significantly improve Mhash/s (on windows 7 64-Bit at least)
To do that, after opening, open taskmgr as ADMINISTRATOR right click the process and Set Priority->Realtime
Is realtime the highest priority in Windows? I set mine to high priority in Ubuntu (niceness value of -5), but I haven't noticed much of a difference.

yes, it is the highest. without running taskmgr as administrator it only lets the priority to be set to high

Does anyone know if BIOS flashing to the overclock settings of 5000 series gets better or more stable hashrate?
hero member
Activity: 591
Merit: 500
I'm convinced that setting CGMINER.exe priority to Realtime DOES significantly improve Mhash/s (on windows 7 64-Bit at least)
To do that, after opening, open taskmgr as ADMINISTRATOR right click the process and Set Priority->Realtime
Is realtime the highest priority in Windows? I set mine to high priority in Ubuntu (niceness value of -5), but I haven't noticed much of a difference.
420
hero member
Activity: 756
Merit: 500
I'm convinced that setting CGMINER.exe priority to Realtime DOES significantly improve Mhash/s (on windows 7 64-Bit at least)
To do that, after opening, open taskmgr as ADMINISTRATOR right click the process and Set Priority->Realtime

using CGMINER 2.6.4, I didn't set priority to realtime, kept at normal
after over an hour of mining, average mhash is 2239
Then I reopened, set priority to realtime
after over an hour of mining, average mhash is 2272 and rising (eventually rose to 2276 6-8 hours later)

SETTINGS for 3x5970's:
Intensity: 8
GPU clock: 851
Memory Clock: 284
Voltage: 1.1v (had to use Sapphire Trixx, Cgminer wasn't setting my voltages)
Kernel: Diablo
vectors 2, worksize 256, these two settings I placed in the BAT file used to open cgminer, the rest are in the .conf file. [BAT FILE: cgminer.exe -v 2 -w 256 --failover-only]
Fan auto, temp target 80 thought it goes way over and even hits 87 which is my temp overheat and I don't think CG is doing anything at that point, temp overheat is 90 it has also hit that very rarely but doesn't seem to shutoff my cards!
-ck
legendary
Activity: 4088
Merit: 1631
Ruu \o/
Is there a place to get older version of cgminer?  I need 2.5.0, I think 2.6.x is the problem I'm facing right now...
All older versions here:
http://ck.kolivas.org/apps/cgminer/
legendary
Activity: 2576
Merit: 1186
Is there a place to get older version of cgminer?  I need 2.5.0, I think 2.6.x is the problem I'm facing right now...
http://ck.kolivas.org/apps/cgminer/cgminer-2.5/
legendary
Activity: 1190
Merit: 1000
www.bitcointrading.com
Is there a place to get older version of cgminer?  I need 2.5.0, I think 2.6.x is the problem I'm facing right now...
-ck
legendary
Activity: 4088
Merit: 1631
Ruu \o/
People seem to not understand it is entirely possible 2 people arrive at the same solution to the same bug at different times. This complaint is now about something like a one line bugfix with exactly those circumstances. Paranoid delusions indeed.
legendary
Activity: 2576
Merit: 1186
Since all this code is GPL, would the easier solution for them not simply be submit your commit, which would involve almost zero effort, rather then re-arrange your code? What is to gain? What's their motive?
Detraction and trolling me is their apparent motive.

Maybe also related to this:
Quote
I don't even take his code pushes even if they're apparently bugfixes
legendary
Activity: 2576
Merit: 1186
Copying is not the issue. The issue is Con and Kano passing off others' work as their own.

At the end of the day it's just your paranoid (delusional?) opinon that they took your code, changed it then submitted it themselves.

Since all this code is GPL, would the easier solution for them not simply be submit your commit, which would involve almost zero effort, rather then re-arrange your code? What is to gain? What's their motive?
Isn't BFG a fork of cgminer?  So he came in, added a few lines, and then now HE'S complaining about stolen code?
It was a fork of the original CGMiner. I rewrote a lot of code to make it possible to have other drivers (the original was CPU and GPU as mostly separate code), and added support for FPGAs. Con took that code back into CGMiner, and eventually forked his copy of it.

So in short, cpu-miner was forked to CGMiner for GPU support. CGMiner was forked to BFGMiner for FPGA support. BFGMiner was then forked back into CGMiner for political reasons.

Also, I make sure to attribute even Con and Kano's (indirect) contributions to BFGMiner.
legendary
Activity: 1190
Merit: 1000
www.bitcointrading.com
Copying is not the issue. The issue is Con and Kano passing off others' work as their own.

At the end of the day it's just your paranoid (delusional?) opinon that they took your code, changed it then submitted it themselves.

Since all this code is GPL, would the easier solution for them not simply be submit your commit, which would involve almost zero effort, rather then re-arrange your code? What is to gain? What's their motive?
Isn't BFG a fork of cgminer?  So he came in, added a few lines, and then now HE'S complaining about stolen code?
full member
Activity: 168
Merit: 100
ignoring the ginger now. because gingers are scary!
legendary
Activity: 1795
Merit: 1208
This is not OK.
Copying is not the issue. The issue is Con and Kano passing off others' work as their own.

At the end of the day it's just your paranoid (delusional?) opinon that they took your code, changed it then submitted it themselves.

Since all this code is GPL, would the easier solution for them not simply be submit your commit, which would involve almost zero effort, rather then re-arrange your code? What is to gain? What's their motive?
legendary
Activity: 1190
Merit: 1000
www.bitcointrading.com
Neither of these two examples have the same, copied solution. They were both solved independently in similar ways as they are both soving the same problem. It's no suprise the timing is also similar as these issue are being found at the same time.
I don't know why you're defending his obvious theft. They do have the same copied solution, even if Kano made a poor effort to obfuscate it; while the first one might have only had one or two ways it could be fixed, this last one has numerous possible solutions (the most obvious being significantly better than the one I ended up taking except for making merging from cgminer harder if cgminer hadn't adopted it too); yet in both cases Kano used the exact same solution - only trivial/non-substantial changes to the syntax/names were made.

Neither of these bugs were in fact found in cgminer: the curlring issue was one I experienced myself personally, spent hours debugging, and finally identified a solution for; the only way Kano would have even known it existed was by reading BFGMiner's commit log; the JSON escaping issue only really affect BFGMiner because its compiled-in prefix on Windows uses backslashes.

you have been told to get the fuck out of this thread several times. i'm no mod here but i have something to complain about... most of BigFuckingCunt miner is based on conmans work...
Go troll elsewhere. CGMiner was based on Garzik's work in the same way: Con added GPU support, and I added FPGA support. Until ASICs were announced, Con had nothing to do with FPGA support.

Aren't most of what people are arguing about code-wise GPL or similar open licenses? If so, copying is a non-issue and is to be applauded. It benefits the greater good.
Copying is not the issue. The issue is Con and Kano passing off others' work as their own.
full member
Activity: 182
Merit: 100
Neither of these two examples have the same, copied solution. They were both solved independently in similar ways as they are both soving the same problem. It's no suprise the timing is also similar as these issue are being found at the same time.
I don't know why you're defending his obvious theft. They do have the same copied solution, even if Kano made a poor effort to obfuscate it; while the first one might have only had one or two ways it could be fixed, this last one has numerous possible solutions (the most obvious being significantly better than the one I ended up taking except for making merging from cgminer harder if cgminer hadn't adopted it too); yet in both cases Kano used the exact same solution - only trivial/non-substantial changes to the syntax/names were made.

Neither of these bugs were in fact found in cgminer: the curlring issue was one I experienced myself personally, spent hours debugging, and finally identified a solution for; the only way Kano would have even known it existed was by reading BFGMiner's commit log; the JSON escaping issue only really affect BFGMiner because its compiled-in prefix on Windows uses backslashes.

you have been told to get the fuck out of this thread several times. i'm no mod here but i have something to complain about... most of BigFuckingCunt miner is based on conmans work...
Go troll elsewhere. CGMiner was based on Garzik's work in the same way: Con added GPU support, and I added FPGA support. Until ASICs were announced, Con had nothing to do with FPGA support.

Aren't most of what people are arguing about code-wise GPL or similar open licenses? If so, copying is a non-issue and is to be applauded. It benefits the greater good.
Copying is not the issue. The issue is Con and Kano passing off others' work as their own.

Ah, an accrediting issue. As I know nothing about who did what I'll bow out.
legendary
Activity: 2576
Merit: 1186
A bit like taking some header files and removing the author/copywrite info?
Please don't make implied accusations that aren't true, kthx.
legendary
Activity: 1795
Merit: 1208
This is not OK.
A bit like taking some header files and removing the author/copywrite info?
legendary
Activity: 2576
Merit: 1186
Neither of these two examples have the same, copied solution. They were both solved independently in similar ways as they are both soving the same problem. It's no suprise the timing is also similar as these issue are being found at the same time.
I don't know why you're defending his obvious theft. They do have the same copied solution, even if Kano made a poor effort to obfuscate it; while the first one might have only had one or two ways it could be fixed, this last one has numerous possible solutions (the most obvious being significantly better than the one I ended up taking except for making merging from cgminer harder if cgminer hadn't adopted it too); yet in both cases Kano used the exact same solution - only trivial/non-substantial changes to the syntax/names were made.

Neither of these bugs were in fact found in cgminer: the curlring issue was one I experienced myself personally, spent hours debugging, and finally identified a solution for; the only way Kano would have even known it existed was by reading BFGMiner's commit log; the JSON escaping issue only really affect BFGMiner because its compiled-in prefix on Windows uses backslashes.

you have been told to get the fuck out of this thread several times. i'm no mod here but i have something to complain about... most of BigFuckingCunt miner is based on conmans work...
Go troll elsewhere. CGMiner was based on Garzik's work in the same way: Con added GPU support, and I added FPGA support. Until ASICs were announced, Con had nothing to do with FPGA support.

Aren't most of what people are arguing about code-wise GPL or similar open licenses? If so, copying is a non-issue and is to be applauded. It benefits the greater good.
Copying is not the issue. The issue is Con and Kano passing off others' work as their own.
Jump to: