Topic: [XMR] Monero - A secure, private, untraceable cryptocurrency - page 1604. (Read 4670622 times)

orly?

https://github.com/monero-project/bitmonero/blob/master/src/wallet/wallet_rpc_server.h#L52
https://github.com/monero-project/bitmonero/blob/master/src/wallet/wallet_rpc_server.cpp#L142

Is this in 0.8.8 or in master ?

I'll quote dNote on this:

Quote from: dNote on July 23, 2014, 11:47:07 AM

Quote from: fluffypony on July 23, 2014, 11:20:20 AM

Quote from: Quicken on July 23, 2014, 11:39:42 AM

-snip-

Well, I'll cut-and-paste my reply to you from Github:

Quote

@ducknote Please don't act stupid, you're better than this.

1. You're conflating - that was pulled into the code long before there were any Monero developers: https://github.com/monero-project/bitmonero/commit/333f975760c156727dd7408f87e937af856d8bf1. We have not failed to credit the CryptoNote developers, and where there is code that is merged from other CryptoNote projects we ALWAYS credit the source. For example, we have credited Boolberry on more than one occasion: https://github.com/monero-project/bitmonero/commit/c050ff43bf5a8310b18081c5cd3d9bcd123416b8, https://github.com/monero-project/bitmonero/commit/3bc16dc0e6bd38fbec51a054e640bacdb17a9a82. Similarly, Boolberry have credited us on more than one occasion: https://github.com/cryptozoidberg/boolberry/commit/f7a019683a2ecc1954b761ac7094d588644ecf1c, https://github.com/cryptozoidberg/boolberry/commit/88bfcbf6d067a3f15f3d22a87dcb54211dc11f17, and https://github.com/cryptozoidberg/boolberry/commit/0ae9a2f24757e7229cf63776b5897c5b408c065e.

2. I've never heard of a "golden ampersand" bug, and neither has Google. Either you're outrightly lying, or you're using the wrong term entirely. Regardless, your ad hominem attack is nothing more than a straw man argument to try and detract from your despicable failure to credit the authors of the code you have merged down.

To be specific, again, this functionality (the payment ID being available in the JSON RPC transfer call) is not something you wrote. It is something we wrote. I have already linked you to the commit where it was merged on June 2nd. Don't worry - you're not the only one that has failed to credit Monero, Bytecoin also added the change on June 25th, stripped the code comments, and failed to credit us.

If you wish to remain honourable it would be appropriate for you not to insult me or any of the contributors to Monero, and to credit us where you have used our code. Of course, if there is anything you write that we use we will most definitely credit you, just as we have done with Boolberry.

Code gets committed to staging so it can be tested. The piece of code you're referring to is not in the 0.8.8 tagged release, and is thus not finalised. Thanks for pointing out the error, but nobody has lost anything.

lolollol "golden ampersand" bug - is mine © - i call it golden because just one "&" can cause a lot of money loss by monero users.

Again - Transaction ID was implemented in Bytecoin long before monero made it - https://github.com/amjuarez/bytecoin/commit/57cf53625817223733bdaf2f4e518ebae978713e April 29.

Monero just made it in RPC call, that part of kiddy code was ok, but nothing special and nothing hard. and at least that part of monero code was ok.

AGAIN:

Quote

Code gets committed to staging so it can be tested. The piece of code you're referring to is not in the 0.8.8 tagged release, and is thus not finalised. Thanks for pointing out the error, but nobody has lost anything.

Lets do like that:
1. Go to http://monero.cc
2. Click Getting Started link

http://monero.cc/getting-started/index.html
3. Click http://monero.cc/getting-started/index.html#install_source
4. Here we can read: git clone git://github.com/monero-project/bitmonero && cd bitmonero && make
5. Go to the suggested code, master branch -> commits: https://github.com/monero-project/bitmonero/commits/master
6. Find that commit https://github.com/monero-project/bitmonero/commit/d433a696e527a01c1cbef48495652335140f0bb2 on master branch
7. Profit! Monero got "golden ampersand" bug since that commit, means since June 18th. All exchanges and services that made source code compilation from monero master branch since June 18th affected.

equipoise

hero member

Activity: 794

Merit: 1000

Monero (XMR) - secure, private, untraceable

A few little queries about transaction fees. Let's say I have two hypothetical wallets.

Old, dusty wallet 1 has 100 dust (<0.1) transactions from mining, 50 small transactions of .2, and 10 larger (>100) transactions from exchange transfers. No transactions out.

New, shiny wallet 2 is empty.

Now, if I were to transfer everything from wallet 1 to wallet 2 in a single transaction:

1) Would this go through as a single transaction?
2) What transaction fee would be payable?
3) Where do transaction fees go?
4) How will transaction fees be changing in the future?

Loving the Monero by the way. Don't let the FUD'ers bother you.
Cheers, Q

1) Probably most of it, but not all of it - you should try.
2) Each transaction will have 0.005 fee
3) To the miners
4) Most probably if the price goes up by significant factor the fee will go down (for the same maximum size of the transaction).

tacotime

legendary

Activity: 1484

Merit: 1005

Quote from: Hexah on July 23, 2014, 11:50:25 AM

So, basically you wasted users money because of your incompetence?

Wasn't my code or my merge; when devs commit things to HEAD we warn everyone that they're experimental.

Hexah

sr. member

Activity: 728

Merit: 265

Quote from: tacotime on July 23, 2014, 11:44:40 AM

https://github.com/monero-project/bitmonero/blob/master/src/wallet/wallet_rpc_server.h#L52
https://github.com/monero-project/bitmonero/blob/master/src/wallet/wallet_rpc_server.cpp#L142

This was somehow merged despite it being fixed a while ago while in testing

https://github.com/tewinget/bitmonero/commit/e7a3bd19f61d047f3daa49910e0d7da41ef47a8b

It was neglected to be merged in with the latest bunch of commits due to an oversight

So, basically you wasted users money because of your incompetence?

dreamspark

hero member

Activity: 798

Merit: 1000

orly?

https://github.com/monero-project/bitmonero/blob/master/src/wallet/wallet_rpc_server.h#L52
https://github.com/monero-project/bitmonero/blob/master/src/wallet/wallet_rpc_server.cpp#L142

Is this in 0.8.8 or in master ?

tacotime

legendary

Activity: 1484

Merit: 1005

https://github.com/monero-project/bitmonero/blob/master/src/wallet/wallet_rpc_server.h#L52
https://github.com/monero-project/bitmonero/blob/master/src/wallet/wallet_rpc_server.cpp#L142

This was somehow merged despite it being fixed a while ago while in testing

https://github.com/tewinget/bitmonero/commit/e7a3bd19f61d047f3daa49910e0d7da41ef47a8b

It was neglected to be merged in with the latest bunch of commits due to an oversight

Quicken

sr. member

Activity: 280

Merit: 250

A few little queries about transaction fees. Let's say I have two hypothetical wallets.

Old, dusty wallet 1 has 100 dust (<0.1) transactions from mining, 50 small transactions of .2, and 10 larger (>100) transactions from exchange transfers. No transactions out.

New, shiny wallet 2 is empty.

Now, if I were to transfer everything from wallet 1 to wallet 2 in a single transaction:

1) Would this go through as a single transaction?
2) What transaction fee would be payable?
3) Where do transaction fees go?
4) How will transaction fees be changing in the future?

Loving the Monero by the way. Don't let the FUD'ers bother you.
Cheers, Q

Rias

sr. member

Activity: 373

Merit: 250

Quote from: dreamspark on July 23, 2014, 11:26:13 AM

Quote from: Cheesus on July 23, 2014, 11:20:06 AM

Quote from: Cheesus on July 23, 2014, 11:20:06 AM

monero devs seems to be absolutely beginners - your accusations and anger touched us, here is a result of 10 min research of your kiddy coding, concerning Payments ID and games with your kiddy coin wallet:
Second chapter of any average "Beginners in C++ guide" says that arguments can be passed to parameters either by value or by reference.
Looks like monero devs did not noticed that, when they recently read that kind of books.

Lets look at this playground:
https://github.com/monero-project/bitmonero/commit/d433a696e527a01c1cbef48495652335140f0bb2

With "Monero golden ampersand bug" made by monero devs, monero devs missed some &, wuuups:

bool validate_transfer(const std::list destinations, const std::string payment_id, std::vector& dsts, std::vector& extra, epee::json_rpc::error& er);

bool wallet_rpc_server::validate_transfer(const std::list destinations, const std::string payment_id, std::vector& dsts, std::vector& extra, epee::json_rpc::error& er)

Affects: Monero simplewallet since at least June 18 just lose all Payment ID data, so people can lost their money if they use your so called monero RPC "features". Again - all transfers in monero network made with JSON-RPC Payment ID, EG from Poloniex exchange to Bittrex exchange was made wrong if they use monero latest main kiddy code, or may be just lost. Qua, qua, qua ...

Users, be careful with kiddy coders.

Well this is awkward. Grin

Allmighty monero devs are not so allmighty after all. Grin

And there was so much marketing about it... it's not even fun, it's just sad.

So, that's why my XMR from hitbtc didn't reach Poloniex. And I was asking myself what I did wrong.

No its not, this piece of code is not in the latest tagged realease. See here for fluffyponys response.

https://bitcointalksearch.org/topic/m.7987794

orly?

https://github.com/monero-project/bitmonero/blob/master/src/wallet/wallet_rpc_server.h#L52
https://github.com/monero-project/bitmonero/blob/master/src/wallet/wallet_rpc_server.cpp#L142

dreamspark

hero member

Activity: 798

Merit: 1000

Quote from: Cheesus on July 23, 2014, 11:20:06 AM

monero devs seems to be absolutely beginners - your accusations and anger touched us, here is a result of 10 min research of your kiddy coding, concerning Payments ID and games with your kiddy coin wallet:
Second chapter of any average "Beginners in C++ guide" says that arguments can be passed to parameters either by value or by reference.
Looks like monero devs did not noticed that, when they recently read that kind of books.

Lets look at this playground:
https://github.com/monero-project/bitmonero/commit/d433a696e527a01c1cbef48495652335140f0bb2

With "Monero golden ampersand bug" made by monero devs, monero devs missed some &, wuuups:

bool validate_transfer(const std::list destinations, const std::string payment_id, std::vector& dsts, std::vector& extra, epee::json_rpc::error& er);

bool wallet_rpc_server::validate_transfer(const std::list destinations, const std::string payment_id, std::vector& dsts, std::vector& extra, epee::json_rpc::error& er)

Affects: Monero simplewallet since at least June 18 just lose all Payment ID data, so people can lost their money if they use your so called monero RPC "features". Again - all transfers in monero network made with JSON-RPC Payment ID, EG from Poloniex exchange to Bittrex exchange was made wrong if they use monero latest main kiddy code, or may be just lost. Qua, qua, qua ...

Users, be careful with kiddy coders.

Well this is awkward. Grin

Allmighty monero devs are not so allmighty after all. Grin

And there was so much marketing about it... it's not even fun, it's just sad.

So, that's why my XMR from hitbtc didn't reach Poloniex. And I was asking myself what I did wrong.

No its not, this piece of code is not in the latest tagged realease. See here for fluffyponys response.

https://bitcointalksearch.org/topic/m.7987794

Rias

sr. member

Activity: 373

Merit: 250

monero devs seems to be absolutely beginners - your accusations and anger touched us, here is a result of 10 min research of your kiddy coding, concerning Payments ID and games with your kiddy coin wallet:
Second chapter of any average "Beginners in C++ guide" says that arguments can be passed to parameters either by value or by reference.
Looks like monero devs did not noticed that, when they recently read that kind of books.

Lets look at this playground:
https://github.com/monero-project/bitmonero/commit/d433a696e527a01c1cbef48495652335140f0bb2

With "Monero golden ampersand bug" made by monero devs, monero devs missed some &, wuuups:

bool validate_transfer(const std::list destinations, const std::string payment_id, std::vector& dsts, std::vector& extra, epee::json_rpc::error& er);

bool wallet_rpc_server::validate_transfer(const std::list destinations, const std::string payment_id, std::vector& dsts, std::vector& extra, epee::json_rpc::error& er)

Affects: Monero simplewallet since at least June 18 just lose all Payment ID data, so people can lost their money if they use your so called monero RPC "features". Again - all transfers in monero network made with JSON-RPC Payment ID, EG from Poloniex exchange to Bittrex exchange was made wrong if they use monero latest main kiddy code, or may be just lost. Qua, qua, qua ...

Users, be careful with kiddy coders.

Well this is awkward. Grin

Allmighty monero devs are not so allmighty after all. Grin

And there was so much marketing about it... it's not even fun, it's just sad.

So, that's why my XMR from hitbtc didn't reach Poloniex. And I was asking myself what I did wrong.

Re-reading Poloniex announcements:

Thanks to the XMR devs the payments are order of magnitude faster at losing user's money. So lol.

hitbtc

sr. member

Activity: 525

Merit: 250

Dear HitBTC Users,

Regarding your numerous questions on the possible reasons of XMR payments not being processed correctly, we would like to inform you that the bug which caused the above-mentioned issue has been identified: due to a common technical issue, the transaction IDs were not sent to the XMR blockchain since 22/07/2014 11:30 UTC.

While this bug has not affected users who were withdrawing Monero to their own wallets, it affected the users who were transferring Monero directly between their accounts at different cryptocurrency exchanges, including HitBTC. The consequence being that the coins transferred directly from one exchange to another did not contain a payment ID, preventing users’ trading account from being credited.

At the present moment the problem has already been solved. We also inform you that HitBTC has cooperated with the involved exchanges on crediting users their funds.

In case you encounter any difficulties withdrawing or depositing Monero, please contact our Support team, and we will investigate the case in shortest time possible.

Regards,
the HitBTC team

Cheesus

sr. member

Activity: 692

Merit: 254

terra-credit.com

Quote from: drawingthesun on July 23, 2014, 10:20:47 AM

monero devs seems to be absolutely beginners - your accusations and anger touched us, here is a result of 10 min research of your kiddy coding, concerning Payments ID and games with your kiddy coin wallet:
Second chapter of any average "Beginners in C++ guide" says that arguments can be passed to parameters either by value or by reference.
Looks like monero devs did not noticed that, when they recently read that kind of books.

Lets look at this playground:
https://github.com/monero-project/bitmonero/commit/d433a696e527a01c1cbef48495652335140f0bb2

With "Monero golden ampersand bug" made by monero devs, monero devs missed some &, wuuups:

bool validate_transfer(const std::list destinations, const std::string payment_id, std::vector& dsts, std::vector& extra, epee::json_rpc::error& er);

bool wallet_rpc_server::validate_transfer(const std::list destinations, const std::string payment_id, std::vector& dsts, std::vector& extra, epee::json_rpc::error& er)

Affects: Monero simplewallet since at least June 18 just lose all Payment ID data, so people can lost their money if they use your so called monero RPC "features". Again - all transfers in monero network made with JSON-RPC Payment ID, EG from Poloniex exchange to Bittrex exchange was made wrong if they use monero latest main kiddy code, or may be just lost. Qua, qua, qua ...

Users, be careful with kiddy coders.

Well this is awkward. Grin

Allmighty monero devs are not so allmighty after all. Grin

And there was so much marketing about it... it's not even fun, it's just sad.

So, that's why my XMR from hitbtc didn't reach Poloniex. And I was asking myself what I did wrong.

xa4

member

Activity: 71

Merit: 10

Can I just say that Ethereum isn't really our enemy.

Ethereum cannot offer anonymity, and if they implement something like ring signatures, they will be far less efficient than a native currency such as Monero.

Ethereum is going against a bit of Bitcoin but mostly it's generating it's own market.

Correct me if you think I am wrong, I'm really interested in hearing other peoples thoughts on the matter.

Acccording to V.Buterin you could implement a ring signatures algo in a contract and have 1 on 1 peg with the underlying ethers (ETH) -> your selfmade currency and underlying ethers would be annonymous.

http://redd.it/2b7gpd

Ethereum is very promising, but we'll have to see if the technology actually works. If it lives up to it's promise, I think it will become THE platform for smart contracts, ... and now is the time to look for options, ideas on how to make them work together.(EDIT Monero and ethereum)

Hexah

sr. member

Activity: 728

Merit: 265