Second chapter of any average "Beginners in C++ guide" says that arguments can be passed to parameters either by value or by reference.
Looks like monero devs did not noticed that, when they recently read that kind of books.
Lets look at this playground:
https://github.com/monero-project/bitmonero/commit/d433a696e527a01c1cbef48495652335140f0bb2
With "Monero golden ampersand bug" made by monero devs, monero devs missed some &, wuuups:
bool validate_transfer(const std::list
bool wallet_rpc_server::validate_transfer(const std::list
Affects: Monero simplewallet since at least June 18 just lose all Payment ID data, so people can lost their money if they use your so called monero RPC "features". Again - all transfers in monero network made with JSON-RPC Payment ID, EG from Poloniex exchange to Bittrex exchange was made wrong if they use monero latest main kiddy code, or may be just lost. Qua, qua, qua ...
Users, be careful with kiddy coders.
Well this is awkward. Allmighty monero devs are not so allmighty after all.
And there was so much marketing about it... it's not even fun, it's just sad.
So, that's why my XMR from hitbtc didn't reach Poloniex. And I was asking myself what I did wrong.
Re-reading Poloniex announcements:
Thanks to the XMR devs the payments are order of magnitude faster at losing user's money. So lol.