Dev Meeting Transcript (October 29, 2021)[3:59 PM] Tron: Channel is open.
[3:59 PM] Wolfsokta: Awesome! Hey Tron
[4:00 PM] Sevvy (Natural 1): Greetings all
[4:00 PM] Sevvy (Natural 1): What's happening
[4:01 PM] kralverde {CULT OF JOE}: When do you all expect to merge p2sh?
[4:01 PM] Sevvy (Natural 1): the question on everyone's mind
[4:03 PM] Sevvy (Natural 1): uhhhhh
[4:04 PM] boatsandhoes: +1
[4:05 PM] Tron: Just a few more changes to address/fix/ignore the issues brought up by the security audit report.
[4:05 PM] boatsandhoes: Any way we can do the fork vote Nov 5th?
[4:06 PM] Sevvy (Natural 1): lol, 3 years later, assets get p2sh, would be apropos
[4:06 PM] Wolfsokta: That would be cool!
[4:06 PM] Sevvy (Natural 1): It's probably late though. WE would need to achieve consensus 1.4 days in advance of the 5th
[4:07 PM] Sevvy (Natural 1): so that the new code would activate at a block height occurring within Nov 5
[4:07 PM] Tron: Just a reminder that there is a meetup in Ravencoin Campus tonight at 8pm ET.
[4:08 PM] Wolfsokta: Date night in Ravenland!
[4:08 PM] Tron:
https://download.ravencoincampus.org/[4:08 PM] Sevvy (Natural 1): I am going to say what has been on a few peoples minds. These meetings have been very sparsely attended and haven't contained a lot of commentary on the state of development. That pattern is not one I find acceptable. Tron, can you comment on that trend? Is there simply not much development to discuss?
[4:09 PM] Tron:
https://twitter.com/Humble_Miner/status/1450646655158599680/photo/1[4:10 PM] Sevvy (Natural 1): I think a lot of people would like to see a bit more commentary during these meetings, if there is any to be made. I understand that the Foundation and Ravencoin are separate things, but it could be approrpiate to discuss the state of the foundation and any events/actions you've been involved in each week, Tron
[4:10 PM] Sevvy (Natural 1): For whatever reason, you have seemed somewhat laissez faire in the last several meetings
[4:11 PM] Wolfsokta: I'm really hoping that we can get some traction on developing the Mineable Assets proposal further and getting some bounties created soon.
[4:11 PM] Tron: We are at the tail end of a long development cycle. The project is valued at over a billion dollars, not including the value of assets, and so it is, by design, a slower, more careful approach.
[4:11 PM] Sevvy (Natural 1): I also recall that in the past you've at least stated things about being unable to talk about certain things due to disclosure agreements and such. As was the case with Finclusive, years ago I believe
[4:11 PM] Wolfsokta: Agreed
[4:12 PM] Tron: There is a new discussion of mineable assets. Everyone should look at the proposal and give feedback. This will probably be added to the roadmap soon. Wolfsokta is writing up the specs.
[4:13 PM] M4R1M0: This "development cycle" has just been adding functionality that should have already been in place when assets were launched. Would be nice to get some discussion surrounding new innovations for Ravencoin.
[4:13 PM] Tron: The goal with mineable assets is to allow projects to mine tokens into existence with wide distribution, and keep some of the mined tokens to fund the project.
[4:14 PM] Tron: The "coinbase" space will have a cost, but for some projects, it will provide automatic distribution and awareness.
[4:14 PM] Wolfsokta: WETx was on the main stage at the Silicon Slopes tech conference in Salt Lake City. This was our first slide.
[4:15 PM] Tron: Currently, the proposal is 1 RVN per mined block that has the new mined asset. The asset issuer can decide how frequently to have their asset in the blocks as well as a max distribution.
[4:16 PM] Tron: There will be bounties posted for both proposals after the feedback is collected and the designed refined.
[4:16 PM] Wolfsokta: I'm working on the specs now, and will likely post them as an Issue in github.
[4:16 PM] boatsandhoes: Is the goal to get minable assets in the next fork, or is this a down the line thing?
[4:17 PM] Wolfsokta: Probably not in the next one.
[4:17 PM] Wolfsokta: We'll want to really test the new feature well and have a security review.
[4:17 PM] Tron: Oh, the other proposal is for the emulation of the RPC calls to make it easier to integrate mined or issued tokens into exchanges that are used to RPC calls for Bitcoin/Litecoin/Ravencoin/Dogecoin, etc.
[4:18 PM] Tron:
https://github.com/RavenProject/Ravencoin/tree/master/roadmap/compatibility-mode[4:18 PM] Wolfsokta: That will make it easier for exchanges to list the Mineable Assets, as well as any other asset on RVN.
[4:20 PM] boatsandhoes: Is there an ETA on this?
[4:22 PM] Wolfsokta: Timing will depend on devs picking up the bounties. That's hard to estimate.
[4:22 PM] Wolfsokta: I'd like to work with the Foundation to have the bounties defined in the next week or so.
[4:22 PM] boatsandhoes: Wait there are bounties that need to be done in order to get the P2SH fork out?
[4:23 PM] Wolfsokta: I thought you were talking about Mineable Assets and Compatibility mode.
[4:23 PM] boatsandhoes: I was not
[4:24 PM] boatsandhoes: the board has not had a meeting in 5 months, I think they should get their (the non profit) affairs in order before they bite off more
[4:25 PM] Tron: I don't have a time frame. If there are PRs, I'll review and approve them.
[4:25 PM] Tron: The board has met each month. The notes need to be posted.
[4:27 PM] boatsandhoes: Sorry a bit foggy, what specifically needs to happen in order to initiate the fork for P2SH?
[4:30 PM] Tron: Each of the issues brought up in the security audit needs to be addressed/fixed/ignored. By ignored, I mean that a quick write-up needs to be done as to why it isn't a real problem. The block # start and % need to be set for the fork. The version number needs to be set. The code needs to be merged. All the binaries (Windows, Mac, Linux) need to be built and signed.
[4:30 PM] boatsandhoes: Thank you
[4:32 PM] boatsandhoes: Has anyone started to break down each issue of the audit yet?
[4:33 PM] Wolfsokta: It would be good to create github Issues for each of them and start knocking them out.
[4:36 PM] boatsandhoes: Indeed. It's hard to believe that someone has not already done so.
I don't mind doing it, but don't want to do work that has already been done
[4:37 PM] Tron: There have been comments and analysis of the items in the security report, but I am unaware of any issues created or code changes.
[4:37 PM] boatsandhoes: fdov you had comments on the audit right?
[4:37 PM] Tron: Some of the issues are of a nature that the security analysis is correct, but a change (fix) will potentially cause a fork. These need to be handled carefully, or just documented as to why the change isn't being applied.
[4:38 PM] boatsandhoes: If foundation money goes anywhere it may be best to hire a person who is capable of doing things like this, and by default (because they are being paid) has the time
[4:39 PM] boatsandhoes: ^will table that for next open foundation meeting
[4:39 PM] Tron: At least one of the issues is just completely wrong and needs to be documented as such and then ignored.
[4:40 PM] Sevvy (Natural 1): what issue is completely wrong?
[4:41 PM] Tron: The issue about secure_string.
[4:41 PM] Wolfsokta: Yeah it was pointing out a security risk in .NET...
[4:42 PM] Wolfsokta: .NET isn't used anywhere in the RVN code.
[4:42 PM] Tron:
https://discord.com/channels/429127343165145089/482289959261175838/898210263831019541[4:43 PM] Sevvy (Natural 1): ah, okay I recall this
[4:43 PM] Sevvy (Natural 1): and yes, it speaks to the alleged lack of utility of the auditors
[4:43 PM] boatsandhoes: Starting the github issue, will ask a mod to ping to news go get eyes on it when submitted
[4:44 PM] boatsandhoes: if only there was a rate my teacher for crypto audits ♂️
[4:47 PM] boatsandhoes: anything else that needs to be addressed today?
[4:48 PM] Wolfsokta: What can I do to help Tron to get the next release out the door?
[4:48 PM] shimperr: Ya have not posted in 6 months but who is counting
[4:48 PM] boatsandhoes: Wolfsokta I'll tag you with the github issue if you can help with that there are only 5 things
[4:49 PM] shimperr: Don’t think it was answered so I will ask again do we have a date on the hard fork?
[4:49 PM] Wolfsokta: Okay, I think it'd be better to have 5 issues then rather than a single big one.
[4:50 PM] shimperr: Tbh mining assets sounds fun but I think there should be a push for messages to asset holders function
[4:50 PM] boatsandhoes: Okay, I'll do it that way, np
[4:51 PM] Tron: The core protocol already has messages. It is up to wallets or websites to publish the info.
[4:52 PM] shimperr: Can you link any info on this? I have never seen this would love to use this
[4:52 PM] Sevvy (Natural 1): it's been in the console for ages
[4:52 PM] shimperr: Or anyone really
[4:53 PM] Tron: There is not a fixed date for the fork. There will be a start date added to the code so it can start monitoring the network for actively mined blocks with the new code and counting them.
[4:53 PM] shimperr: To send ipfs to asset holders from the main asset?
[4:54 PM] shimperr: What is the time line the devs thinking this would happen
[4:54 PM] Tron: Probably late Nov to Dec for the binaries.
[4:55 PM] shimperr: Thanks
[4:57 PM] fdov: yes, the audit is useless. They have no clue how Ravencoin works. Their suggestions would create a minimum of 2 hard-forks on their own. Waste of time and energy. They found only non-issues or minor nit which has nothing to do with security of functionality. Only maintainability and cleanness. As an example they claim we should fix at least two "issues" in code we have that is identical to bitcoin. I trust bitcoin more than I trust some random dudes writing that report.
[4:57 PM] shimperr: I will look into the messaging but I know it’s not in the GUI
[4:57 PM] boatsandhoes: Just submitted the issues/ 5 vulnerabilities
[4:57 PM] boatsandhoes:
https://github.com/RavenProject/Ravencoin/issues/new[4:59 PM] Sevvy (Natural 1): waiting 10 months to implement code that should have existed on november 5 2018 because we need to wait for a company to tell us wrong stuff is embarassing
[4:59 PM] shimperr: We did have a 300 million rvn exploit because someone let the code in
[5:00 PM] boatsandhoes: In your eyes, is there anything that needs to change before the P2SH fork is put out for vote?
[5:00 PM] shimperr: Which we will not go into why that happened
[5:00 PM] boatsandhoes: agreed
[5:01 PM] boatsandhoes: but still, got to do due diligence
[5:01 PM] shimperr: But from my understanding this fork needs to happen quickly
[5:02 PM] fdov: This happens because this project has close to no developers. With only 2-3-4 guys doing any coding, the trust in the code is limited. Not much peer-review etc. The solution is to delay and pay for reports.
[5:02 PM] Sevvy (Natural 1): and we recently seem to have all but lost Hans
[5:02 PM] boatsandhoes: fdov would you mind helping to comment on the audit suggestions on github so we can get the ball rolling? I already made 5 issues
[5:03 PM] Wolfsokta: That would be awesome.
[5:03 PM] boatsandhoes:
[5:03 PM] fdov: Currently it is a hard-fork, if implemented like it is currently on testnet. So yes, if it is "activated" it will kick all the old clients off. Everyone will need to update within a limited timeframe.
[5:04 PM] Sevvy (Natural 1): it needs to happen with a BIP9 and high consensus so we don't split the chain unnecessarily
[5:04 PM] Sevvy (Natural 1): not "quickly"
[5:04 PM] fdov: Everyone will be gone with this pace. There are 1000 other projects for anyone interested.
[5:04 PM] Sevvy (Natural 1): seems like it yeah
[5:04 PM] Sevvy (Natural 1): so what do we do
[5:04 PM] LSJI07 - BWS: Based on the previous fork what timescales are we looking at between releasing the new release and starting bip9?
[5:05 PM] shimperr: 80 percent approved and we good that’s not the problem the issue is doing it when the devs feel good about the fork
[5:05 PM] boatsandhoes: Tron there is also an issue with a sizable % of those authorized to approve code changes on github being afk for years. There really are only a couple gatekeepers( you included) for this. If changes are going to happen, that list needs to be culled then opened up
[5:05 PM] boatsandhoes: just my 2 Sats on that
[5:06 PM] Tron: Agreed
[5:07 PM] boatsandhoes: Tron I can't find the link you posted a while ago that showed all the users who could approve code changes. Do you mind sharing that link again?
[5:08 PM] fdov: We can select that in the code. I don't recall the consensus, or if we agreed on anyting, but I do recall I once had some opinion on how to do it.
[5:09 PM] boatsandhoes: Minable assets and stuff sounds cool (maybe) but it looks more and more like attention should be focused on Dev Ops
[5:09 PM] boatsandhoes: at least at this current time
[5:09 PM] boatsandhoes: Chatturga is that in your wheel house?
[5:11 PM] Chatturga: Minable assets, or code change approvals?
[5:11 PM] LSJI07 - BWS: I remember vaguely it was set to something like 6 weeks, or close to that, and exchanges and pools were mostly done in a 2 week period. Jeroz wielded the force and did some amazing work on that imo.
[5:11 PM] boatsandhoes: code changes and logistics
[5:12 PM] Chatturga: Negative, I dont have the permissions to approve code changes.
[5:12 PM] boatsandhoes: But if you did?
[5:12 PM] boatsandhoes: SpyderDev ghosted so hard
[5:13 PM] Wolfsokta: Some DevOps work would be awesome and would speed all future development.
[5:13 PM] boatsandhoes: he ( SpyderDev ) should def be removed so someone else can take the spot. Chatturga if you are up for that you have my nomination
[5:14 PM] Chatturga: If I had any knowledge of coding I might be inclined, but I have no idea what I would be approving, so I'm probably not the best choice
[5:14 PM] boatsandhoes: what is the url for that?
[5:15 PM] Wolfsokta: Hello Chatturga! It's nice to hear from you.
[5:15 PM] Wolfsokta: It's been too long.
[5:15 PM] boatsandhoes: you're a better choice than the current, which is basically no one
[5:15 PM] Chatturga: Heya Wolf It's been a LONG time since Ive typed that
[5:16 PM] shimperr: Outside collaborator? Lol
[5:16 PM] Chatturga: Are we still on triangle target?
[5:17 PM] shimperr: A beta move
[5:17 PM] Tron: New lists....
[5:18 PM] boatsandhoes: we should prob wrap it up for this week.
Tron if you could share the url to that list that would be much appreciated
[5:18 PM] shimperr: Tron does Bruce have to approve all code due to ownership?
[5:18 PM] Wolfsokta: no
[5:18 PM] Mango Farm: Of course not Joe learn how to use Github or comment in the nest
[5:19 PM] Wolfsokta: The URL is in the admin section of github so it wouldn't do much good to non-admins
[5:19 PM] Tron: I think the URLs require permission.
https://github.com/orgs/RavenProject/teams/ravendevs/members[5:19 PM] boatsandhoes: the link is a 404
[5:19 PM] Tron:
https://github.com/RavenProject/Ravencoin/settings/access[5:20 PM] Wolfsokta: The URL is in the admin section of github so it wouldn't do much good to non-admins
[5:20 PM] boatsandhoes: Tron can you hook it up with admin read only for me please?
[5:21 PM] shimperr: Nice censorship deflection but tron has said this in the past I was just saying it again
[5:21 PM] Tron: What's your GitHub username?
[5:22 PM] fdov: corviato1
[5:23 PM] boatsandhoes: corviato1
[5:24 PM] Tron: Invited as read-only.
[5:24 PM] boatsandhoes: Thank you
[5:26 PM] Mango Farm: Tron the BTC Github repo publishes a list of the keys for the 7 people able to verify commits. It might be a good idea to add that to the public side (rather than the admin side) of the Github repo for RVN, along with information on who has commit ability.
[5:26 PM] Mango Farm: so it isn't an invite only kind of thing
[5:26 PM] Mango Farm:
https://github.com/bitcoin/bitcoin/blob/master/contrib/verify-commits/trusted-keys[5:26 PM] Mango Farm: just because that's the way github allows access to admin info
[5:27 PM] fdov: Mango FarmI don't think RVN has ever used GPG-keys or signing. We cleaned up the remains from bitcoin a few months ago.
[5:27 PM] fdov: But I agree it's a good idea, and it should be used.
[5:27 PM] Mango Farm: understood - more referring to the list that Tron posted above, in a publicly accessible place (even if no GPG keys are used)
[5:28 PM] boatsandhoes: +1
[5:28 PM] shimperr: Probably pretty good info to know people only been begging for 2 years
[5:29 PM] shimperr: Always been in secret
[5:29 PM] Mango Farm: Tron has published the list on several occasions; the list for Bitcoin is a set of seven numbers
[5:30 PM] fdov: ah, understand. Agree.
[5:31 PM] shimperr: Still not public info
[5:31 PM] shimperr: Today
[5:31 PM] boatsandhoes: I need to head out. Hope you guys have awesome week, and we get P2SH out as timely as possible
[5:32 PM] Mango Farm: have a great weekend Boats
[5:32 PM] Wolfsokta: Scroll up shimperr
[5:32 PM] Chatturga: See ya Boats
[5:32 PM] Wolfsokta: Thanks boatsandhoes
[5:33 PM] M4R1M0: This has been stated a few times now and keeps getting glossed over/ignored it seems. Something needs to be done about pace of development or we may soon find ourselves unable to even source developers for bounties.
[5:34 PM] Wolfsokta: I need to head out too. It was great to chat with you all again.
[5:34 PM] Chatturga: Take care Wolf
[5:34 PM] Wolfsokta: You too
[5:34 PM] Tron: I'm off too. I hope to see everyone's avatars at the meetup tonight in Ravencoin Campus.
[5:35 PM] Mango Farm: See you there Tron
[5:35 PM] Mango Farm: I'm going to go get ready for it. See everyone next time.
[5:35 PM] Tron: Closing the channel.
Dev Meeting Transcript (November 5, 2021)[3:52 PM] Tron: ------------------------------------------------------------
[3:52 PM] Tron: Channel Open
[4:00 PM] fdov: hi.
[4:04 PM] Hans_Schmidt: Yo
[4:08 PM] fdov: I noticed the build-checks still does not handle .md changes well. But I noticed the PRs are made against master, could be the issue. not sure.
[4:10 PM] Hans_Schmidt: IIRC, that's something that we don't have the authority to change.
[4:10 PM] fdov: I guess if you change the target for the PR to develop, it will rebuild and hopefully work?
[4:11 PM] fdov: I don't think the latest change (#1078) is merged to master yet.
[4:12 PM] Tron: Can you make a PR for moving develop to master? It will take approvals. If I make it, I can't approve it.
[4:12 PM] fdov: sure, one sec.
[4:13 PM] Hans_Schmidt: I believe you are correct on both counts
[4:15 PM] Tron: Is anyone currently building on Mac (Monterey)?
[4:18 PM] fdov: I get some github error.. I'll create the PR later.
[4:19 PM] fdov: I don't have macs. But the new M1 pro looks really nice.
[4:19 PM] kralverde {CULT OF JOE}:
[4:19 PM] Hans_Schmidt: No macs for me
[4:20 PM] fdov: I can build -for- mac.
[4:20 PM] Tron: I just got the 16" M1 Max yesterday. I'm setting up the build environment and running into a few issues. If anyone has slogged through the issues already, let me know.
[4:21 PM] fdov: I guess there are tons if you try to use the depends/ system. - I'm pretty sure that does not work.
[4:24 PM] Tron: Yeah, so far it hasn't worked. There is info on the ones I've run into so far, so I'm just documenting the issues and solutions as I go. Then we can either update the build docs, or fix the make system to compensate for the environment changes.
[4:25 PM] fdov: do you install the depends with brew?
[4:26 PM] Tron: Some of both so far. Apple has moved the default location for the SDK, so I'm working on that now.
[4:27 PM] Tron: The SDK can't legally be added to the repo. Installed with XCode, or downloadable from Apple.
[4:29 PM] fdov: You can download it to your machine. I've made some builds scripts look for it in /tmp/SDKs - that is for cross-compiling for osx.
[4:29 PM] fdov: Fastest is probably to make docker work, and just cross-compile.
[4:30 PM] fdov: Apple are so developer-unfriendly it's insane.
[4:32 PM] fdov: Anyway, I've made some PRs i think would be good to get into the next release, if reviewed and approved. #1115 probably the most important.
[4:34 PM] Hans_Schmidt: Thanks, I saw the PRs. I will review and approve.
[4:35 PM] fdov: If the P2SH-assets-part needs more reviewing, I'm all for a release with the code in, but not activated on mainnet. - Making a new release with activation is easy.
[4:37 PM] Hans_Schmidt: I guess that's up for debate whether people want to be cautious and release without P2SH assets
[4:37 PM] fdov: I'm fine with both.
[4:38 PM] Tron: We should set an activation date where it can begin to count the blocks towards activation percentage -- possibility of activation.
[4:38 PM] Tron: Before or after halving?
[4:39 PM] Tron: What percentage should we target?
[4:39 PM] Tron: Super conservative 95%
[4:39 PM] Tron: Conservative 90%
[4:40 PM] Tron: Anything less than 75% seems risky.
[4:40 PM] fdov: Whatever bitcoin uses? 80-90-ish?
[4:40 PM] Tron: 80 or 85 seems right.
[4:41 PM] Tron: It will be difficult to get to 85 with the communication channels that we have with mining pools.
[4:42 PM] Tron: 75% hasn't been easy, and requires some push with translated (localized) information.
[4:43 PM] Hans_Schmidt: The down side of having really decentralized mining
[4:43 PM] fdov: Hardforking without 80+ isn't nice to the other 20-25%...
[4:44 PM] Someone_2: It seems like previous forks were at 85% but it did brush into some obnoxiousness and absurdity trying to get the word out. 80% may be more practical but then you also have a bit more risk of conspiracy stuff erupting.
[4:45 PM] fdov: Just set a long timeout, and set the "notification time" after lock in before activation to more than 1 day.
[4:46 PM] Tron: Agreed. We can only count the blocks that are mined as a trigger for activation. All economic actors (exchanges, merchants, known users) should be notified in advance of the possibility of activation.
[4:47 PM] Tron: Most important are exchanges, swap sites, and merchants. Users (spenders) will not be hurt if the spend on the wrong chain. They update, and spend again.
[4:55 PM] fdov: I think we should consider the number of blocks in the retarget-period after lockin.
[4:58 PM] Tron: A longer cycle than 1 2016-block cycle?
[4:58 PM] fdov: Yes.
[4:59 PM] Tron: The cycles are inherited from bitcoin, but since the blocks are 10x faster, the lock-in to activation is 1.4 days instead of 14 days.
[4:59 PM] fdov: exactly.
[4:59 PM] Tron: Do we keep the 1.4 day counting cycle?
[4:59 PM] Tron: Or just add a 0 to the number of blocks for both, to make both 2 weeks.
[5:00 PM] Tron: 20160 blocks per cycle.
[5:00 PM] fdov: Add the 0 is easiest.
[5:00 PM] Hans_Schmidt: I agree. The current settings have never seemed appropriate to me. Add a 0 makes sense.
[5:01 PM] fdov: If we make that change, users of the old wallet will get notifications for 14 days after the count is finished, and the feature is locked-in. Before anything activates.
[5:02 PM] Hans_Schmidt: Exactly what we want
[5:02 PM] Tron: Ok.
[5:02 PM] fdov: If you are Big Exchange Inc. and ignore e-mail notification, releases on github, etc. - I hope you check logs, at least once every 14 days.
[5:03 PM] Hans_Schmidt: It also gives social media more time to hear the buzz and distribute the message
[5:04 PM] Tron: I'll start notifying exchanges and swap sites as soon as we have a signed release candidate for download.
[5:05 PM] Tron: Even before the possibility of activation begins.
[5:08 PM] fdov: The earliest time of activation will be about a month after counting starts, in this case. If the first count period hits the threshold.
[5:10 PM] Hans_Schmidt: I gotta run, so TTYL. It was a nice little mini-reunion.
[5:11 PM] fdov: yeah, long time. nice to see you. later.
[5:17 PM] fdov: @Tron PR with a merge of current develop to master created. #1119. If you review and approve, I suggest we ask @HyperPeek to merge it. He's got a routine to merge it cleanly without the "merge bla bla" messages in git history.
[5:17 PM] Tron: Nice. Thank you!
[5:19 PM] fdov: If you find the time, reviews of #1111, #1113, #1115 and #1118 should all be simple. Mostly manual backports from bitcoin with links to upstream changes.
[5:20 PM] fdov: Most of them close CVE issues.
[5:22 PM] fdov: Looks like that's it for today? I'll stick around in thenest and development for a while.
[5:28 PM] Tron: Thanks @fdov
Dev Meeting Transcript (November 12, 2021)[4:21 PM] kinkajou (SegWit Clique): Tron Channel open
[4:23 PM] Tron: Yay. Thanks for opening the channel.
[4:24 PM] kralverde {CULT OF JOE}: Sorry bout that did a backend overhaul and this slipped my mind
[4:26 PM] Tron: I don't have anything specific.
[4:26 PM] Tron: Ravencoin won the battle vs. AVAX run by Security Token Market. Thanks to everyone who voted.
[4:27 PM] Tron: The Ravencoin Meetup starts tomorrow.
[4:27 PM] Tron: It has been suggested that we do another one in Miami during blockchain week Jan 17 to 21st.
[4:28 PM] Tron: The Mayor of Miami is embracing crypto and making the week of the Bitcoin Conference into a blockchain week.
[4:29 PM] kinkajou (SegWit Clique): That sounds like a great idea
[5:06 PM] LSJI07 - BWS: Still open guys. Just a heads up thats it needs closing if done.
[5:09 PM] Blockchain John: Any code updates?
[5:22 PM] LSJI07 - BWS: Tron if you're still around
[5:45 PM] Someone_2: stillll open.
[5:47 PM] fdov: Current open PRs
https://github.com/RavenProject/Ravencoin/pulls[5:47 PM] fdov: Current develop git-history:
https://github.com/RavenProject/Ravencoin/tree/develop[5:49 PM] LSJI07 - BWS: Anyone can help test and make sure the code works are intended. Basic stuff as well as the more complicated stuff is all appreciated!
[5:52 PM] HyperPeek: I will finally work on the merge to develop over the weekend. After that we need to decide how to proceed with the release.
[5:53 PM] fdov: I made
https://github.com/fdoving/RavenStash/blob/main/testing-4.7.0test.md - to help with the testing. It's kind of my selection of things that should be tested before release.
[6:03 PM] fdov: There is also translations at
https://www.transifex.com/ravencoin/ - here you can help translate Electrum and Ravencoin Core.
Dev Meeting Transcript (November 19, 2021)[9:08 AM] Tron: I will not make it to the dev meeting this afternoon. I will catch up with it later. As always, email me at
[email protected] if you have questions.
[4:00 PM] kinkajou (SegWit Clique): Channel open.
[4:01 PM] fdov: Hello.
[4:01 PM] LSJI07 - BWS: Hi
[4:01 PM] Hedger: Hello
[4:02 PM] LSJI07 - BWS: What is the news on the release. Any progress?
[4:03 PM] fdov: Waiting for reviews of the current PRs. Some of them should be included imo. I made most of them, so I can't review and approve.
[4:04 PM] fdov: Once that part is done, I guess we just need to decide when to start counting for p2sh-asset activation. Update translations, tag and build binaries.
[4:06 PM] LSJI07 - BWS: Imo just aim for the end of the year. Give a month ish to get people swapped over.
[4:07 PM] LSJI07 - BWS: before the count starts.
[4:08 PM] LSJI07 - BWS: is the window revision set? 21600 or something else?
[4:08 PM] CallMeRichie: Hi all, Tron invited me today.
[4:08 PM] LSJI07 - BWS: 20160 apologies.
[4:09 PM] fdov: I made the PR for the change, yes. - waiting for reviews and approvals
[4:09 PM] LSJI07 - BWS: Greetings! CallMeRichie
[4:09 PM] fdov:
https://github.com/RavenProject/Ravencoin/pull/1124[4:09 PM] CallMeRichie: Thanks!
[4:14 PM] fdov: We probably need to have a discussion wrt. start counting time. Personally I would say minimum a month after release. If 1124 is approved, activation won't happen for about another month.
[4:16 PM] LSJI07 - BWS: 14 day voting window plus 14 day lockin period Im happy with as a minimum.
[4:17 PM] fdov: I also plan to try to copy bitcoins guix-build-system for us. That way we can build our own versions and compare signatures, much like gitian but better.
[4:19 PM] fdov: I'm working on that right now.
[4:22 PM] kinkajou (SegWit Clique): I'm assuming you also still need help with testing? Anything people reading this later might want/need to know in order to help with that?
[4:22 PM] fdov: Yes, of course.
[4:23 PM] Someone_2: What if you don't have a github account? And you're a lay person ?
[4:25 PM] fdov: Most of the testing tasks are simple, like install the newest binary (or build your own) and test one or more of the features. Comment something like "It started and the boxes worked as expected", nothing fancy needed . I'm pretty sure most of the features work. But it's nice to have more people verify before we make a release. Once I get like 3-ish confirms on each task I'm happy. Overview:
https://github.com/fdoving/RavenStash/blob/main/testing-4.7.0test.md[4:25 PM] Someone_2: (but a confident and seasoned lay person)
[4:26 PM] fdov: Someone_2 Well, All testing, even non documented testing, helps. Personally I would like comments on github. If you're a seasoned lay person you'll manage to make a github account.
[4:29 PM] fdov: If you for some reason do not want a github account, feedback from testing can be posten in ravenqt-sig-working - please @ me and link to the github-issue listed in
https://github.com/fdoving/RavenStash/blob/main/testing-4.7.0test.md for the feature you're testing. I will probably screenshot or copy your feedback and post it on github to document the testing.
[4:40 PM] CallMeRichie: Nice to meet everyone. I plan to go through your github projects to see if I can assist in any way. Gotta run!
[5:04 PM] kinkajou (SegWit Clique): I will close the channel shortly if there are no other questions for the core devs.
Dev Meeting Transcript (December 3, 2021)[4:00 PM] kinkajou (SegWit Clique): Channel open.
[4:00 PM] LSJI07 - BWS: HI
[4:00 PM] LSJI07 - BWS: Hi (speaking normally...)
[4:00 PM] kralverde {CULT OF JOE}:
[4:00 PM] fdov: Hello.
[4:00 PM] Tron: Hi
[4:01 PM] LSJI07 - BWS: i put together a list of items to discuss. not sure if people want to add things before we start in earnest.
[4:01 PM] LSJI07 - BWS: 1. Release date. When anticipated for P2SH and latest updates to GUI?
2. Testing P2SH and release v4.7test3 by fdov needs more testers specifically arm/osx/arch.
3. Testing P2SH I found that using the console is required. Propose adding GUI for P2SH multisig address creation (say 1 to 15 addresses only) and spending process to obtain partial hash to send to cosigners.
4. Ideally also need a demo or explanation (console or other) for multisig creation and making a transaction for the various assets. Be useful to those wanting to test and try the software.
#5
https://www.ravencoin.timeline.ovh/rvn-tokenisation-made-easy-for-any-business/ [4:02 PM] fdov: I don't think the "funding external projects part" has anything to do with development. Do that in a foundation meeting please.
[4:05 PM] Tron: Gut feel is that we don't start counting blocks until after the halvening.
[4:05 PM] Tron: Downloads can be available before then.
[4:07 PM] fdov: I was hoping to gather troops and make a release before years end. I have a lot of work until the holidays.
[4:07 PM] fdov: .. and it does not get much better once the holiday is over, for me anyway.
[4:08 PM] LSJI07 - BWS: So counting starts in beginning February essentially with releases hopefully ready by the end of december. Thats the plan at the moment anyway.
[4:08 PM] Tron: Sounds good.
[4:09 PM] kralverde {CULT OF JOE}: Yeah i can be a lot more active once the holidays come
[4:10 PM] LSJI07 - BWS: Number 1 is covered imo. Anyone wandering in late please feel free to comment!
[4:11 PM] LSJI07 - BWS: or later than me...im either 12 hours early or 12 hours late.... no half measures!
[4:11 PM] LSJI07 - BWS: 2. Testing P2SH and release v4.7test3 by fdov needs more testers specifically arm/osx/arch.
[4:12 PM] fdov: Great progress in the testing the last few days. Got some ✅ on my list.
[4:12 PM] kralverde {CULT OF JOE}: I can build on my pi, i think that would cover armv
[4:12 PM] kralverde {CULT OF JOE}: 7?
[4:12 PM] LSJI07 - BWS: This and #4 are kinda linked imo.
[4:12 PM] LSJI07 - BWS: 4. Ideally also need a demo or explanation (console or other) for multisig creation and making a transaction for the various assets. Be useful to those wanting to test and try the software.
[4:12 PM] fdov: @kralverde {CULT OF JOE} you don't have to build, you can just test the binaries. (or build if you want).
[4:12 PM] kralverde {CULT OF JOE}: Ill go the whole 9 yards
[4:13 PM] fdov: Would be nice if you also tested the binaries I made, check that my build-environment actually works.
[4:13 PM] RAVENCOIN.TIMELINE.OVH: #5
https://www.ravencoin.timeline.ovh/rvn-tokenisation-made-easy-for-any-business/[4:13 PM] LSJI07 - BWS: i have something for console and making the P2SH addresses. spending from that address I need help with though!
[4:14 PM] kralverde {CULT OF JOE}: I wanna try and stick in torv3 support before release too
[4:14 PM] Hans_Schmidt: It would be good if someone (in addition to the tests I did) could test asset atomic transfers using P2SH
[4:14 PM] kralverde {CULT OF JOE}: Yessir
[4:14 PM] kralverde {CULT OF JOE}: Could you link your run downs regarding that again?
[4:15 PM] fdov: We could try, but I suggest releasing without torv3 first. THen make a .1 with torv3 pretty quickly after.
[4:17 PM] LSJI07 - BWS: This is what i did for making a multisig address and documented etc.
Creating a multi-signature address with Ravencoin QT 4.7.
A 2-of-3 multisig address can be created by following these steps:
1. Gather (or generate) 3 ravencoin addresses, on whichever machines will be participating, using getnewaddress or getaccountaddress RPC commands (or copy and paste from the GUI).
2. Get their public keys using the validateaddress RPC command for each address or using getaddressinfo and copying the pubkey value.
3. Then create a 2-of-3 multisig address using addmultisigaddress; e.g.,
ravend addmultisigaddress 2 '["044322868cb17d64dcc22185ae2d4493111d73244c3668f8ac79ecc79c0ba8d30a6756d0fa20157 709af3281cc721c7f53321a8cabda29b77900b7e4fe0174b114","..second pubkey..","..third pubkey.."]'
4. addmultisigaddress returns the multi-signature address. Be a little careful, the public keys are raw hexadecimal and don't contain checksums like ravencoin addresses do. You can then send funds into that 2-of-3 transaction using the normal sendtoaddress/sendmany RPC commands, or the GUI (or anything that's been updated to recognize multisig addresses).
[4:17 PM] fdov: I pretty much want the release to be close to test3 - without much code change. - If we make it and feel good about it, I can change my mind.
[4:18 PM] Hans_Schmidt: Every contribution is welcome of course. But rushing in a tor update seems risky to me in light of all the other things already in there which could use more testing.
[4:18 PM] kralverde {CULT OF JOE}: Ill work on a pr but leave it on the backburner
[4:19 PM] LSJI07 - BWS: I need help with how a user can send from a multisig on RVN using assets. rawtransactions are fun!
[4:19 PM] Tron: If the Tor update doesn't impact consensus, it can be added later and without a hard fork.
[4:19 PM] kralverde {CULT OF JOE}:
https://hans-schmidt.github.io/mastering_ravencoin/analysis/HTLC_P2SH_Cross-Chain_Atomic_Swaps_RVN-Assets_With_BTC.html @Hans_Schmidt this is still your latest work correct?
[4:20 PM] fdov: FYI: I'm working on gitian building, to be able to make deterministic builds, like bitcoin did. (they switched to guix). - PR is in the list as a draft. It builds and works, but only deterministic for OSX. I have not had the time to figure out why.
[4:20 PM] fdov: It does not.
[4:21 PM] Hans_Schmidt: Yes, for P2SH asset atomic swaps. It is tedious, but should provide an outline to follow for more testing.
[4:22 PM] kralverde {CULT OF JOE}: Awesome
[4:22 PM] LSJI07 - BWS: @kralverde {CULT OF JOE}@Hans_Schmidt awesome, thanks for linking!
[4:22 PM] LSJI07 - BWS: and making!
[4:23 PM] Tron: Thank you everyone for helping on this release.
[4:27 PM] LSJI07 - BWS: Item 2 done - WE NEED MORE COMMUNITY TESTERS FOR ARM/OSX/ARCH. Please.
[4:27 PM] Tron: I can put a call out on Twitter.
[4:28 PM] fdov: I found that crying on discord helps.
[4:28 PM] LSJI07 - BWS: Item 3. Testing P2SH I found that using the console is required. Propose adding GUI for P2SH multisig address creation (say 1 to 15 addresses only) and spending process to obtain partial hash to send to cosigners. Any objections to this or ideas to help?
[4:29 PM] LSJI07 - BWS: this may help if we consider adding hardware wallet support later...
[4:30 PM] LSJI07 - BWS: something simple like
https://coinb.in/#newMultiSig for creating a p2sh address in wallet.
[4:31 PM] kralverde {CULT OF JOE}: That might be another thing to put in 7.1
[4:31 PM] kralverde {CULT OF JOE}: Though if its just a gui, it should be trivial…
[4:32 PM] kralverde {CULT OF JOE}: Ill take a look over the holidays
[4:33 PM] LSJI07 - BWS: its not concensus related after the p2sh fork is done. Imo it would help people using the wallet and personally use a multisig in the QT wallet .
[4:33 PM] LSJI07 - BWS: I'll make an issue and see if anyone wants the challenge.
[4:34 PM] fdov: Should not be hard.
[4:34 PM] kralverde {CULT OF JOE}: I’ll just copy whatever electrum does gui wise
[4:35 PM] Hans_Schmidt: Testing on each OS is necessary to verify binary generation and dependencies. But I have never seen an alternate-OS functionality problem which risks the chain. Would you agree with that?
[4:36 PM] LSJI07 - BWS: Careful. I looked quickly and to me it looked like they created a seperate seed for multisig addresses. I liked the gui though.
[4:36 PM] fdov: No, It is just to make sure binaries we release actually work.
[4:37 PM] LSJI07 - BWS: I have seen more user errors and not specifically OS issues....just saying....
[4:37 PM] fdov: OSX is usually the worst.
[4:37 PM] LSJI07 - BWS: Item 3 done. I'll create an issue.
[4:38 PM] fdov: I have to take a ~20min break in 10 minutes.
[4:38 PM] LSJI07 - BWS: Item 4 was covered earlier.
[4:38 PM] LSJI07 - BWS: Item #5
https://www.ravencoin.timeline.ovh/rvn-tokenisation-made-easy-for-any-business/[4:39 PM] LSJI07 - BWS: i have not looked at this yet.
[4:39 PM] Hans_Schmidt: Not surprisingly, stuff worst best on the platforms which the devs mostly use.
[4:42 PM] LSJI07 - BWS: This looks like a request list for layer 2 development. Somethings mentioned can only be done by a business. Like sign ins and banking links etc etc.
[4:44 PM] fdov: I like the idea. I guess it's much like Mango isn't it?
[4:45 PM] LSJI07 - BWS: looks like a skinnable mango but the banking connections centralised around a "onramp/offramp" for want of better words.
[4:46 PM] fdov: But the request is someone makes it and share it for free to anyone on github.
[4:47 PM] Tron: Mango can be whitelabeled, but it isn't free.
[4:47 PM] mattan138: If QT essentially looked like this they'd be set for the most part.
[4:50 PM] fdov: Personally I want to focus on core+qt. And I would prefer if the foundation directs most of its attention to the core development. The core is Ravencoin. If that somehow breaks, all L2s die with it.
[4:50 PM] kinkajou (SegWit Clique): Is there a reason we don't include an IPFS viewer in the QT just for the asset creation part? to verify that you have the correct hash if nothing else?
[4:50 PM] kinkajou (SegWit Clique): so when you check to see if the asset name is available youre also able to verify your ipfs hash
[4:52 PM] fdov: We can make a button to open it in the default browser with the configured web-viewer. But including a viewer into core, is not something I (and i think Hans) want at all. It will introduce all sorts of potential security issues.
[4:52 PM] Blockchain John: Is there any company being built on Ravencoin to help secure and protect Intellectual Property?
[4:52 PM] Blockchain John: Question: is P2SH estimated to forked into the chain in 2023? Here's the code that makes me think that.....
LINE 165 consensus.vDeployments[Consensus::DEPLOYMENT_P2SH_ASSETS].nStartTime = 1682956800; // UTC: Mon Mai 01 2023 18:00:00
https://github.com/fdoving/Ravencoin/commit/04eba4fd84eddea5268a2d213d92e9e4a90e7117#diff-ff53e63501a5e89fd650b378c9708274df8ad5d38fcffa6c64be417c4d438b6dL165[4:53 PM] fdov: No. This is just set to something that will never happen, for it not to activate by accident.
[4:53 PM] LSJI07 - BWS: @Blockchain John it was likely just moved far into the future... while testing other features.
[4:53 PM] Hans_Schmidt: Viewers are a main source of security vulnerability for many applications. An ability to chose an external viewer after you click a box verifying that you understand the risks would be more acceptalbe.
[4:53 PM] Blockchain John: Ahh ok. Perfect.
[4:54 PM] kinkajou (SegWit Clique): Right, I agree with that. A button would be nice so that you can view the content externally during creation much the same way that you can view it from your asset balance.
[4:54 PM] kralverde {CULT OF JOE}: yes, electrum has their own mnemonic system
[4:54 PM] kralverde {CULT OF JOE}: some may say its better than bip39, but...
[4:55 PM] kralverde {CULT OF JOE}: the rest is the same
[4:55 PM] Blockchain John: How can I become a Ravencoin IPFS Node host? From what I understand there is a script not that scans Assets and NFTs minted on RAVENCOIN. and the IPFS is pinned automatically by s community of volunteers
[4:55 PM] LSJI07 - BWS: raise an issue and if a dev wants to help ravencoin they can add it.
[4:57 PM] Blockchain John: There's been a concern from the community that some pools are getting to large and causing issues in the network. There's been a recent delay of 8 minutes with no blocks being discovered. Which was said to be due to mining pool manipulating the network. We definitely need more pools if this is the problem.
[4:57 PM] Tron:
https://github.com/RavenProject/Ravencoin/blob/master/assets/tools/ipfs_pinner.py[4:57 PM] Blockchain John: Thank you
[4:58 PM] LSJI07 - BWS: has anyone got it to work? not being cheeky. I have failed several times on windows and linux.
[5:00 PM] LSJI07 - BWS: tried qt and ravend. ipfs node fails to connect.
[5:00 PM] Blockchain John: Ruh roh.
[5:01 PM] LSJI07 - BWS: zmq running. with assetindex=1 and txindex=1
[5:01 PM] LSJI07 - BWS: and server=1
[5:01 PM] kralverde {CULT OF JOE}: and a ipfs node running
?
[5:01 PM] LSJI07 - BWS: lol
[5:01 PM] LSJI07 - BWS: yes.
[5:02 PM] kralverde {CULT OF JOE}: it seems like it would work to me, what was the error you had?
[5:02 PM] Hans_Schmidt: We did already do PR#901 Configurable IPFS Browser url, which defaults to
https://ipfs.io/ipfs/[5:02 PM] Tron: RPC user and pwd?
[5:03 PM] LSJI07 - BWS: yes. i got annoyed and set it to default even to try it. i use rpc for mining on testnet and that works fine.
[5:03 PM] Blockchain John: Last question: I'm looking for the option to pull transactions from my address. I'm not about to take QT with me as it's on my computer. But I would like to know what transaction as occuring on my address. How can I pull an API
[5:04 PM] kralverde {CULT OF JOE}: that would be an open rpc from the node
[5:04 PM] kralverde {CULT OF JOE}: or 3rd parties like rvn.cryptoscope.io
[5:04 PM] Blockchain John: Thanks
[5:06 PM] LSJI07 - BWS: some of the ipfsapi stuff is deprecated in the script. if someone has it working just say so, and ill be quiet and re figure my stuff out. thumbs up if you have it working please.
[5:09 PM] LSJI07 - BWS: I have to get off but appreciate all of your efforts in this community! Thank you!
[5:09 PM] fdov: We can extend that to a button in the Create Assets-view, the button can be activated around here:
https://github.com/RavenProject/Ravencoin/blob/392b2becb286de0f5fd61ac84a5f2561d2460527/src/qt/createassetdialog.cpp#L515[5:10 PM] fdov: Once a good hash is found, the button activates. On button presse, we ask the user with a popup if she wants to open this url in the browser.
[5:12 PM] Tron: I like it. It would be nice to have a check box or option to "Don't ask me again.". Basically a one time warning.
[5:12 PM] fdov: More work. But I agree.
[5:13 PM] kinkajou (SegWit Clique): Love it. So long as it doesn't prevent users from minting in the event no one has pinned the file.
[5:14 PM] fdov: It will basically just open the browser at a url.
[5:14 PM] kralverde {CULT OF JOE}: the issue with that is ipfs propogation time
[5:14 PM] kralverde {CULT OF JOE}: nlogn time and all that
[5:14 PM] kralverde {CULT OF JOE}: there should be an override for the button enabling
[5:15 PM] fdov: That will be the users problem.
[5:15 PM] kralverde {CULT OF JOE}: lol
[5:15 PM] kralverde {CULT OF JOE}: okay
[5:15 PM] fdov: Don't you think?
[5:15 PM] kralverde {CULT OF JOE}: your saying the button will only activate if a public gateway gets the hash right?
[5:16 PM] kralverde {CULT OF JOE}: actually
[5:16 PM] kralverde {CULT OF JOE}: yeah user problem
[5:16 PM] fdov: No, it checks for Qm and 46 chars.
[5:16 PM] kralverde {CULT OF JOE}: okay i see
[5:16 PM] kralverde {CULT OF JOE}: i was unsure of what "good hash" meant
[5:16 PM] kralverde {CULT OF JOE}: shoulda asked
[5:17 PM] Tron: We don't want the client checking for existence against server. Just letting them click to open the browser (with a warning).
[5:17 PM] fdov: I was planning on using the sanity-check already used to activate the Create Asset button.
[5:19 PM] fdov: But I guess this is a level of detail out of the scope of this meeting. Should continue indevelopment or ravenqt-sig-working
[5:21 PM] Hans_Schmidt: I think this makes sense as an extension to what we already did in PR#901. And browsers make good viewers because they have already evolved into security sandboxes.
[5:27 PM] Nonprophete: Didn't see it answered, but may have missed it. What is the ETA for the P2SH hardfork?
[5:29 PM] fdov: @Nonprophete Hope to release before years end, start counting after halving, early feb, active around march if pools upgrade.
[5:30 PM] fdov: @LSJI07 - BWS Are we finished?
[5:32 PM] BadGuyTy: I came late but didn't see it mentioned did you get your help with raw transactions @LSJI07 - BWS ?
[5:33 PM] BadGuyTy: I would also like an ETA for the hardfork. I have all but decided that is going to be a requirement for squawker usability.
[5:36 PM] BadGuyTy: I'm being dumb... I'll just move to test net where it is already active with the disclaimer that nothing we do there will be carried over...
[5:38 PM] kinkajou (SegWit Clique): Just answered, expected in Feburary-March but ultimately depends on the pools/miners
[5:39 PM] kinkajou (SegWit Clique): If there are no other questions/issues for the core devs I will close the channel shortly.
Dev Meeting Transcript (December 10, 2021)[3:51 PM] kralverde {CULT OF JOE}: Channel is open
[3:58 PM] kralverde {CULT OF JOE}: Can confirm the latest dev branch builds on arm7l
[4:02 PM] Tron: I have invited folks from Twitter to help test. Could you post a link to information on testing?
[4:03 PM] kinkajou (SegWit Clique):
https://github.com/fdoving/RavenStash/blob/main/testing-4.7.0test.md[4:04 PM] Tron: Thank you.
[4:08 PM] kralverde {CULT OF JOE}: was it @LSJI07 - BWS who had the testing online meetup?
[4:08 PM] kinkajou (SegWit Clique): Yes, only two of us attended though sadly
[4:08 PM] kralverde {CULT OF JOE}: As I understand we need to look at restricted assets for p2sh and watch only addresses with assets
[4:09 PM] kinkajou (SegWit Clique): And I of course didn't have a mic so poor LSJ just talking to himself
[4:09 PM] kinkajou (SegWit Clique): Yes I experienced issues specifically with tagging P2SH addresses and sending the associated restricted asset.
[4:09 PM] Sevvy //: I borked my testnet instance on my windows machine trying to transplant my chainstate data to an ubuntu rig
[4:09 PM] Sevvy //:
[4:10 PM] kinkajou (SegWit Clique): Was not able to get 'Watch only' in the GUI for P2SH or P2PKH Asset Balances though RVN balances display correctly
[4:10 PM] Sevvy //: I was the one who kind of compelled LSJ to even schedule the testing session
[4:12 PM] kinkajou (SegWit Clique): Also AFAIK none of us have successfully sent assets from a P2SH address yet either. More GUI support would be nice.
[4:13 PM] Sevvy //: yeah
[4:13 PM] kralverde {CULT OF JOE}: at least the basic unlocking script right?
[4:13 PM] kinkajou (SegWit Clique): @LSJI07 - BWS opened a dedicated issue and bounty for that here:
https://github.com/RavenProject/Ravencoin/issues/1142[4:14 PM] kralverde {CULT OF JOE}: for multisig or p2sh?
[4:14 PM] kinkajou (SegWit Clique): multisig is p2sh
[4:15 PM] kralverde {CULT OF JOE}: its an application of p2sh
[4:16 PM] kralverde {CULT OF JOE}: p2sh is kind of similar to a smart contract....
[4:16 PM] kralverde {CULT OF JOE}: kinda
[4:16 PM] kralverde {CULT OF JOE}: not really
[4:16 PM] kralverde {CULT OF JOE}: its just a more options locking script
[4:16 PM] kinkajou (SegWit Clique): the issue is specific to GUI support for multisig p2sh
[4:16 PM] kralverde {CULT OF JOE}: Yeah
[4:16 PM] kralverde {CULT OF JOE}: I added it to my list
[4:16 PM] Sevvy //: neat
[4:16 PM] kralverde {CULT OF JOE}: of stuff to do on holiday
[4:17 PM] kinkajou (SegWit Clique): multisig is the p2sh application I have been testing as well
[4:17 PM] kralverde {CULT OF JOE}: cool beans
[4:19 PM] kinkajou (SegWit Clique):
https://github.com/RavenProject/Ravencoin/issues/990#issuecomment-989151364 is particularly deserving of attention though, IMO. I would expect restricted assets to be one of the more common applications for multisig p2sh so ensuring it works properly is crucial.
[4:19 PM] Sevvy //: agreed
[4:20 PM] kralverde {CULT OF JOE}: yeah, right now we just gotta try to break stuff in the testnet and add issues on gh
[4:23 PM] Hans_Schmidt: It can be confusing because there is a CHECKMULTISIG opcode which can be used on RVN just as on BTC to do "standard" multisig. But it's limited to 3 signatures and it results in a large transaction, so most multisigs are actually done using P2SH.
[4:25 PM] Sevvy //: hmmm, didn't know that
[4:29 PM] Hans_Schmidt: I want to acknowledge that there have been a few other small bugs which have been reported in the channels not related to P2SH. It takes time to reproduce, diagnose, and fix these things. But they will eventually be resolved, so it's worth thanking those people who put effort into reporting them and opening github issues when possible.
[4:31 PM] LSJI07 - BWS: the struggle has been the only way to spend from a multisig is via createrawtransaction and very few understand it imo to write a guide on how to do it WITH assets. ill have a go but its gonna take awhile.
[4:34 PM] LSJI07 - BWS: using the gui with a multisig address in the wallet and all the private keys it works to send assets. we tried issuing all the asset types into a multisig address and the sending from that address using the gui. That is obviously not how its meant to be used so kinda irrelevant other than its worth noting as interesting on the positive side.
[4:37 PM] kinkajou (SegWit Clique): This is actually not working for me
[4:37 PM] LSJI07 - BWS: just tags though correct?
[4:37 PM] kinkajou (SegWit Clique): When trying to send out from a multisig address and I select the asset on the dropdown menu it disappears immediately after being selected.
[4:38 PM] Jeroz: I saw the tweet. Do all points at
https://github.com/fdoving/RavenStash/blob/main/testing-4.7.0test.md need testing on MacOS? Or only specific ones? "Test OSX binaries on various versions of OSX" is rather vague and broad.
[4:38 PM] kinkajou (SegWit Clique): Nope seems to apply to main assets as well at least when using the GUI. I'm specifically talking about sending an asset FROM a multisig address.
[4:38 PM] Sevvy //: holy shrimp Jeroz is here
[4:39 PM] kralverde {CULT OF JOE}: eyy jeroz is back
[4:39 PM] kralverde {CULT OF JOE}: afaik little testing has been done on mac/osx in general
[4:39 PM] Someone_2: I just noticed his pic.
[4:40 PM] kinkajou (SegWit Clique): I think it'd be prudent to test all of the new features on each OS at least once to ensure they work.
[4:40 PM] kralverde {CULT OF JOE}: that would suck
[4:40 PM] Jeroz: I have Bug Sur (11.6) and Mojave (10.14) in a virtual box.
[4:41 PM] kralverde {CULT OF JOE}: @fdov do you know what needs to be done with respect to MacOS/OSX?
[4:41 PM] Tron: These tests should show how to use p2sh and multisig for assets.
https://github.com/RavenProject/Ravencoin/blob/develop/test/functional/feature_assets_p2sh.py[4:41 PM] kinkajou (SegWit Clique): I've just tested this again during the meeting and it's working now lol @LSJI07 - BWS
[4:42 PM] LSJI07 - BWS: i was firing up my testnet node to double check!
[4:42 PM] kinkajou (SegWit Clique): Yeah I tried it before posting that and got the error described but now its working.
[4:46 PM] LSJI07 - BWS: i had a few anomalies I will detail as separate issues. on creating qualifiers and sub qualifiers that the gui was different for the various asset types. just to keep them to the same process. the # was required for creating qualifier types of assets however the prefix was not required for the rest of the asset types. It was already automated in them i think.
[4:46 PM] RAVENCOIN.TIMELINE.OVH: I can do some testing on OSX latest version
[4:47 PM] kinkajou (SegWit Clique): Right. Might be because restricted assets share the same name as the main asset theyre associated with whereas qualifier strings can have unique names
[4:48 PM] kinkajou (SegWit Clique): But having that # added to the prefix initially would help to prevent some user confusion IMO. It got me the first time as well
[4:51 PM] Hans_Schmidt: I have noticed similar oddities on occasion. The implementation is not consistent nor the same as the documentation.
[4:55 PM] Tron: These are issues related to the speed of development at the time. They can be fixed, but we should publish some notes for any changes that are not backwards compatible, or could break existing RPC calls.
[4:57 PM] Tron: Also the lesser used features (tagging, etc) didn't get as much user testing.
[5:09 PM] LSJI07 - BWS: I see the test and see familiar console commands etc but its python and not english. Creating the multi sig is doable in console. Spending is ahem fun for me at the moment... Ill have a go at using it though in console and report back if i get seriously stuck and create something a bit more user friendly.
[5:12 PM] LSJI07 - BWS: On a side note the new gui screen for wallet creation are much better. I recently installed an atomic dex komodo wallet and a good feature they had was forcing the user to select a specific random seed word (or two) to ensure the user had recorded it correctly before letting them through...seems good practice for a future improvement perhaps.
[5:13 PM] kinkajou (SegWit Clique): exodus wallet does this too. I agree it encourages safe habits. no harm in creating an issue in case someone wants to pick it up
[moderator's note: consecutive posts merged]
Ravencoin (RVN)
