[ANN][BMR] Bitmonero - a new coin based on CryptoNote technology - LAUNCHED - page 16.

the_darkness

member

Activity: 79

Merit: 10

Quote from: eizh on April 19, 2014, 04:42:37 PM

Quote from: thankful_for_today on April 19, 2014, 04:40:12 PM

Quote from: eizh on April 19, 2014, 04:23:47 PM

You changed a lot of the code. What are the consequences? Previously the tx's were sorted more thoroughly.

2 changed files with 14 additions and 47 deletions. I hope that nothing bad can happen. But we have to be careful Wink

I wasn't implying the changes were dangerous, but I was wondering how mining fees changed quantitatively (I think that's what the removed code affects?).

I happened to just find a block and it looks to be about the same amount as previously (~17.5 BMR).

eizh

hero member

Activity: 560

Merit: 500

Quote from: thankful_for_today on April 19, 2014, 04:40:12 PM

Quote from: eizh on April 19, 2014, 04:23:47 PM

You changed a lot of the code. What are the consequences? Previously the tx's were sorted more thoroughly.

2 changed files with 14 additions and 47 deletions. I hope that nothing bad can happen. But we have to be careful Wink

I wasn't implying the changes were dangerous, but I was wondering how mining fees changed quantitatively (I think that's what the removed code affects?).

sussex

hero member

Activity: 658

Merit: 500

OK, prolly nothing, but I now have a sea of red complaining about found future peerlist all for the same IP..... it has complained about this six times in the last ten minutes.

On the upside, I found a block !!!!

thankful_for_today

full member

Activity: 126

Merit: 101

Quote from: eizh on April 19, 2014, 04:23:47 PM

You changed a lot of the code. What are the consequences? Previously the tx's were sorted more thoroughly.

2 changed files with 14 additions and 47 deletions. I hope that nothing bad can happen. But we have to be careful Wink

thankful_for_today

full member

Activity: 126

Merit: 101

Quote from: smooth on April 19, 2014, 04:11:13 PM

Quote from: sussex on April 19, 2014, 04:08:58 PM

Quote from: thankful_for_today on April 19, 2014, 04:04:54 PM

Quote from: eizh on April 19, 2014, 03:57:10 PM

It's up on git. Can someone compile the Windows binary?

Please see my comments below: patch wasn't tested properly. It's better to stay 1-2 days with some node not patched. This will help in case of problems with this patch.

The absense of this patch doesn't influence miner's income in most cases.

Sorry, I'm confused, can we continue mining with the wallet and bitmonerod from yesterday?

Yes, you can.

The problem with the block chain being stalled was caused by no one having the patch. As long as some nodes have the patch, everyone else can continue using the old code.

I confirm this is correct.

eizh

hero member

Activity: 560

Merit: 500

You changed a lot of the code. What are the consequences? Previously the tx's were sorted more thoroughly.

the_darkness

member

Activity: 79

Merit: 10

Quote from: thankful_for_today on April 19, 2014, 04:18:36 PM

Quote from: eizh on April 19, 2014, 03:59:15 PM

Quote from: thankful_for_today on April 19, 2014, 03:22:13 PM

The problem is in block generation code. In one of last updates in Bytecoin there was a bug introduced: it calculates extra-size penalty the wrong way. As a result we see that a mined block isn't accepted by the network. I will consume the big transaction now into correct block. As soon as network accepts this block I will release new mining code to git.

Here is the tx that caused the problem:

id:
blob_size: 20534

Does BCN still possess this issue?

Probably yes, but it doesn't influences network operations as much as in BMR. Why? I suppose that there is a number of BCN nodes using old or very old mining code. This bug has been introduced a week or two ago and BMR has been started from last snapshoot of BCN code and we met this problem.

This way there is no real problem with BCN even with a bug in last commits. But I've sent them an e-mail.

Just wanted to say good job on a quick recovery and sorting out what sounds like a tricky problem.

thankful_for_today

full member

Activity: 126

Merit: 101

Quote from: eizh on April 19, 2014, 03:59:15 PM

Quote from: thankful_for_today on April 19, 2014, 03:22:13 PM

The problem is in block generation code. In one of last updates in Bytecoin there was a bug introduced: it calculates extra-size penalty the wrong way. As a result we see that a mined block isn't accepted by the network. I will consume the big transaction now into correct block. As soon as network accepts this block I will release new mining code to git.

Here is the tx that caused the problem:

id:
blob_size: 20534

Does BCN still possess this issue?

Probably yes, but it doesn't influences network operations as much as in BMR. Why? I suppose that there is a number of BCN nodes using old or very old mining code. This bug has been introduced a week or two ago and BMR has been started from last snapshoot of BCN code and we met this problem.

This way there is no real problem with BCN even with a bug in last commits. But I've sent them an e-mail.

smooth

legendary

Activity: 2968

Merit: 1198

Quote from: sussex on April 19, 2014, 04:08:58 PM

Quote from: thankful_for_today on April 19, 2014, 04:04:54 PM

Quote from: eizh on April 19, 2014, 03:57:10 PM

It's up on git. Can someone compile the Windows binary?

Please see my comments below: patch wasn't tested properly. It's better to stay 1-2 days with some node not patched. This will help in case of problems with this patch.

The absense of this patch doesn't influence miner's income in most cases.

Sorry, I'm confused, can we continue mining with the wallet and bitmonerod from yesterday?

Yes, you can.

The problem with the block chain being stalled was caused by no one having the patch. As long as some nodes have the patch, everyone else can continue using the old code.

eizh

hero member

Activity: 560

Merit: 500

Quote from: sussex on April 19, 2014, 04:08:58 PM

Quote from: thankful_for_today on April 19, 2014, 04:04:54 PM

Quote from: eizh on April 19, 2014, 03:57:10 PM

It's up on git. Can someone compile the Windows binary?

Please see my comments below: patch wasn't tested properly. It's better to stay 1-2 days with some node not patched. This will help in case of problems with this patch.

The absense of this patch doesn't influence miner's income in most cases.

Sorry, I'm confused, can we continue mining with the wallet and bitmonerod from yesterday?

The tx that was causing the problem has been accepted into a block, so yes you can keep using yesterday's version.

sussex

hero member

Activity: 658

Merit: 500

Quote from: thankful_for_today on April 19, 2014, 04:04:54 PM

Quote from: eizh on April 19, 2014, 03:57:10 PM

It's up on git. Can someone compile the Windows binary?

Please see my comments below: patch wasn't tested properly. It's better to stay 1-2 days with some node not patched. This will help in case of problems with this patch.

The absense of this patch doesn't influence miner's income in most cases.

Sorry, I'm confused, can we continue mining with the wallet and bitmonerod from yesterday?

thankful_for_today

full member

Activity: 126

Merit: 101

Quote from: eizh on April 19, 2014, 03:57:10 PM

It's up on git. Can someone compile the Windows binary?

Please see my comments below: patch wasn't tested properly. It's better to stay 1-2 days with some node not patched. This will help in case of problems with this patch.

The absense of this patch doesn't influence miner's income in most cases.

thankful_for_today

full member

Activity: 126

Merit: 101

Quote from: thankful_for_today on April 19, 2014, 03:47:07 PM

Looks like it's fixed now. Big tx gone into blockchain. You can see blocks in the network at normal speed.

1. Sorry for inconvenience.

2. I'll post about git changes soon.

Git updated. BUT: I don't recomment to update all nodes now due to following reasons:

- this patch isn't tested properly (=> can cause some other unknown problems)
- network operates normally without this patch (it doesn't change any protocol logic)

Let's wait 1-2 days before updating all nodes. Old code works the right way in most cases except transactions bigger than 20Kb.
In case such big (>20Kb) transaction will appear again it will be included by patched nodes and this will not influence network very much.

eizh

hero member

Activity: 560

Merit: 500

Quote from: thankful_for_today on April 19, 2014, 03:22:13 PM

The problem is in block generation code. In one of last updates in Bytecoin there was a bug introduced: it calculates extra-size penalty the wrong way. As a result we see that a mined block isn't accepted by the network. I will consume the big transaction now into correct block. As soon as network accepts this block I will release new mining code to git.

Here is the tx that caused the problem:

id:
blob_size: 20534

Does BCN still possess this issue?

x0rcist

full member

Activity: 238

Merit: 100

Quote from: thankful_for_today on April 19, 2014, 03:47:58 PM

Quote from: tacotime on April 19, 2014, 03:43:59 PM

Quote from: thankful_for_today on April 19, 2014, 03:22:13 PM

The problem is in block generation code. In one of last updates in Bytecoin there was a bug introduced: it calculates extra-size penalty the wrong way. As a result we see that a mined block isn't accepted by the network. I will consume the big transaction now into correct block. As soon as network accepts this block I will release new mining code to git.

Here is the tx that caused the problem:

id:
blob_size: 20534

Funnily this is my tx

Hope to see the commit soon!

edit: looks like your patch worked, as the tx now exists in the main chain.

Thank you for this problem. This is the way software becomes better.

Thank you for fixing it. But also, come join us on freenode.
We where just discussing this tx bug before you got back Wink

eizh

hero member

Activity: 560

Merit: 500

It's up on git. Can someone compile the Windows binary?

thankful_for_today

full member

Activity: 126

Merit: 101

Quote from: tacotime on April 19, 2014, 03:43:59 PM

Quote from: thankful_for_today on April 19, 2014, 03:22:13 PM

The problem is in block generation code. In one of last updates in Bytecoin there was a bug introduced: it calculates extra-size penalty the wrong way. As a result we see that a mined block isn't accepted by the network. I will consume the big transaction now into correct block. As soon as network accepts this block I will release new mining code to git.

Here is the tx that caused the problem:

id:
blob_size: 20534

Funnily this is my tx

Hope to see the commit soon!

edit: looks like your patch worked, as the tx now exists in the main chain.

Thank you for this problem. This is the way software becomes better.

thankful_for_today

full member

Activity: 126

Merit: 101

Looks like it's fixed now. Big tx gone into blockchain. You can see blocks in the network at normal speed.

1. Sorry for inconvenience.

2. I'll post about git changes soon.

eizh

hero member

Activity: 560

Merit: 500

Quote from: tacotime on April 19, 2014, 03:43:59 PM

Quote from: thankful_for_today on April 19, 2014, 03:22:13 PM

The problem is in block generation code. In one of last updates in Bytecoin there was a bug introduced: it calculates extra-size penalty the wrong way. As a result we see that a mined block isn't accepted by the network. I will consume the big transaction now into correct block. As soon as network accepts this block I will release new mining code to git.

Here is the tx that caused the problem:

id:
blob_size: 20534

Funnily this is my tx

Hope to see the commit soon!

First notable event in the history of BMR.

tacotime

legendary

Activity: 1484

Merit: 1005

Quote from: thankful_for_today on April 19, 2014, 03:22:13 PM

The problem is in block generation code. In one of last updates in Bytecoin there was a bug introduced: it calculates extra-size penalty the wrong way. As a result we see that a mined block isn't accepted by the network. I will consume the big transaction now into correct block. As soon as network accepts this block I will release new mining code to git.

Here is the tx that caused the problem:

id:
blob_size: 20534

Funnily this is my tx

Hope to see the commit soon!

edit: looks like your patch worked, as the tx now exists in the main chain.

Topic: [ANN][BMR] Bitmonero - a new coin based on CryptoNote technology - LAUNCHED - page 16. (Read 68802 times)