i was complaining
now it is tithing almost max, but it is creating very small new piles when tithing, i have there many 0.5-1.5 bbp piles
yesterday still only about every second tithe was counted in payout
there are still 0/offline txs
will see
I'm not programmer and I don't how to read most of the code... but I'm going to guess that when you check PoG Tithe? you have value that can tithe, but when it is added as tx to next block, PoG difficulty went up slightly. So, now, your max tithe is "illegal" in the next block. Even if I tithe manually max tithe and use InstantSend, maybe we still run into this issue. I rather submit smaller auto tithe (like 90% of max tithe) than not have it accepted.
No thats not it - thats the first thing I designed into POG (as a requirement).
The difficulty level is actually set 4 blocks prior, and is good for 4 blocks. So lets say we are working on block 100,000:
Diff is 2000; max tithe amount is 9.50.
In blocks 100,000 through 100,001 we honor tithes up to 9.50.
So thats not the reason for inducting an illegal tithe.
I thought it was simply .01 rounding when looking at 50 the other night (hence the reason we made the miner go down by .01 bbp in 1193). But I do see today, in my personal tithing history over the last 205 blocks, I tithed by about .03 bbp too much (I have 30% bad tithes, 70% good tithes). Note that fortunately since the pog pool pays out 90K~ or so per day everyone is still profitable in this playground.
But yes, we will get to the bottom of this to see why we have 30-50% illegal going into the report.
Looking at my report, it appears 90% of my errors are Legal=-3 (tithe_too_high) - this is the lions share of the problem. The other 2 small issues we can deal with later.
Let me take a look at the blocks and see what could be causing this client to send out a tx that is .03 bbp too much. One thing we should add to this report is the actual tithe parameters for the block next to the error- ill do that now.
EDIT 2: On Capulos issue, bbp creating tiny < 1 bbp new pog denoms, that is actually not really a bug, I think its just a labeling issue. When you receive change for a 9.50 tithe that came from a 10,000 bbp coin, we are sending the .6905 bbp back to "TITHES" and the 9900.0010 back to "change". We really should send the TITHES change back to TITHES - but in the mean time this means you are getting the correct pog denoms back and they are working. Another words we are just left with a nuisance of a lot of change that we need to consolidate manually once every couple of weeks. This is another thing we could automate later ( we could say, exec consolidate, and it makes everything less than 1 bbp into one banknote for you automatically).