IMHO some things should remain a mystery
Satoshi legend is one of them
also I don't think it will ever happen,most likely Satoshi is a group of people (same as Shakespeare and many others)
that emerge every now and then to introduce some groundbreaking cultural or technical inventions and to move the progress forward
as for the effects of him(them?) revealing himself I can see only negatives: possible huge masses of coins move,possible hardforks,stories about bitcoin ties with the goverments or agencies
it will not do much for the adoption or popularisation
but it is only my IMHO and we may never know....
Yeah, I think that one of the reasons that satoshi created bitcoin in the first place is that he wanted to protect the privacy of the users by adding a feature of anonymity. I'd say that he definitely wants to stay anonymous forever, otherwise he would have revealed himself earlier.
My opinion on the subject is just leave him alone.
If satoshi does reveal himself, something that has a very low probability of happening, then there will be a lot of media hype and possibly bitcoin price will go up.