Yes, I commented that out ( Doesn't do much more than versions before as those hadn't those checks ).
And yes I wrote its not the best solution for the issue.
I'll try to edit the armory code and see if that will work as well.
Edit, that change alone isn't enough, armory won't connect to bitcoinABC.
I keep my dirty fix for now till i've more time to get deeper into the armory code.
Topic: Using Armory on the BCH chain - page 4. (Read 46022 times)
The only thing you're doing here is uncommenting an actual comment. This won't build no matter what you try.
What I am guessing you're trying to do is to comment out the entire if branch. I would advise users not to do that, as their ABC node would be trying to process messages from actual Bitcoin nodes, which overwhelm BCH. Basically the equivalent of DDoSing yourself.
Instead, you can try to change the P2P magic word in Armory (there's no guarantee that change alone will be enough):
https://github.com/goatpig/BitcoinArmory/blob/master/cppForSwig/BlockUtils.cpp#L886
Should be changed to:
What I am guessing you're trying to do is to comment out the entire if branch. I would advise users not to do that, as their ABC node would be trying to process messages from actual Bitcoin nodes, which overwhelm BCH. Basically the equivalent of DDoSing yourself.
Instead, you can try to change the P2P magic word in Armory (there's no guarantee that change alone will be enough):
https://github.com/goatpig/BitcoinArmory/blob/master/cppForSwig/BlockUtils.cpp#L886
Code:
networkNode_ = make_shared("127.0.0.1", config_.btcPort_,
*(uint32_t*)config_.magicBytes_.getPtr());
Should be changed to:
Code:
networkNode_ = make_shared("127.0.0.1", config_.btcPort_,
0xe3e1f3e8);
I managed to get armory connected to the newest bitcoinABC version.
You need to remove 2 checks from the the net_processing.cpp:
Note that Bitcoin nodes will also connect to your node then.
Extra if statements that skip those checks only for armory would make more sense or add the net magic to armory on connection. ( {0xe3, 0xe1, 0xf3, 0xe8} )
You need to remove 2 checks from the the net_processing.cpp:
Code:
//Scan for message start
if (memcmp(std::begin(msg.hdr.pchMessageStart),
std::begin(chainparams.NetMagic()),
CMessageHeader::MESSAGE_START_SIZE) != 0) {
LogPrintf("PROCESSMESSAGE: INVALID MESSAGESTART %s peer=%d\n",
SanitizeString(msg.hdr.GetCommand()), pfrom->id);
Make sure we ban where that come from for some time.
connman.Ban(pfrom->addr, BanReasonNodeMisbehaving);
pfrom->fDisconnect = true;
return false;
}
if (!hdr.IsValid(config)) {
LogPrintf("PROCESSMESSAGE: ERRORS IN HEADER %s peer=%d\n",
SanitizeString(hdr.GetCommand()), pfrom->id);
return fMoreWork;
}
Note that Bitcoin nodes will also connect to your node then.
Extra if statements that skip those checks only for armory would make more sense or add the net magic to armory on connection. ( {0xe3, 0xe1, 0xf3, 0xe8} )
can't you just import your keys into an offline ElectronCash wallet as a cold wallet option for hodling?
If you think you have no malware or keyloggers and that there is no way for your keys to have been harvested... then yes, you could simply import them into an offline wallet to HODL. An even better option would be to simply do nothing at all. You don't need to "claim" BCH, there is no deadline. The coins already exist on the BCH blockchain and can only be moved with your private keys.Barring a total collapse of BCH, in which case it doesn't matter where or what you did with the coins, "your" BCH are safely linked to your BTC keys and can stay that way until you wish to sell/exchange them etc.
If you just want to be able to "see" your BCH to make yourself feel rich, just create a BCH watching-only wallet using your BTC addresses
Yes, I want to dump the BCH,. Do I import Plain Base 58 format from here
and then send to an Exchange?
No... you have selected the wrong option in the "Install Wizard"... as I said, you need to select "Import Bitcoin Addresses or Private keys"... DO NOT select "Standard Wallet"and then send to an Exchange?
Select that option, copy/paste the "PlainBase58" private keys when prompted (1 per line):
Following that, ElectronCash will create the wallet, you'll see your BCH balance... you can then send to an Exchange.
You can either Sweep (which will create an onchain transaction that sends the BCH from the old "btc" addresses to new BCH addresses in your BCH wallet)... or you can Import the keys into a BCH wallet (use the "Import Bitcoin addresses or private keys" option when creating the wallet in ElectronCash).
It depends what you want to do... if you want to HODL your BCH, then Sweep is the better option as you're moving the coins from the "exposed" keys. If you're just wanting to dump the BCH... importing the keys and then just sending them to an Exchange is probably "cheaper" and faster (saves paying and waiting for the sweep transaction)
It depends what you want to do... if you want to HODL your BCH, then Sweep is the better option as you're moving the coins from the "exposed" keys. If you're just wanting to dump the BCH... importing the keys and then just sending them to an Exchange is probably "cheaper" and faster (saves paying and waiting for the sweep transaction)
Yes, I want to dump the BCH,. Do I import private keys (Plain Base 58 format) from here
https://i.imgur.com/zm0Gynz.jpg
and then send to an Exchange?
You can either Sweep (which will create an onchain transaction that sends the BCH from the old "btc" addresses to new BCH addresses in your BCH wallet)... or you can Import the keys into a BCH wallet (use the "Import Bitcoin addresses or private keys" option when creating the wallet in ElectronCash).
It depends what you want to do... if you want to HODL your BCH, then Sweep is the better option as you're moving the coins from the "exposed" keys. If you're just wanting to dump the BCH... importing the keys and then just sending them to an Exchange is probably "cheaper" and faster (saves paying and waiting for the sweep transaction)
It depends what you want to do... if you want to HODL your BCH, then Sweep is the better option as you're moving the coins from the "exposed" keys. If you're just wanting to dump the BCH... importing the keys and then just sending them to an Exchange is probably "cheaper" and faster (saves paying and waiting for the sweep transaction)
can't you just import your keys into an offline ElectronCash wallet as a cold wallet option for hodling?
I don't know how to configure an "offline" ElectronCash wallet. It probably can be done. After extracting the coins you just send them to your hardware wallet. Wash repeat with next forked coin.
Or you can add a password to the ElectronCash wallet and keep the coins there until you figure out what to do with them.
Quote
For BCH, Do I just simple sweep Private Key "(Plain Base58)keys" to get bch ?
I just simply imported (copy and pasted from a prepared note pad file) my "used" private keys, with no addresses. Stacked on top of each other. In Plain Base 58 format. Into the import electrum wallets. I've done BTG and BTP so far. No problems.
I guess if you don't import your "unused keys" your Armory wallet is still secure (for future transactions)? But if I every need to use Armory I will still make another wallet just in case.
You can either Sweep (which will create an onchain transaction that sends the BCH from the old "btc" addresses to new BCH addresses in your BCH wallet)... or you can Import the keys into a BCH wallet (use the "Import Bitcoin addresses or private keys" option when creating the wallet in ElectronCash).
It depends what you want to do... if you want to HODL your BCH, then Sweep is the better option as you're moving the coins from the "exposed" keys. If you're just wanting to dump the BCH... importing the keys and then just sending them to an Exchange is probably "cheaper" and faster (saves paying and waiting for the sweep transaction)
It depends what you want to do... if you want to HODL your BCH, then Sweep is the better option as you're moving the coins from the "exposed" keys. If you're just wanting to dump the BCH... importing the keys and then just sending them to an Exchange is probably "cheaper" and faster (saves paying and waiting for the sweep transaction)
can't you just import your keys into an offline ElectronCash wallet as a cold wallet option for hodling?
You can either Sweep (which will create an onchain transaction that sends the BCH from the old "btc" addresses to new BCH addresses in your BCH wallet)... or you can Import the keys into a BCH wallet (use the "Import Bitcoin addresses or private keys" option when creating the wallet in ElectronCash).
It depends what you want to do... if you want to HODL your BCH, then Sweep is the better option as you're moving the coins from the "exposed" keys. If you're just wanting to dump the BCH... importing the keys and then just sending them to an Exchange is probably "cheaper" and faster (saves paying and waiting for the sweep transaction)
It depends what you want to do... if you want to HODL your BCH, then Sweep is the better option as you're moving the coins from the "exposed" keys. If you're just wanting to dump the BCH... importing the keys and then just sending them to an Exchange is probably "cheaper" and faster (saves paying and waiting for the sweep transaction)
Quote
Hi justmyname
I want to move my BTC.
What is the fee you set when you sent out BTC? Do you follow this site advice: e.g. set transaction fee is currently 20 satoshis/byte ...... https://bitcoinfees.earn.com/
I want to move my BTC.
What is the fee you set when you sent out BTC? Do you follow this site advice: e.g. set transaction fee is currently 20 satoshis/byte ...... https://bitcoinfees.earn.com/
The traffic isn't that high right now. Anything over a dollar in transaction fees will quickly send the Bitcoin. I think I spent under 5$ to send all my Crypto to my hardware wallet. Funds were in hardware wallet withing a minute.
Quote
Does BCH wallet download from below link?
https://electroncash.org/
Does BTG wallet download from below link?
https://github.com/BTCGPU/electrum/releases/tag/3.2-beta
Thx.
https://electroncash.org/
Does BTG wallet download from below link?
https://github.com/BTCGPU/electrum/releases/tag/3.2-beta
Thx.
Looks legit to me but I'm not an expert coder. All you can do is do a search to find any bad sites that are known to have tampered wallets. Generally if you go to a coins official site the wallets are safe.
Thank you very much for your reply!
For BCH, Do I just simple sweep Private Key "(Plain Base58)keys" to get bch ?https://i.imgur.com/xJq9ZcR.jpg
Quote
Hi justmyname
I want to move my BTC.
What is the fee you set when you sent out BTC? Do you follow this site advice: e.g. set transaction fee is currently 20 satoshis/byte ...... https://bitcoinfees.earn.com/
I want to move my BTC.
What is the fee you set when you sent out BTC? Do you follow this site advice: e.g. set transaction fee is currently 20 satoshis/byte ...... https://bitcoinfees.earn.com/
The traffic isn't that high right now. Anything over a dollar in transaction fees will quickly send the Bitcoin. I think I spent under 5$ to send all my Crypto to my hardware wallet. Funds were in hardware wallet withing a minute.
Quote
Does BCH wallet download from below link?
https://electroncash.org/
Does BTG wallet download from below link?
https://github.com/BTCGPU/electrum/releases/tag/3.2-beta
Thx.
https://electroncash.org/
Does BTG wallet download from below link?
https://github.com/BTCGPU/electrum/releases/tag/3.2-beta
Thx.
Looks legit to me but I'm not an expert coder. All you can do is do a search to find any bad sites that are known to have tampered wallets. Generally if you go to a coins official site the wallets are safe.
Quote
Thank you very much for your reply "HCP"
I got the Hardware Wallet, I will move btc , bch, btg.....to it. I will also keep all private keys and the wallet backups.
I got the Hardware Wallet, I will move btc , bch, btg.....to it. I will also keep all private keys and the wallet backups.
Just remember. First move your BTC to the new hardware wallet before exporting the keys. As you get new coins move them to the hardware or other wallets.
Copy your keys to windows notepad and put that in a safe offline place like a thumb drive. Then edit everything out except the used keys. One key stacked above the next. Then you can import them over and over into any coins wallet designed to except keys previously forked from Bitcoin.
Hi justmyname
I want to move my BTC.
What is the fee you set when you sent out BTC? Do you follow this site advice: e.g. set transaction fee is currently 20 satoshis/byte ...... https://bitcoinfees.earn.com/
Does BCH wallet download from below link?
https://electroncash.org/
Does BTG wallet download from below link?
https://github.com/BTCGPU/electrum/releases/tag/3.2-beta
Thx.
@goatpig
after May 15, it's my understanding we can still access BCH using the "trick" method you've outlined at the beginning of this thread (of pruning the core blocks after the 8/1/17 hard fork), isn't that correct? afaict, broadcasting the BCH raw signatures using Blockdozer or any other BCH explorer as currently supplied using your method shouldn't be affected by the BCH change in network magic with the upcoming fork, correct?
after May 15, it's my understanding we can still access BCH using the "trick" method you've outlined at the beginning of this thread (of pruning the core blocks after the 8/1/17 hard fork), isn't that correct? afaict, broadcasting the BCH raw signatures using Blockdozer or any other BCH explorer as currently supplied using your method shouldn't be affected by the BCH change in network magic with the upcoming fork, correct?
I know that already, but on May 15th the old versions won't work anymore.
I tried also to remove the code from the main.cpp ( BUcash ) but then another check is triggered and it's still not working.
Don't want to mess much more in the code for now.
I guess I can get it to work by editing some code on ABC or BUcash but guess in the long Armory need to use the correct network magic for Bitcoin Cash, maybe some setting under the bitcoin settings to check that it is Bitcoin Cash?
"in the long?"... Don't bank on any further official support for BCH in Armory. Goatpig is unlikely to fix it if/when any hardforks break BCH usage - as I understand it, it has been provided as a courtesy to get the coins out, nothing more. If it does break on the 15th, you're probably limited to exporting keys at that point or forking Armory and fixing it yourself. I tried also to remove the code from the main.cpp ( BUcash ) but then another check is triggered and it's still not working.
Don't want to mess much more in the code for now.
I guess I can get it to work by editing some code on ABC or BUcash but guess in the long Armory need to use the correct network magic for Bitcoin Cash, maybe some setting under the bitcoin settings to check that it is Bitcoin Cash?
Seems newer bitcoin cash nodes have stricter connection parameters to avoid getting connections from other chains and now armory can't connect anymore...
On the node I get Invalid message start.
Tested with newest ABC and BUcash
On the node I get Invalid message start.
Tested with newest ABC and BUcash
Their is a problem with the newer ABC wallets. It won't work with ARmory unless you use an older version like this. https://download.bitcoinabc.org/0.16.1/win/
My BCH Armory Wallet works better than when synched to the original BTC Core.
I know that already, but on May 15th the old versions won't work anymore.
I tried also to remove the code from the main.cpp ( BUcash ) but then another check is triggered and it's still not working.
Don't want to mess much more in the code for now.
I guess I can get it to work by editing some code on ABC or BUcash but guess in the long Armory need to use the correct network magic for Bitcoin Cash, maybe some setting under the bitcoin settings to check that it is Bitcoin Cash?
Seems newer bitcoin cash nodes have stricter connection parameters to avoid getting connections from other chains and now armory can't connect anymore...
On the node I get Invalid message start.
Tested with newest ABC and BUcash
On the node I get Invalid message start.
Tested with newest ABC and BUcash
Their is a problem with the newer ABC wallets. It won't work with ARmory unless you use an older version like this. https://download.bitcoinabc.org/0.16.1/win/
My BCH Armory Wallet works better than when synched to the original BTC Core.
Seems newer bitcoin cash nodes have stricter connection parameters to avoid getting connections from other chains and now armory can't connect anymore...
On the node I get Invalid message start.
Tested with newest ABC and BUcash
On the node I get Invalid message start.
Tested with newest ABC and BUcash
why do you need to go thru BTC Electrum first? why not just import Armory private keys directly into Electron Cash and/or ElectrumG?
It's not strictly necessary... But as "Peg" stated in this post:- Import keys into BTC Electrum (ensure all empty)
It's a useful way to double check that you have successfully moved ALL your BTC before your import those keys into other wallets.If Electrum (BTC) shows a non-zero balance, you missed some!
It can also be necessary to actually use Electrum BTC to move your BTC in the case where you are restoring the Armory wallet (for whatever reason, computer crash, Bitcoin Core corrupted etc) and don't want to wait for Bitcoin Core (and/or) Armory to sync back up before moving your BTC.
Quote
why do you need to go thru BTC Electrum first? why not just import Armory private keys directly into Electron Cash and/or ElectrumG?
You can import your keys into any compatible wallet that allows it. Go to the most valuable coin first. After importing keys move the coins into another, hardware wallet etc. That has has it's own seed, keys.
A compromised wallet download. Device. Could steal your keys and get whatever is left in there.
Quote
Thank you very much for your reply "HCP"
I got the Hardware Wallet, I will move btc , bch, btg.....to it. I will also keep all private keys and the wallet backups.
I got the Hardware Wallet, I will move btc , bch, btg.....to it. I will also keep all private keys and the wallet backups.
Just remember. First move your BTC to the new hardware wallet before exporting the keys. As you get new coins move them to the hardware or other wallets.
Copy your keys to windows notepad and put that in a safe offline place like a thumb drive. Then edit everything out except the used keys. One key stacked above the next. Then you can import them over and over into any coins wallet designed to except keys previously forked from Bitcoin.
Jump to: