Yet another Coin Control Release [CLOSED] - page 4.

Gavin Andresen

legendary

Activity: 1652

Merit: 2216

Chief Scientist

Quote from: Financisto on October 21, 2013, 06:17:19 AM

IMHO I think it should be available as default to official client.

... then volunteer to run through the test plan and help shake out any bugs. Code that touches the wallet is particularly sensitive, because an obscure bug might cause lots of people to lose lots of money.

drrussellshane

hero member

Activity: 546

Merit: 500

Quote from: Financisto on October 21, 2013, 06:17:19 AM

Greetings!

Thank you for developing such a great plug-in/add-on to bitcoin-Qt.

IMHO I think it should be available as default to official client.

I heartily agree!

Kaj ankaŭ, kun nomon tiel vian kaj vian verdstelon, mi vetas, ke vi povas legi ĉi tion sen tro malfacileco.

Financisto

hero member

Activity: 633

Merit: 768

BTC⇆⚡⇄BTC

Greetings!

Thank you for developing such a great plug-in/add-on to bitcoin-Qt.

IMHO I think it should be available as default to official client.

Dabs

legendary

Activity: 3416

Merit: 1912

The Concierge of Crypto

I haven't tried to break it. But it hasn't failed me yet.

K1773R

legendary

Activity: 1792

Merit: 1008

/dev/null

Quote from: Wolf0 on September 13, 2013, 08:27:37 PM

Quote from: behindtext on September 13, 2013, 07:54:00 PM

Quote from: Wolf0 on September 13, 2013, 07:18:07 PM

Quote from: gmaxwell on September 13, 2013, 12:55:24 PM

Can someone please work on creating a test plan and working through it so we can merge this? Sad

I would think it's been tested enough. Unless you mean that someone has to create a test plan to satisfy some bureaucratic nonsense.

it's not a matter of whether it's been behavior-tested enough in the field, it's a matter of ongoing test support, thus the request for a plan.

a test plan matters and it is not "bureaucratic nonsense". if you distribute software that breaks or has bugs creep in, especially with financial software, it reflects poorly on the developers.

It'd be pretty hard for CC to break at this point, since so many people have tested it and tried to break it. Unless you mean a test plan to expose any future bugs.

also many ppls (including me) are using CC since it was available (both versions, first coderrr's, now cozz's).

behindtext

full member

Activity: 121

Merit: 103

Quote from: Wolf0 on September 13, 2013, 07:18:07 PM

Quote from: gmaxwell on September 13, 2013, 12:55:24 PM

Can someone please work on creating a test plan and working through it so we can merge this? Sad

I would think it's been tested enough. Unless you mean that someone has to create a test plan to satisfy some bureaucratic nonsense.

it's not a matter of whether it's been behavior-tested enough in the field, it's a matter of ongoing test support, thus the request for a plan.

a test plan matters and it is not "bureaucratic nonsense". if you distribute software that breaks or has bugs creep in, especially with financial software, it reflects poorly on the developers.

phelix

legendary

Activity: 1708

Merit: 1019

cross post fyi

Quote from: gmaxwell on September 05, 2013, 06:52:19 AM

Quote from: phelix on September 05, 2013, 06:29:59 AM

Quote from: gmaxwell on September 05, 2013, 05:40:17 AM

No one who has any interest in coin control spent any time on the payment protocol as far as I know.

This sentence can be interpreted in a lot of ways

Well, that was intentional. I might be corrected, but I don't think Gavin has ever considered the feature particularly important. He isn't opposed to it, and its supported by other core developers but Gavin has been pretty insistent on someone doing a robust test plan for it (and I agree)— which no one has ever done.

[my emphasis]

Maybe it's not even so bad: https://github.com/bitcoin/QA/

I would be happy to help testing.

edit: had not even seen gmaxwell's post above Roll Eyes

edit2: This might be helpful: https://github.com/dserrano5/QA/blob/0ad3091599c71bcca602926adf7d6ac180e21d36/SpendFrom.md

edit3: I had expected a test plan to cover at least the majority of possible cases including lots of edge cases... what I see is more like a well documented sanity test. The above SpendFrom.md test plan with some additions should do the job.

gmaxwell

staff

Activity: 4200

Merit: 8441

Can someone please work on creating a test plan and working through it so we can merge this? Sad

Birdy

sr. member

Activity: 364

Merit: 250

Thank you :3

cozz

member

Activity: 61

Merit: 15

update: v0.8.5

@Dabs: changed date in my build script this time

Dabs

legendary

Activity: 3416

Merit: 1912

The Concierge of Crypto

https://bitcointalksearch.org/topic/bitcoin-qt-bitcoind-version-085-released-293307
Bitcoin-Qt / bitcoind version 0.8.5 released

Cozz, also, your previous version, 0.8.4 had the wrong dates, or you dated it all 2011. Don't forget to use the current date when you update this. Thanks!

Dabs

legendary

Activity: 3416

Merit: 1912

The Concierge of Crypto

Quote from: cozz on September 04, 2013, 03:21:45 PM

update: v0.8.4

Wow, Thanks for the very fast update!

cozz

member

Activity: 61

Merit: 15

update: v0.8.4

Dabs

legendary

Activity: 3416

Merit: 1912

The Concierge of Crypto

https://bitcointalksearch.org/topic/bitcoin-qt-bitcoind-version-084-released-fixes-critical-dos-vulnerability-287351
Version 0.8.4 of the standard QT client released.

K1773R

legendary

Activity: 1792

Merit: 1008

/dev/null

this might be of interested to you cozz: https://bitcointalksearch.org/topic/m.3005468

thanks again (as i already used it for a long time @ btc) for your work!
is your signature address still valid (ie, no lost privkey) so i can send you a little donation?

greetings

kuzetsa

sr. member

Activity: 369

Merit: 250

Just wanted to point out this is available for testing on a more recent "next-test" build:

Bitcoin-Qt next-test 2013-07-21

phelix

legendary

Activity: 1708

Merit: 1019

Quote from: cozz on July 15, 2013, 07:01:00 PM

Quote from: phelix on July 15, 2013, 05:40:33 PM

Before I dump my time into it... do you also have a hint on this one?

Code:

...

looks like you are using the original bitcoin-qt.pro, not the new one. I have tested the code I gave you again, it sure compiles for me.

My bad.

Compiles like a charm (tip sent).

cozz

member

Activity: 61

Merit: 15

Quote from: phelix on July 15, 2013, 05:40:33 PM

Before I dump my time into it... do you also have a hint on this one?

Code:

g++ -Wl,--dynamicbase -Wl,--nxcompat -Wl,--large-address-aware -Wl,-s -mthreads -Wl,-subsystem,windows -o release/bitcoin-qt.exe object_script.bitcoin-qt.Release -L'c:/Qt/4.8.5/lib' -lmingwthrd -lmingw32 -lqtmain build/bitcoin-qt_res.o -Llibs/miniupnpc-1.8 -lminiupnpc -liphlpapi C:/_temp/_bitcoin_0.8.3_coincontrol/src/leveldb/libleveldb.a C:/_temp/_bitcoin_0.8.3_coincontrol/src/leveldb/libmemenv.a -lshlwapi -Llibs/boost_1_54_0/stage/lib -Llibs/db-4.8.30.NC/build_unix -Llibs/openssl-1.0.1e -lssl -lcrypto -ldb_cxx -lws2_32 -lshlwapi -lmswsock -lole32 -loleaut32 -luuid -lgdi32 -lboost_system-mgw46-mt-sd-1_54 -lboost_filesystem-mgw46-mt-sd-1_54 -lboost_program_options-mgw46-mt-sd-1_54 -lboost_thread-mgw46-mt-sd-1_54 -lboost_chrono-mgw46-mt-sd-1_54 -lQtGui4 -lQtNetwork4 -lQtCore4
./build/coincontroldialog.o:coincontroldialog.cpp:(.text+0x1cda): undefined reference to `WalletModel::listLockedCoins(std::vector >&)'
./build/coincontroldialog.o:coincontroldialog.cpp:(.text+0x2077): undefined reference to `WalletModel::isLockedCoin(uint256, unsig ned int) const'
./build/coincontroldialog.o:coincontroldialog.cpp:(.text+0x2324): undefined reference to `WalletModel::unlockCoin(COutPoint&)'
./build/coincontroldialog.o:coincontroldialog.cpp:(.text+0x263e): undefined reference to `WalletModel::lockCoin(COutPoint&)'
...

looks like you are using the original bitcoin-qt.pro, not the new one. I have tested the code I gave you again, it sure compiles for me.

phelix

legendary

Activity: 1708

Merit: 1019

Quote from: cozz on July 15, 2013, 03:34:01 PM

Quote from: phelix on July 15, 2013, 12:02:09 PM

I would like to build on Windows myself (using EasyWinBuilder;)). Unfortunately the github link is not working any more and the linux source archive seems to be missing the Qt project file.

Trying Sipa's branch...

I updated the source code link now

Thanks!

Before I dump my time into it... do you also have a hint on this one?

Code:

g++ -Wl,--dynamicbase -Wl,--nxcompat -Wl,--large-address-aware -Wl,-s -mthreads -Wl,-subsystem,windows -o release/bitcoin-qt.exe object_script.bitcoin-qt.Release -L'c:/Qt/4.8.5/lib' -lmingwthrd -lmingw32 -lqtmain build/bitcoin-qt_res.o -Llibs/miniupnpc-1.8 -lminiupnpc -liphlpapi C:/_temp/_bitcoin_0.8.3_coincontrol/src/leveldb/libleveldb.a C:/_temp/_bitcoin_0.8.3_coincontrol/src/leveldb/libmemenv.a -lshlwapi -Llibs/boost_1_54_0/stage/lib -Llibs/db-4.8.30.NC/build_unix -Llibs/openssl-1.0.1e -lssl -lcrypto -ldb_cxx -lws2_32 -lshlwapi -lmswsock -lole32 -loleaut32 -luuid -lgdi32 -lboost_system-mgw46-mt-sd-1_54 -lboost_filesystem-mgw46-mt-sd-1_54 -lboost_program_options-mgw46-mt-sd-1_54 -lboost_thread-mgw46-mt-sd-1_54 -lboost_chrono-mgw46-mt-sd-1_54 -lQtGui4 -lQtNetwork4 -lQtCore4
./build/coincontroldialog.o:coincontroldialog.cpp:(.text+0x1cda): undefined reference to `WalletModel::listLockedCoins(std::vector >&)'
./build/coincontroldialog.o:coincontroldialog.cpp:(.text+0x2077): undefined reference to `WalletModel::isLockedCoin(uint256, unsig ned int) const'
./build/coincontroldialog.o:coincontroldialog.cpp:(.text+0x2324): undefined reference to `WalletModel::unlockCoin(COutPoint&)'
./build/coincontroldialog.o:coincontroldialog.cpp:(.text+0x263e): undefined reference to `WalletModel::lockCoin(COutPoint&)'
...

cozz

member

Activity: 61

Merit: 15

Quote from: phelix on July 15, 2013, 12:02:09 PM

I would like to build on Windows myself (using EasyWinBuilder;)). Unfortunately the github link is not working any more and the linux source archive seems to be missing the Qt project file.

Trying Sipa's branch...

I updated the source code link now

Topic: Yet another Coin Control Release [CLOSED] - page 4. (Read 47431 times)