So whats the consensus here?
Are we agreeing to differ?
Look, I think we all want bitcoin to succeed, or we would all be on pornhub right now.
At the beginning of this thread when reading what Turtlehurricane had posted I asked if any coders could weigh in. FUD was called a bit too quickly, although I admit, there are some posts from Turtlehurrican which are often inflammatory in nature. I don't consider this a bad thing necessarily, as it draws attention and debate to things which may or may not be of concern.
But...
After reading all of this thread and others elsewhere, I find that although people who code have made their point - and it seems Turtlehurricane hasn't yet been able to exactly point to the code he refers to that isn't already in core - this subject is still confusing, for want of a better word.
So far, this is what I understand.
1. Blacklisting/whitelisting is either already within the core code, or they are code terms that don't actually mean blacklisting/whitelisting in view of the English language usage, per se.
2. The above referred to blacklisting/whitelisting doesn't ban anyone, it simply deprioritizes Tor, as this is a defence against possible spam attacks. It only does this for the period of time of the spam attack, and then resumes as normal.
3. The blacklisting/whitelisting code in fact doesn't get (hidden) IP's, the only IP it's concerned with is a Tor operating IP(?) This is maybe/maybe not (as far as my understanding goes at the moment) a somewhat unfair penalization for Tor users, but at least it doesn't compromise the Tor users IP's.
4. Although many node users may not be aware of it, they are able to disable this part of the blacklisting/whitelisting code, but it is set to default.
I'm sure I've missed something, so anyone feel free to add logic/proof based points.
Although the above seems (somewhat) clear to me, I think it's hard to deny the recent spam attacks were quite obviously deliberate and used to push a certain agenda forward, ie. block size.
A considerable amount of finances were used for those attacks and I think it's fairly safe to say that whichever party/parties did it, they stood to (financially) gain in return.
So where do the fingers point to that financial gain? I'm not about to answer that question, and it would be useless to try. But I find it hard to believe Bitcoin has a mysterious benefactor that spends all that money out of the goodness or his/her/their own heart just to push further block size increase adoption for the common good.
I should make it clear that I'm not against block size increase and scaling, undecided, maybe, but not against.
Honestly, the most useful and enlightening post on the subject I've seen was posted in an XT alt coin thread by Canth, who I hope won't mind me posting it here
https://bitcointalksearch.org/topic/does-xt-really-log-your-ip-address-and-want-to-blacklist-addresses-and-coins-1157289 :
BitcoinXT has an anti-ddos feature, it can block connections to certain IPs, it downloads a list from an SSL site. Yes, the site might get your IP address. The entire feature can be disabled with one flag in the config.
Unless you're running behind Tor and/or VPN, ALL bitcoin full node products 'leak' your IP address to other bitcoin nodes and the internet in general...
The bold is mine. That point surprised me.
ps: I'm grateful for everyone in this thread that has taken their time to go over this as I really wanted to understand it.