Topic: [ANN] Zcoin (XZC) - Implementing ZKP privacy without trusted setup - page 212. (Read 663312 times)

That works now :-).
Nice work, beautifull.

Try it now!

Thanks for the confirmation, I feel much better now.

It appears there is a divergence between zcoin getwork and hexx getwork. It's now up to hexx to decide whether to stay
with 128 or make the complete change to 132. This update https://github.com/zcoinofficial/zcoin/commit/feb30a4dec722d5bce989e0840b9c50ed4affec5
appears to be only half of it. Your previous comments suggest it fixed an issue in Vert so it might be worth pursuing, but that's entirely up to hexx.

I glad things worked out before going too far off track.

Ok aizensou retested cpuminer-opt 3.6.0 on testnet and this one works...

regarding the byte reverse, I don't think it really matters as the last 4bytes are probably unused (someone would need to check the header definition and see what it really happening at that level).

The byte reverse still looks suspicious. If the size is 132 shouldn't it reverse all 132 bytes?

I will also retest it.
Want close off possibility of an error when last time tested it.
Time after the commit and before fork, it is clear that it did not work then.

Can Aizen confirm the cpuminer-opt version used for the test? It should be 3.6.0.

agree... hence if you submit 128bytes to the wallet it should get accepted, it will throw an error only if it is different from 128bytes...

well if your miner does not work on Zcoin (which I didn't try personnaly) hence it means it is broken (I mean at least for zcoin) and hexxcoin has been telling us for a day now, that our code is broken because you can't run your miner on it... so I am not the one saying it "per se", I just connect the dots...

ps: actually it is hexxcoin who has been telling your code is broken and it is our fault

I looked up vector:insert and it prepends 4 bytes to the message growing its size from 128 to 132.
Apparently this is required by zcoin but not by hexx. Those two bits of code are tighttly coupled.
If the insert is done the size is 132, if not the size is 128.

This appears to be all internal to the wallet so I don't understand why DJM34 still claims my code is broken
on zcoin. The size difference is transparent to the miner and we both work with 128 byte data.
Wrong version of cpuminer-opt maybe, getwork was broken for all algos prior to 3.6.0.

A "error 520" is returned : perhaps test period ?

Because you are stupid
I'm sorry, I'm just kidding

Why i have to repeat my self?
Two (2) mistakes(error in the code)
Please do not comment without testing.

Hexxcoin dev first claimed that no miner were working on getwork hence telling I didn't test anything and that my miners were broken while all the test were done on testnet in the early stage due to the absence of a pool at that time.
A problem was discovered in the early time which was forbidding getwork to work and a fix was applied (which was similar to what was done by vtc dev to fix their getwork between the switch from lyra2re to lyra2rev2.
Once this fix has been applied, it was possible to mine block through getwork and have them accepted by the wallet.
(this fix was applied before the hardfork to lyra2Z while it was still in development).

As for my code it reads 128bytes and submit 128bytes like for any standard wallet without any problem.
Aizen tested yesterday again on testnet and didn't find any problem (except for your miner... sorry)

In other news, we've launched our official Zcoin block explorer with Zerocoin stats!

Official Zcoin block explorer launched at https://explorer.zcoin.io with Zerocoin stats feature. $XZC #zcoin

Cool Glad that cleared things up and thanks for the heads up.

I think it was just the choice of words Hexx said it to say our wallet is broken and 'not to bother' in red fonts when it was working with the 3 miners we tested with as if there was a serious flaw in our getwork mining when if you used the miners we linked it would work. I understand English may not be his first language but yeah. I think it didn't help that the entire Zerocoin portion was taken from us (which is his right this being an open source project). But I think we can all work together and improve the codebase together so hey, maybe we'll be taking from his code too .

Will check with the devs on the reason of the change of that commit but in either case, it's nothing to get worked up about. Small stuff.

I went back and doublechecked the response and you are correct it was DJM34 who first claimed my miner was broken calling it
"your miner" when responding to hexx. It's my turn to apologize to you.

I don't understand the negative reaction to hexx other than maybe he is a competitor. I worked with him to get getwork working
on hexx and that is when we discovered the 132 problem. Reverting that change in the wallet fixed getwork for hexx.
He was simply reporting our findings to you. It's not a bug in DJM's miner so I don't know why he's so defensive.

You really need to get to the bottom of the change to 132 in the wallet. It only takes a quick glance at that code to see it's broken.
My testing with hexx confirms it. When was the last time getwork was tested with an external miner on zcoin? I suggest a retest.

Ummm, although djm34 is part of our team as a miner dev, I don't think any other Zcoin devs said anything about your code being broken? Definitely not from me and I don't see Poramin's, Saran's Or Aizensou's comments either. The way you phrased it here:


is as if djm34 and there's another zcoin dev that said it was broken which if you look carefully, isn't there. It's only djm34 who is replying.

Even djm34's remarks were more aimed at Hexx who was claiming that our mining via getwork didn't work and that our code was broken I checked with Aizen and djm34 who both confirmed that it was working on theirs on testnet from their own solo mining. However, I genuinely wanted to find out what Hexx was talking about and I don't think I ever commented on your miner but merely stated the fact that it seems to be working on ours so we weren't sure what he was going on about and then it was Hexx who dragged you into the conversation.

In any case I apologize for any misunderstanding. We just wanted to clarify that mining does indeed work with the miners we tested on and I did want to see whether Hexx's concerns were real as it is always good to have other eyes looking at the code. But to claim our getwork mining is broken when afaik it isn't, rubbed some of us the wrong way (especially djm34 which is understandable since he was the one working on the miners with aizensou).

So let's ignore the fact that I use standard getwork data size of 128 just like you do and it works with other algos. How does your code work with 128
bit data size when the zcoin wallet tests for 132? How did the size magically grow by 4 bytes to pass the test? Why were those 4 bytes then ignored
if they were so important the wallet would throw an exception? What specifically did you change in the getwork miner code to make it work with zcoin?
You clearly haven't even looked at the code in question, you're just making hollow assertions, just like the zcoin dev.

I'm complaining because zcoin dev claimed my code was broken without any evidence. What do your expect from me, besides pissing me off?
Now you're making those same baseless claims and now I'm pissed at you too.

I've done my testing to back up what I'm saying, it's time for you to step up or back off.

if I had to complain each time (and I probably did curse a lot in front of my computer... ) I had to accommodate one coin or another.... geez
At some point, you just have to do what it takes to make things work and that's it... (and quite frankly there isn't much to do to make it works)
(the only times I asked a dev to change his code are when I am working with them and it is usually before the release of the wallet and miners not a month after the wallet has been release... )
Also hexxcoin has been trolling since this morning, so not sure what you would expect from the devs (beside pissing them off)

also the fact that other miners work, definitely means it is up to you to fix yours... (the code is everywhere on github... just need to look at it and fix it...), or ask gently... without trolling during a day...

join hexx  he is more fun