By the way, what about my bounty? Only Beave162 sent me his so far.
Don't worry, I didn't forget about my 5kYAC plege ...
As long as it isn't pulled by Joe_Bauers or someone else with programming background has checked the source for possible bugs it isn't completly finished. Critical Bugs like the one that destroyed the change if you didn't use a custom change adress shouldn't have been in the published exe the first place. If such review isn't possible untill an acceptable period of time I'll use it for a review. Having said that I really doubt you won't get it soon.
Yeah, I'm sorry for that bug. Luckily I discovered it fairly quickly after release, so no one else's YACs were lost.
There aren't too many changes compared to Bitcoin's version of Coin Control, so it shouldn't be THAT hard to conduct a code review (that is, if you trust Cozz and the Bitcoin devs
). Also, I believe there aren't any other money-destroying bugs in the code (as the only significant money-manipulating code that I changed was that with change addresses).
That being said, there's no rush. Just wanted to make sure you've not forgotten.
The code looks good and I haven't been able to break anything else in testing (which I'm very good at doing). Still, as we saw with the previous bug, it's better to be sure than not
To that end, I've cleaned things up in the repository. YACoin now has two branches: stable and testing. I might add version tags at some point as well, but currently it isn't needed.
Sairon, any way you could send just the coin control features to testing? If so, I will merge it there, and maybe some other folks can give it a look.
