★★ DigiByte v3.0.2 Coming Soon!★★
We have decided to release a version 3.0.2 wallet after the BTC China expo. This wallet will feature two main changes and will require mining pools to update:
1) A standardized Chinese name for "DigiByte" in the DGB wallet. We will be asking several native Chinese speakers at the conference what the proper translation for "DigiByte" into Chinese characters should be. Once we decide on the correct characters we will put it into the wallet. This will dramatically help DigiByte enter the Chinese market place.
2) We will be issuing a fix for the Scrypt block issue as well as the daemon rejection issue several pools are experiencing. In the mean time we would like some feedback & help testing this fix. A big shout-out to Thrassos for pointing this out and helping us figure out this issue!
The Scrypt block & daemon rejection issue:
Scrypt blocks are being rejected do to this code: "if (block.nVersion < 2)"
https://github.com/digibyte/DigiByteProject/blob/1dda53450ca9b2d0aad767007f01f12578b7f39e/src/main.cpp#L2576
Code:
// Reject block.nVersion=1 blocks when 95% (75% on testnet) of the network has upgraded:
if (block.nVersion < 2)
{
if ((!TestNet() && CBlockIndex::IsSuperMajority(2, pindexPrev, 950, 1000)) ||
(TestNet() && CBlockIndex::IsSuperMajority(2, pindexPrev, 75, 100)))
{
return state.Invalid(error("AcceptBlock() : rejected nVersion=1 block"),
REJECT_OBSOLETE, "bad-version");
}
}
if (block.nVersion < 2)
{
if ((!TestNet() && CBlockIndex::IsSuperMajority(2, pindexPrev, 950, 1000)) ||
(TestNet() && CBlockIndex::IsSuperMajority(2, pindexPrev, 75, 100)))
{
return state.Invalid(error("AcceptBlock() : rejected nVersion=1 block"),
REJECT_OBSOLETE, "bad-version");
}
}
The fix should be simple by changing BLOCK_VERSION_DEFAULT from 1-2. If anyone knows of any issues we might see with this please let us know.
https://github.com/digibyte/DigiByteProject/blob/master/src/core.h#L30
Code:
{
// primary version
BLOCK_VERSION_DEFAULT = 2,
// algo
BLOCK_VERSION_ALGO = (7 << 9),
BLOCK_VERSION_SHA256D = (1 << 9),
BLOCK_VERSION_GROESTL = (2 << 9),
BLOCK_VERSION_SKEIN = (3 << 9),
BLOCK_VERSION_QUBIT = (4 << 9),
};
// primary version
BLOCK_VERSION_DEFAULT = 2,
// algo
BLOCK_VERSION_ALGO = (7 << 9),
BLOCK_VERSION_SHA256D = (1 << 9),
BLOCK_VERSION_GROESTL = (2 << 9),
BLOCK_VERSION_SKEIN = (3 << 9),
BLOCK_VERSION_QUBIT = (4 << 9),
};
The github account has been updated with this change. If we could get some mining pools to test this change & report back it would be much appreciated! Thank you all!
but as i said it will not go lower than 25 unless someone intentinally dumps.
