Topic: [DVC]DevCoin - Official Thread - Moderated - page 292. (Read 1058949 times)

Got 1.0.5 running (v0.8.5.1-g25a7d46-beta). If I set up a payment of 11 DVC, I still get the message that it will cost 6 DVC.

The large bulk of my Devoins in this wallet come from an exchange (see this transaction link). Perhaps this is what triggers the fee.

I placed an order successfully and the communication was good, and the item delivered a few weeks later. I've placed a second order and haven't heard anything about it, so you might want to email him first and see if it's still a go.

Hello,

Here's a detailled code report.
I took ALL the commits made by Twobits or twobits in the devcoin client.
I made a list from all the changes made by twobits and compare with the code of Sidhujag.

 historical commits from twobits


May 26 2013   #fd07754  don't need stack randomization macro with [...] (twobits)
https://gitorious.org/devcoin/devcoin/commit/fd07754b44b6fb4d4f402085c9321f9cfbff6737

May 26 2013   #bdce5f0  Make things say devcoin (twobits)
https://gitorious.org/devcoin/devcoin/commit/bdce5f0526530a8bc24128cd0428403795373ce2

Jul 5 2013   #1785cc4  Add RPC commands: getblockhash and getblock (twobits)
https://gitorious.org/devcoin/devcoin/commit/1785cc420cd280abdb68b3af83d9dd3a28e5ef2d

Jul 16 2013   #fba32e5  Clean up headers. (Twobits)
https://gitorious.org/devcoin/devcoin/commit/fba32e5e31dcaa9d0f60d7c24000b24bb1dbcea2

Jul 18 2013   #29ddd73  only the ui files need to include xbm files (Twobits)
https://gitorious.org/devcoin/devcoin/commit/29ddd73a8b3dd6cf49e38ac5b2f98a32eab35cc6

Jul 18 2013   #f1d5b3c  devcoin graphics (twobits)
https://gitorious.org/devcoin/devcoin/commit/f1d5b3c56c74ea80a8aa21111dca2d4d17d077d1

Aug 20 2013   #ce01e7a  match rpc port change to 52332 in official repo (twobits)
https://gitorious.org/devcoin/devcoin/commit/ce01e7af882ae6579204168e3c4d1a0871936a37

Aug 20 2013   #6241096  BIP 30 (twobits)
https://gitorious.org/devcoin/devcoin/commit/62410960cc5c23921a18040529e2524780af8b6c

Aug 20 2013   #4e23c18  add DNSSeeds (twobits)
https://gitorious.org/devcoin/devcoin/commit/4e23c180945785c49bbab682b7f6c6e1eda29b05

historical commits from twobits with commited files

May 26 2013   #fd07754  don't need stack randomization macro with [...] (twobits)
src/db.cpp (2) -+
src/irc.cpp (1) -
src/net.cpp (4) ----
src/rpc.cpp (1) -
src/util.h (13) -------------
May 26 2013   #bdce5f0  Make things say devcoin (twobits)
share/pixmaps/devcoin.ico (0)
share/pixmaps/favicon.ico (0)
share/pixmaps/nsis-header.bmp (0)
share/pixmaps/nsis-wizard.bmp (0)
share/ui.rc (2) -+
src/ui.cpp (2) -+
src/uibase.cpp (14) -------+++++++
src/uibase.h (6) ---+++
Jul 5 2013   #1785cc4  Add RPC commands: getblockhash and getblock (twobits)
src/main.h (1) -
src/rpc.cpp (92) -------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Jul 16 2013   #fba32e5  Clean up headers. (Twobits)
src/headers.h (21) ------------+++++++++
src/net.cpp (3) +++
src/protocol.h (11) -++++++++++
Jul 18 2013   #29ddd73  only the ui files need to include xbm files (Twobits)
src/headers.h (15) ---------------
src/ui.cpp (5) +++++
src/xpm/bitcoin80.xpm (2) -+
Jul 18 2013   #f1d5b3c  devcoin graphics (twobits)
src/xpm/bitcoin16.xpm (350) -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin20.xpm (315) ------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin32.xpm (341) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin48.xpm (401) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin80.xpm (492) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Aug 20 2013   #ce01e7a  match rpc port change to 52332 in official repo (twobits)
src/init.cpp (2) -+
src/rpc.cpp (6) ---+++
Aug 20 2013   #6241096  BIP 30 (twobits)
src/main.cpp (26) --++++++++++++++++++++++++
Aug 20 2013   #4e23c18  add DNSSeeds (twobits)
src/net.cpp (9) ------+++

30 committed files list by twobits

src/db.cpp (2) -+
src/irc.cpp (1) -
src/net.cpp (4) ----
src/rpc.cpp (1) -
src/util.h (13) -------------
share/pixmaps/devcoin.ico (0)
share/pixmaps/favicon.ico (0)
share/pixmaps/nsis-header.bmp (0)
share/pixmaps/nsis-wizard.bmp (0)
share/ui.rc (2) -+
src/ui.cpp (2) -+
src/uibase.cpp (14) -------+++++++
src/uibase.h (6) ---+++
src/main.h (1) -
src/rpc.cpp (92) -------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/headers.h (21) ------------+++++++++
src/net.cpp (3) +++
src/protocol.h (11) -++++++++++
src/headers.h (15) ---------------
src/ui.cpp (5) +++++
src/xpm/bitcoin80.xpm (2) -+
src/xpm/bitcoin16.xpm (350) -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin20.xpm (315) ------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin32.xpm (341) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin48.xpm (401) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin80.xpm (492) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/init.cpp (2) -+
src/rpc.cpp (6) ---+++
src/main.cpp (26) --++++++++++++++++++++++++
src/net.cpp (9) ------+++

remarks :
          src/net.cpp appearing in two commits !
          src/rpc.cpp appearing in three commits !
          src/ui.cpp appearing in two commits !
          src/headers.h appearing in two commits !
         
25 unique files by twobits

src/db.cpp (2) -+
src/irc.cpp (1) -
src/net.cpp (4) ----
            (9) ------+++
src/rpc.cpp (1) -
            (92) -------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
            (6) ---+++
src/util.h (13) -------------
share/pixmaps/devcoin.ico (0)
share/pixmaps/favicon.ico (0)
share/pixmaps/nsis-header.bmp (0)
share/pixmaps/nsis-wizard.bmp (0)
share/ui.rc (2) -+
src/ui.cpp (2) -+
           (5) +++++
src/uibase.cpp (14) -------+++++++
src/uibase.h (6) ---+++
src/main.h (1) -
src/headers.h (21) ------------+++++++++
              (15) ---------------
src/net.cpp (3) +++
src/protocol.h (11) -++++++++++
src/xpm/bitcoin80.xpm (2) -+
src/xpm/bitcoin16.xpm (350) -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin20.xpm (315) ------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin32.xpm (341) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin48.xpm (401) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin80.xpm (492) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/init.cpp (2) -+
src/main.cpp (26) --++++++++++++++++++++++++


Compare Twobits changed files with same Sidhujag files

Twobits Files not used or cosmetic changes in Sidhujag

share/pixmaps/nsis-header.bmp (0)
share/pixmaps/nsis-wizard.bmp (0)
share/pixmaps/devcoin.ico (0)
share/pixmaps/favicon.ico (0)
ok (bmp files replaced by .png files !)
ok (ico files replaced by good ico files)

src/xpm/bitcoin80.xpm (2) -+
src/xpm/bitcoin16.xpm (350) -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin20.xpm (315) ------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin32.xpm (341) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin48.xpm (401) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin80.xpm (492) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
ok (xpm file not used by qt version -> use png instead)

src/ui.cpp (2) -+
src/uibase.cpp (14) -------+++++++
src/uibase.h (6) ---+++
ok (these files are not used by QT version -> not important : only bitcoin replace by devcoin string !)

Jul 16 2013   #fba32e5  Clean up headers. (Twobits)
src/headers.h (21) ------------+++++++++
Jul 18 2013   #29ddd73  only the ui files need to include xbm files (Twobits)
src/headers.h (15) ---------------
ok (file doesn't exist in qt version -> other file used for headers ?)

Twobits Files changes important in Sidhujag

Aug 20 2013 #4e23c18  add DNSSeeds (twobits)
https://gitorious.org/devcoin/devcoin/commit/4e23c180945785c49bbab682b7f6c6e1eda29b05

src/net.cpp   
ok ("dvcstable01.dvcnode.org" , "dvc-seed.21stcenturymoneytalk.org", "dvcstable01.devtome.com")

Aug 20 2013   #ce01e7a  match rpc port change to 52332 in official repo (twobits)
https://gitorious.org/devcoin/devcoin/commit/ce01e7af882ae6579204168e3c4d1a0871936a37

src/init.cpp (2) -+
src/rpc.cpp (6) ---+++
ok (in init.cpp replace "8332" string port by "52332" string port)
ok (rpc.cpp is subdivided in many files with rpc prefix but no string containing 52332 or 8332 -> perhaps defined in another place ? )

Jul 16 2013   #fba32e5  Clean up headers. (Twobits)
https://gitorious.org/devcoin/devcoin/commit/fba32e5e31dcaa9d0f60d7c24000b24bb1dbcea2

src/headers.h (21) ------------+++++++++
* file doesn't exist in qt version
but for BSD version need these lines
https://gitorious.org/devcoin/devcoin/commit/fba32e5e31dcaa9d0f60d7c24000b24bb1dbcea2
#define __STDC_LIMIT_MACROS
// to enable UINT64_MAX from stdint.h   
#include

src/net.cpp (3) +++
* missing (stdint include)
https://gitorious.org/devcoin/devcoin/commit/fba32e5e31dcaa9d0f60d7c24000b24bb1dbcea2
#include

src/protocol.h (11) -++++++++++
* missing (idef for win)
https://gitorious.org/devcoin/devcoin/commit/fba32e5e31dcaa9d0f60d7c24000b24bb1dbcea2
#ifndef _WIN32
#include
#include
#include
#include
#include
#endif

Jul 5 2013   #1785cc4  Add RPC commands: getblockhash and getblock (twobits)
https://gitorious.org/devcoin/devcoin/commit/1785cc420cd280abdb68b3af83d9dd3a28e5ef2d

src/main.h (1) -
* not removed (class declaration in qt version -> used in qt version ?)
//class CBlockIndex;

src/rpc.cpp (92) -------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
ok (rpc.cpp replaced by rpcblockchain.cpp)
ok (change in fonction double GetDifficulty()
ok (functions getblock and getblockhash added (same code)
* differences (in function block on three Pairs names)
In twobits |in  sidhujag
result.push_back(Pair("blockcount", blockindex->nHeight)); | result.push_back(Pair("height", blockindex->nHeight));
result.push_back(Pair("hashprevious", blockindex->pprev->GetBlockHash().GetHex())); |  result.push_back(Pair("previousblockhash", blockindex->pprev->GetBlockHash().GetHex()));
result.push_back(Pair("hashnext", blockindex->pnext->GetBlockHash().GetHex())); |  result.push_back(Pair("nextblockhash", blockindex->pnext->GetBlockHash().GetHex()));

Aug 20 2013   #6241096  BIP 30 (twobits)
https://gitorious.org/devcoin/devcoin/commit/62410960cc5c23921a18040529e2524780af8b6c

src/main.cpp (26) --++++++++++++++++++++++++
* differences
https://gitorious.org/devcoin/devcoin/commit/62410960cc5c23921a18040529e2524780af8b6c
In twobits commit , the rule applies to all blocks whose timestamp is after March 15, 2012, 0:00 UTC (1331769600)   
   and on testnet it is enabled as of februari 20, 2012, 0:00 UTC. (1329696000)
In Sidjuhag version , for DVC the rule BIP30 for Devcoin will go into effect on 2013-09-01 0:00 UTC (1377993600)
I think that Sidjuhag version is correct !

May 26 2013   #fd07754  don't need stack randomization macro with [...] (twobits)
https://gitorious.org/devcoin/devcoin/commit/fd07754b44b6fb4d4f402085c9321f9cfbff6737

ok (no stack random macro implemented in util.h and not used in any files !)

src/db.cpp (2) -+

ok (change applied in   void CDB::Flush() in Sidjuhag version)

src/irc.cpp (1) -
* no irc.cpp file in Sidjuhag version !

src/net.cpp (4) ----
ok (macro not used)

src/rpc.cpp (1) -
ok (macro not used in rpcblockchain.cpp)

src/util.h (13) -------------
ok (no stack random macro implemented)

Before reaching to a conclusion I would like comments from Sidhujag on my code report. Now I can't show if changes are the same or not (fork or not fork ?)   

Cyke64

Hello board,

 I am new to the board (and Devcoin) but after doing some basic research on how Devcoin works I have decided to start publishing on http://www.Devtome.com. After looking  at several threads on this forum I have decided to take most everything posted on Devtome at face value and assume everything is correct. After each round is over and payment has been sent out I plan on trying out several different websites that allow Devcoin to be used as payment. After I have received the product that I have purchased with Devcoins, I will post a review of the transaction on this thread.

The one site that I am looking forward to try the most is http://www.igotspots.com/other.html. The reason is because they advertise that you can purchase a one ounce silver bar from APMEX with Devcoins. If you click the payment button you can see that shipping for this item is $8.00. I changed the amount of one ounce bars that I wanted to 25 and the shipping remains the same. I am assuming that this means they offer flat rate shipping no matter what you order. This has me very excited  

I am pretty sure that others have already done reviews on I Got Spots but I think many different perspectives on transactions with one company can be helpful.

 

Bittzy78

No they should be in the QT folder, there is a chinese translation arlady done, but need to rename bitcoin to devcoin in it. Look at https://github.com/sidhujag/devcoin/tree/master/src/qt/locale

these are the langauge translations for the QT client.zh_CN i think is chinese.

Hello, where are those language files, did you remove them out? I'd make an chinese ui so our chinese user could test the client too

Ok ive uploaded 1.0.5, and I created a zip file with just the QT in it aswell incase the installer isn't updating the qt with the new version I made.

You shouldn't get that message before sending... it should be 0.5dvc like the older versions with the allowfree commented out.. i think v1.0.2 and below.

The zip and installer are in the same directory.

I've had the large transaction fee with the older client - it occurs sometimes when sending a smaller amount

Maybe I didn't re build properly after main.cpp changed... assumed incremental linker would work. Let me upload next version... it should be just 0.5 fee ..

btw guys let me know how many dvc your burning, I will refund you if you lose any. Also if it works, can you doa test of 30k coins? 50k coin? Again I will refund you any fees or lost coins.

Did you get the windows shortcut installer and uninstaller in the start programs as well? Maybe I can make the default directory c:\Devcoin?

See this link

Can we please see your incoming transactions? Or at least the # of them? The message you see insinuates it is using 80+ transactions to build your outgoing one.

Updated the client to 1.0.4. Managed to make a payment but still a 6 DVC payment fee (not that this is much though....).

Done, uplaoded v1.0.4... we should test with greater than 27k coin transactions aswell. Please see if this one works as expected.

No, take your time and relax. Fixing this can wait.

Im going to uncomment allow free code looks like it
uncovered a bug. I will leave it like it is.. The mintxfee is
set to 5*COIN.. This is what it was in devcoin src..

Now the min fee ends up being 5*coin plus dust filter 0.5*coin.. give me few
hrs I will update it back to what it was.

The payment fees seem to have changed?

A payment apparently no longer requires only 0.5 DVC but between 5.5 to 6 DVC as a minimum? See screenshots below.





Weisoq, I have hold off from sending back for now until this is clear. Happy to fill it up to 10 again if - indeed - I need to burn 6 DVC to get 4 DVC back to you (once I reach my cold storage wallet).

Done (you missed a 'B' off the end). Same again.

I agree but I think fee changed in latest.. Also going fwd they doing something with more dynamic fee structure?? not sure if its worth it for us right now.

Wouldn't it be simpler, and more supportable going forward, to simply use bitcoin's fee code with the numbers such as how many satoshis consititutes dust all multiplied by 1000 ? Isn't that what we did originally? Or did we put in anti dust before bitcoin did?

(Even if we did though, using bitcoin's code might be easier to keep up with new bitcoin code versions going forward?)

-MarkM-