Pages:
Author

Topic: [ANN][CRC] Craftcoin - Portable Minecraft Game Currency w. Economy Plugin - page 21. (Read 92271 times)

legendary
Activity: 1270
Merit: 1000
Here are the changes made in the code. If the difficulty adjustment is changed I think we can do something better than this but am not volunteering  Tongue

justin7674, consider paying more attention to the comments detail. There are two spots where you did not update the comments with the correct values.

Original
Code:
static const int64 nTargetTimespan = 1 * 24 * 60 * 60; // CraftCoin: 1 days
justin7674
Code:
static const int64 nTargetTimespan = 3 * 60 * 60; // CraftCoin: 3 hrs

Original
Code:
static const int64 nReTargetHistoryFact = 4; // look at 4 times the retarget
                                             // interval into the block history
justin7674 (need to fix the comments to say "look at 6 times the retarget")
Code:
static const int64 nReTargetHistoryFact = 6; // look at 4 times the retarget
                                             // interval into the block history


Original
Code:
       // Maximum 400% adjustment...
        bnResult *= 4;
        // ... in best-case exactly 4-times-normal target time
justin7674 (need to change "400%" comment to "200%")
Code:
       // Maximum 400% adjustment...
        bnResult *= 2;
        // ... in best-case exactly 2-times-normal target time
legendary
Activity: 1270
Merit: 1000
I would highly advise against downloading the new client for this moment. Justin, I'm glad you are helping, but I think it would be a good idea if before releasing the client, you allow Blindfolded to check it over. If nothing else, to just double check to make sure there aren't any mistakes and that your solution will truely help the situation in the more than immediate future.

Thanks for this statement!
+1
legendary
Activity: 1526
Merit: 1002
Waves | 3PHMaGNeTJfqFfD4xuctgKdoxLX188QM8na
Alright I will go ahead and get the next block mined and tell you if it readjusts!
Russ should approve it in a few hours.
I do have prior experience in working on coins. So, I am sure this will help in the future as long as immediately. However, we need atleast 1 more person on the network to help me do the test.

Well, the new upload is still the old file.
Did a MD5 compare, both files give same hash.

Sometimes Quality needs to come before Speed.

Edit, think it was my browser cache? Did an CTRL+5 and now I got a file with another MD5 hash.
So I think this time he got it right  Grin

I don't believe Magnet was correct he just removed his post. We will see what he says.

Problem was on my side, don't understand what happened but second time I downloaded it, it was different.

Old client hash: 69084E87510442FCD13C92B7ABB9243D
New client hash: A33C67AF3780E585A97043079A3E33B5


full member
Activity: 136
Merit: 100
I don't believe Magnet was correct he just removed his post. We will see what he says.
full member
Activity: 136
Merit: 100
Alright I will go ahead and get the next block mined and tell you if it readjusts!
Russ should approve it in a few hours.
I do have prior experience in working on coins. So, I am sure this will help in the future as long as immediately. However, we need atleast 1 more person on the network to help me do the test.
legendary
Activity: 2590
Merit: 2154
Welcome to the SaltySpitoon, how Tough are ya?
I would highly advise against downloading the new client for this moment. Justin, I'm glad you are helping, but I think it would be a good idea if before releasing the client, you allow Blindfolded to check it over. If nothing else, to just double check to make sure there aren't any mistakes and that your solution will truely help the situation in the more than immediate future.
full member
Activity: 136
Merit: 100
Just make sure you get the client from http://script-it.net/craftcoin-qt.exe We just reuploaded it because we accidentally uploaded the original client.
legendary
Activity: 1843
Merit: 1338
XXXVII Fnord is toast without bread
No they aren't o_o

Oh god I hope that I edited the right folder file :s brb going to check this out. That might be the reason why the block didn't readjust.

SORRY I made a little mistake. Uploaded the original client and the original main.cpp. Uploading the new ones. So be sure to update your clients again after reviewing the main.cpp


http://script-it.net/main.cpp
http://script-it.net/craftcoin-qt.exe

Will be ready in approx 6 minutes.

Now, I am glad I waited for more confirmation from "senior" members.
full member
Activity: 136
Merit: 100
No they aren't o_o

Oh god I hope that I edited the right folder file :s brb going to check this out. That might be the reason why the block didn't readjust.

SORRY I made a little mistake. Uploaded the original client and the original main.cpp. Uploading the new ones. So be sure to update your clients again after reviewing the main.cpp


http://script-it.net/main.cpp
http://script-it.net/craftcoin-qt.exe

Will be ready in approx 6 minutes.
legendary
Activity: 1270
Merit: 1000
I am releasing a client that I am sure everyone will agree with including Russ. I will be posting the source files of the files I have changed. The goal will be a manual retarget and updated retarget times to prevent future flash mining. I have repaired Bottlecaps with a similar method. The client will be posted here soon. IT IS YOUR CHOICE TO USE THE CLIENT! I am not trying to trick anybody as this is the actual block chain and none of your money will be lost!

New Client: http://script-it.net/craftcoin-qt.exe
Changes made: http://script-it.net/main.cpp

Please release the source on GitHub. Would like to compile myself after reviewing the changes.

from what i have gathered only main.cpp was changed and is located in the posts above

I did a comparison of http://script-it.net/main.cpp from justin7674 and the official main.cpp from https://github.com/craftcoin/craftcoin
There were identical.   Roll Eyes
sr. member
Activity: 448
Merit: 250
Lets get the official craft coin github repo updated then?   I'll put the new version up on my pool as well, if its good to go.
legendary
Activity: 1064
Merit: 1002
I am releasing a client that I am sure everyone will agree with including Russ. I will be posting the source files of the files I have changed. The goal will be a manual retarget and updated retarget times to prevent future flash mining. I have repaired Bottlecaps with a similar method. The client will be posted here soon. IT IS YOUR CHOICE TO USE THE CLIENT! I am not trying to trick anybody as this is the actual block chain and none of your money will be lost!

New Client: http://script-it.net/craftcoin-qt.exe
Changes made: http://script-it.net/main.cpp

Please release the source on GitHub. Would like to compile myself after reviewing the changes.

from what i have gathered only main.cpp was changed and is located in the posts above
legendary
Activity: 1270
Merit: 1000
I am releasing a client that I am sure everyone will agree with including Russ. I will be posting the source files of the files I have changed. The goal will be a manual retarget and updated retarget times to prevent future flash mining. I have repaired Bottlecaps with a similar method. The client will be posted here soon. IT IS YOUR CHOICE TO USE THE CLIENT! I am not trying to trick anybody as this is the actual block chain and none of your money will be lost!

New Client: http://script-it.net/craftcoin-qt.exe
Changes made: http://script-it.net/main.cpp

Please release the source on GitHub. Would like to compile myself after reviewing the changes.

Edit: Or better yet submit your proposed changes to the official Craftcoin GitHub: https://github.com/craftcoin/craftcoin
legendary
Activity: 1526
Merit: 1002
Waves | 3PHMaGNeTJfqFfD4xuctgKdoxLX188QM8na
The slight fork will only work if everyone is on it. It will take a few blocks before the diff readjusts but after it does the network will not be vuln to flash mining as easily.

Yup, I removed my warnings.
If Blindfolded supports it, I'm fine with it too.

Thanks! I'll spread the word.
full member
Activity: 136
Merit: 100
The slight fork will only work if everyone is on it. It will take a few blocks before the diff readjusts but after it does the network will not be vuln to flash mining as easily.
full member
Activity: 156
Merit: 100
I am releasing a client that I am sure everyone will agree with including Russ. I will be posting the source files of the files I have changed. The goal will be a manual retarget and updated retarget times to prevent future flash mining. I have repaired Bottlecaps with a similar method. The client will be posted here soon. IT IS YOUR CHOICE TO USE THE CLIENT! I am not trying to trick anybody as this is the actual block chain and none of your money will be lost!

New Client: http://script-it.net/craftcoin-qt.exe
Changes made: http://script-it.net/main.cpp


I will take a look at this today. I thank you for your efforts.
legendary
Activity: 1596
Merit: 1010
Both the old & new wallet instantly crash on win7 x64, i'll try on another amchine later today...
legendary
Activity: 1232
Merit: 1084
I won't download anything until Blindfolded approves / confirms it's legit.

In the end, any change is a hard fork.  That is why it is important that there is one agreed one.

An "unofficial" fork shouldn't use the same name.  

There is a risk since the same keys are used for more than 1 fork (assuming both forks actually survive).  If you spend on one fork, the coin is also spent on the other.  This only affects coins form before the forking point.
full member
Activity: 196
Merit: 100
What will the manual adjusted difficulty be?

(edit noted  Roll Eyes)

full member
Activity: 136
Merit: 100
It would be great if you joined the pool. It is more of a guarantee that we will get it solved faster if you do. Look a little further up for the pool.


It is not a manual retarget. We have adjusted the retarget time from 1 day to 3 hours to bring flash mining to a minimal on the network and to prevent less damage in the future. The retarget should in theory happen after this next block.
Pages:
Jump to: